Spec URL: http://tdawson.fedorapeople.org/rubygems/rubygem-simplecov.spec SRPM URL: http://tdawson.fedorapeople.org/rubygems/rubygem-simplecov-0.7.1-1.fc18.src.rpm Description: Code coverage for Ruby 1.9 with a powerful configuration library and automatic merging of coverage across test suites Fedora Account System Username: tdawson RPMLINT OUTPUT: $ rpmlint rubygem-simplecov.spec rubygem-simplecov-0.7.1-1.fc18.src.rpm rubygem-simplecov-0.7.1-1.fc18.noarch.rpm rubygem-simplecov-doc-0.7.1-1.fc18.noarch.rpm 3 packages and 1 specfiles checked; 0 errors, 0 warnings.
Can you please explain?: # Not doing tests, missing config file Requires should be (to comply with ~> operator): Requires: rubygem(multi_json) => 1.0 Requires: rubygem(multi_json) < 2.0 Requires: rubygem(simplecov-html) => %{version} Requires: rubygem(simplecov-html) < 0.8
I originally was intending to to the tests and made sure all the dependencies were there so the tests would run. But I couldn't ever get it to build in the mock areas or with a regular rpm -ba It would always fail on the tests with No SimpleCov config file found! I then tried on a regular Fedora 18, installing using just gems, and still couldn't get the test to run without the error I guess if I just removed all references to the tests, that would be cleaner.
According the code, it is expecting file "simplecov_config". Please contact upstream what should be in that file. And either create it yourself and add it as Source1 or ask upstream to include it in gem. If tests are provided with gem, they should be run. And I would say this is blocker for this review.
Spec URL: http://tdawson.fedorapeople.org/rubygems/rubygem-simplecov.spec SRPM URL: http://tdawson.fedorapeople.org/rubygems/rubygem-simplecov-0.7.1-1.fc18.src.rpm Turns out I was just running the tests in the wrong directory and they can be run without the configuration file. Of course, now this depends on a package still under review, rubygem-appraisal. https://bugzilla.redhat.com/show_bug.cgi?id=878500
>%check >cd %{buildroot}%{gem_instdir} >testrb2 -Ilib test It is prefered to do: %check pushd .%{gem_instdir} testrb2 -Ilib test popd Because if that test accidentally change something in files which will land in package, then if you are running the test in %{buildroot}%{gem_instdir}, this change will land in package as will. But if you run it in .%{gem_instdir}, then such accidential change will be isolated. This is behavior "just-in-case". It is very good habbit to bump up release number for every change of spec.... Ah, you put here wrong link. Ok I deducted: http://tdawson.fedorapeople.org/rubygems/rubygem-simplecov-0.7.1-2.fc18.src.rpm Again: export CONFIGURE_ARGS="--with-cflags='%{optflags}'" # gem install compiles any C extensions and installs into a directory does not have sense here. Please fix that directory in %check again, and that will be all.
(In reply to comment #4) > Of course, now this depends on a package rubygem-appraisal. Are you sure? I would agree if you are using Rake to execute the test suite, but you aren't. I did not tried, just asking, because I did similar experience with rubygem-audited.
Spec URL: http://tdawson.fedorapeople.org/rubygems/rubygem-simplecov.spec SRPM URL: http://tdawson.fedorapeople.org/rubygems/rubygem-simplecov-0.7.1-4.fc18.src.rpm Vit, you are correct. I did a scratch build without rubygem-appraisal and it passed it's tests. Removed rubygem-appraisal dependancy Removed unneeded C extensions stuff from spec Use pushd and popd in %check section
Looks much better. But what about license? It seems to me that upstream is using MIT, while you claim GPL or Ruby.
Spec URL: http://tdawson.fedorapeople.org/rubygems/rubygem-simplecov.spec SRPM URL: http://tdawson.fedorapeople.org/rubygems/rubygem-simplecov-0.7.1-5.fc18.src.rpm Good catch. Since the rubygems.org page didn't have it listed, I left it at the default until I was able to look at the file. Then it left my mind and I forgot. I have fixed the License to now say MIT.
I see no other problem, so: APPROVED.
New Package SCM Request ======================= Package Name: rubygem-simplecov Short Description: Code coverage analysis tool for Ruby 1.9 Owners: tdawson Branches: f18 f17 InitialCC:
Git done (by process-git-requests).
rubygem-simplecov-0.7.1-5.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/rubygem-simplecov-0.7.1-5.fc18
rubygem-simplecov-0.7.1-5.fc18 has been pushed to the Fedora 18 testing repository.
rubygem-simplecov-0.7.1-5.fc18 has been pushed to the Fedora 18 stable repository.
New Package SCM Request ======================= Package Name: rubygem-simplecov Short Description: Code coverage analysis tool for Ruby 1.9 Owners: hpejakle Branches: el5 el6 InitialCC: tdawson
You can not request additional branches using new package request. You have to use "change request". See: http://fedoraproject.org/wiki/Package_SCM_admin_requests#Package_Change_Requests_for_existing_packages
Package SCM Request ======================= Package Name: rubygem-simplecov Short Description: Code coverage analysis tool for Ruby 1.9 Owners: hpejakle Branches: el5 el6 InitialCC: tdawson
Package Change Request ====================== Package Name: rubygem-simplecov Short Description: Code coverage analysis tool for Ruby 1.9 Owners: hpejakle Branches: el5 el6 InitialCC: tdawson
Git done (by process-git-requests). Correctly formatted branches.