RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 878859 - [xfs/projid32bit] Setting projid32bit that is higher than 32-bit succeeds
Summary: [xfs/projid32bit] Setting projid32bit that is higher than 32-bit succeeds
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: xfsprogs
Version: 6.4
Hardware: x86_64
OS: Linux
unspecified
high
Target Milestone: rc
: ---
Assignee: Eric Sandeen
QA Contact: Filesystem QE
URL:
Whiteboard:
Depends On:
Blocks: 886216
TreeView+ depends on / blocked
 
Reported: 2012-11-21 12:26 UTC by Boris Ranto
Modified: 2013-03-04 00:22 UTC (History)
10 users (show)

Fixed In Version: xfsprogs-3.1.1-10.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-02-21 11:00:59 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2013:0481 0 normal SHIPPED_LIVE xfsprogs bug fix and enhancement update 2013-02-21 12:44:16 UTC

Description Boris Ranto 2012-11-21 12:26:29 UTC
Description of problem:
xfs_quota allows higher than 32-bit projid to be set simply by overflowing the integer.

Version-Release number of selected component (if applicable):
xfsprogs-3.1.1-9.el6

How reproducible:
Always

Steps to Reproduce:
1. Create and mount projid32bit enabled fs
mkfs.xfs -i projid32bit=1 /dev/sda2
mount -o pquota /dev/sda2 /media
2. Try setting higher than 32-bit projid with xfs_quota
xfs_quota -x -c 'project -s -p /media/file 5123456789' /dev/sda2
3. Check the projid
xfs_io -r -c lsproj /media/file
  
Actual results:
The xfs_quota command succeeds and xfs_io reports projid to be 828489493 = 5123456789 - 2**32.

Expected results:
The xfs_quota fails to set the higher than 32-bit projid.

Additional info:
This is easily reproducible with xfstests test case no. 244 (the last test fails).

Comment 2 Dave Chinner 2012-11-23 01:13:59 UTC
This isn't a kernel problem - the ioctl can only pass a 32 bit value. The bug will be in the userspace xfs_quota command, and it looks like it was fixed quite some time ago upstream by commit 272f4db5 ("xfsprogs: validate string -> number conversion").

-Dave.

Comment 5 Eric Sandeen 2012-11-28 22:34:26 UTC
Ok, the commit dave points at is easily applied & tested, I'm happy to respin it if we do get a blocker approved.

Comment 6 Eric Sandeen 2012-11-30 22:12:35 UTC
xfsprogs-3.1.1-10.el6 building now w/ this fix.

Comment 10 errata-xmlrpc 2013-02-21 11:00:59 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2013-0481.html


Note You need to log in before you can comment on or make changes to this bug.