Created attachment 649931[details]
log
Description of problem:
I blocked my iso domain from the vds using iptables and after it because inactive I tried activating it right after engine detected the domain as active as well.
as user I got a CanDoAction on Activate domain - looks due to lock taken by engine.
Version-Release number of selected component (if applicable):
si24.4
How reproducible:
race
Steps to Reproduce:
1. block connectivity from the vds to the iso domain using iptables
2. once the domain becomes inactive remove iptables block from vds
3. after engine acquires lock, manually activate the domain.
Actual results:
user gets CanDoAction of action ActivateStorageDomain failed. Reasons:VAR__TYPE__STORAGE__DOMAIN,VAR__ACTION__ACTIVATE,ACTION_TYPE_FAILED_STORAGE_DOMAIN_STATUS_ILLEGAL
Expected results:
1.object lock by engine should not have status illegal CanDoAction for manual actions.
2. CanDoAction if needed in this situation should have a "action in progress" message
Additional info: log
2012-11-22 17:39:10,221 WARN [org.ovirt.engine.core.vdsbroker.irsbroker.IrsBrokerCommand] (QuartzScheduler_Worker-95) [1726d659] Storage Domain eebcad17-cbf7-4098-880d-81e2c2504169:shared_iso_domain was reported by Host gold-vdsc as Active in Pool edf0ee04-0cc2-4e13-877d-1e89541aea55, moving to active status
2012-11-22 17:40:00,000 INFO [org.ovirt.engine.core.bll.AutoRecoveryManager] (QuartzScheduler_Worker-77) [2dbb2bf6] Checking autorecoverable hosts
2012-11-22 17:40:00,001 INFO [org.ovirt.engine.core.bll.AutoRecoveryManager] (QuartzScheduler_Worker-77) [2dbb2bf6] Autorecovering 0 hosts
2012-11-22 17:40:00,001 INFO [org.ovirt.engine.core.bll.AutoRecoveryManager] (QuartzScheduler_Worker-77) [2dbb2bf6] Checking autorecoverable hosts done
2012-11-22 17:40:00,001 INFO [org.ovirt.engine.core.bll.AutoRecoveryManager] (QuartzScheduler_Worker-77) [2dbb2bf6] Autorecovering storage domains is disabled, skipping
2012-11-22 17:40:27,673 INFO [org.ovirt.engine.core.bll.storage.ActivateStorageDomainCommand] (ajp-/127.0.0.1:8702-6) Lock Acquired to object EngineLock [exclusiveLocks= key: eebcad17-cbf7-4098-880d-81e2c2504169 value: STORAGE
, sharedLocks= ]
2012-11-22 17:40:27,734 WARN [org.ovirt.engine.core.bll.storage.ActivateStorageDomainCommand] (ajp-/127.0.0.1:8702-6) CanDoAction of action ActivateStorageDomain failed. Reasons:VAR__TYPE__STORAGE__DOMAIN,VAR__ACTION__ACTIVATE,ACTION_TYPE_FAILED_STORAGE_DOMAIN_STATUS_ILLEGAL
2012-11-22 17:40:27,734 INFO [org.ovirt.engine.core.bll.storage.ActivateStorageDomainCommand] (ajp-/127.0.0.1:8702-6) Lock freed to object EngineLock [exclusiveLocks= key: eebcad17-cbf7-4098-880d-81e2c2504169 value: STORAGE
, sharedLocks= ]
(END)
Created attachment 649931 [details] log Description of problem: I blocked my iso domain from the vds using iptables and after it because inactive I tried activating it right after engine detected the domain as active as well. as user I got a CanDoAction on Activate domain - looks due to lock taken by engine. Version-Release number of selected component (if applicable): si24.4 How reproducible: race Steps to Reproduce: 1. block connectivity from the vds to the iso domain using iptables 2. once the domain becomes inactive remove iptables block from vds 3. after engine acquires lock, manually activate the domain. Actual results: user gets CanDoAction of action ActivateStorageDomain failed. Reasons:VAR__TYPE__STORAGE__DOMAIN,VAR__ACTION__ACTIVATE,ACTION_TYPE_FAILED_STORAGE_DOMAIN_STATUS_ILLEGAL Expected results: 1.object lock by engine should not have status illegal CanDoAction for manual actions. 2. CanDoAction if needed in this situation should have a "action in progress" message Additional info: log 2012-11-22 17:39:10,221 WARN [org.ovirt.engine.core.vdsbroker.irsbroker.IrsBrokerCommand] (QuartzScheduler_Worker-95) [1726d659] Storage Domain eebcad17-cbf7-4098-880d-81e2c2504169:shared_iso_domain was reported by Host gold-vdsc as Active in Pool edf0ee04-0cc2-4e13-877d-1e89541aea55, moving to active status 2012-11-22 17:40:00,000 INFO [org.ovirt.engine.core.bll.AutoRecoveryManager] (QuartzScheduler_Worker-77) [2dbb2bf6] Checking autorecoverable hosts 2012-11-22 17:40:00,001 INFO [org.ovirt.engine.core.bll.AutoRecoveryManager] (QuartzScheduler_Worker-77) [2dbb2bf6] Autorecovering 0 hosts 2012-11-22 17:40:00,001 INFO [org.ovirt.engine.core.bll.AutoRecoveryManager] (QuartzScheduler_Worker-77) [2dbb2bf6] Checking autorecoverable hosts done 2012-11-22 17:40:00,001 INFO [org.ovirt.engine.core.bll.AutoRecoveryManager] (QuartzScheduler_Worker-77) [2dbb2bf6] Autorecovering storage domains is disabled, skipping 2012-11-22 17:40:27,673 INFO [org.ovirt.engine.core.bll.storage.ActivateStorageDomainCommand] (ajp-/127.0.0.1:8702-6) Lock Acquired to object EngineLock [exclusiveLocks= key: eebcad17-cbf7-4098-880d-81e2c2504169 value: STORAGE , sharedLocks= ] 2012-11-22 17:40:27,734 WARN [org.ovirt.engine.core.bll.storage.ActivateStorageDomainCommand] (ajp-/127.0.0.1:8702-6) CanDoAction of action ActivateStorageDomain failed. Reasons:VAR__TYPE__STORAGE__DOMAIN,VAR__ACTION__ACTIVATE,ACTION_TYPE_FAILED_STORAGE_DOMAIN_STATUS_ILLEGAL 2012-11-22 17:40:27,734 INFO [org.ovirt.engine.core.bll.storage.ActivateStorageDomainCommand] (ajp-/127.0.0.1:8702-6) Lock freed to object EngineLock [exclusiveLocks= key: eebcad17-cbf7-4098-880d-81e2c2504169 value: STORAGE , sharedLocks= ] (END)