Bug 879368 - maven-help-plugin: LICENSE and NOTICE files are not installed
Summary: maven-help-plugin: LICENSE and NOTICE files are not installed
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: maven-help-plugin
Version: 18
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Mikolaj Izdebski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-11-22 17:13 UTC by Mikolaj Izdebski
Modified: 2013-02-08 02:32 UTC (History)
7 users (show)

Fixed In Version: 2.1.1-8
Clone Of:
Environment:
Last Closed: 2013-02-08 02:32:22 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Mikolaj Izdebski 2012-11-22 17:13:49 UTC
Description of problem:
LICENSE and NOTICE files are not installed. This must be done to comply with locensiong terms of ASL 2.0.

Version-Release number of selected component (if applicable):
2.1.1-7

Additional info:
See licensing guidelines

Comment 1 Weinan Li 2012-12-24 14:54:43 UTC
I will lead kingheaven to work on this issue.

Comment 2 Weinan Li 2013-01-04 07:19:04 UTC
While we are working on this issue we've found two problems during build process:

1. HelpMojo.java are not generated correctly first time.

When the first time 'mvn-rpmbuild install' is executed, it could not generate 'HelpMojo.java' correctly and the compile would fail. But if you execute 'mvn-rpmbuild ...' in INSTALL dir again, the 'HelpMojo.java' will be generated correctly.

2. DescribeMojo.java:[1089,30] error: cannot find symbol

Line 1089 is:

return PluginUtils.toText( description );

This could be a version compatible issue. In Fedora 18 and rawhide we are using 'maven-plugin-plugin 3.1' and we don't have the 'toText' method in 'PluginUtils'.

Comment 3 Mikolaj Izdebski 2013-01-04 18:11:22 UTC
(In reply to comment #2)
> This could be a version compatible issue. In Fedora 18 and rawhide we are
> using 'maven-plugin-plugin 3.1' and we don't have the 'toText' method in
> 'PluginUtils'.

In newer versions of maven-plugin-plugin this method can be found in GeneratorUtils class in org.apache.maven.tools.plugin.generator package.

Comment 4 Mikolaj Izdebski 2013-01-07 12:03:55 UTC
(In reply to comment #2)
> 1. HelpMojo.java are not generated correctly first time.
> 
> When the first time 'mvn-rpmbuild install' is executed, it could not
> generate 'HelpMojo.java' correctly and the compile would fail. But if you
> execute 'mvn-rpmbuild ...' in INSTALL dir again, the 'HelpMojo.java' will be
> generated correctly.

This is probably caused by incompatible version of maven-plugin-tools. The generated HelpMojo.java is just missing package declaration. The fix is to inject package declaration during build time (in process-sources Maven phase, to be more specific).

Comment 5 Mikolaj Izdebski 2013-01-07 14:17:54 UTC
Fixed in maven-help-plugin-2.1.1-8

Comment 6 Fedora Update System 2013-01-07 15:13:43 UTC
maven-help-plugin-2.1.1-8.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/maven-help-plugin-2.1.1-8.fc18

Comment 7 Fedora Update System 2013-01-07 21:18:58 UTC
Package maven-help-plugin-2.1.1-8.fc18:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing maven-help-plugin-2.1.1-8.fc18'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-0356/maven-help-plugin-2.1.1-8.fc18
then log in and leave karma (feedback).

Comment 8 Fedora Update System 2013-02-08 02:32:25 UTC
maven-help-plugin-2.1.1-8.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.