Spec URL: http://odysseus.x-tnd.be/fedora/php-Slim/php-Slim.spec SRPM URL: http://odysseus.x-tnd.be/fedora/php-Slim/php-Slim-2.1.0-2.fc17.src.rpm Description: PHP micro framework Fedora Account System Username: trasher
Created attachment 651409 [details] php-Slim-review.txt Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16 Buildroot used: fedora-17-x86_64 Command line :/usr/bin/fedora-review -b 879397 Please fixed the listed issues.
Thank you for taking this one :) I'll fix the issues very soon. You're right about the paths, I'll change them, no need for an additional sub directory :)
Here the new version: Spec URL: http://odysseus.x-tnd.be/fedora/php-Slim/php-Slim.spec RPSM URL: http://odysseus.x-tnd.be/fedora/php-Slim/php-Slim-2.1.0-3.fc17.src.rpm And the specfile's diff: http://odysseus.x-tnd.be/fedora/php-Slim/2.1.0-2_2.1.0-3.diff
Hum... I forget to remove phpunit.xml.dist from %doc... The new version: Spec URL: http://odysseus.x-tnd.be/fedora/php-Slim/php-Slim.spec RPMS URL: http://odysseus.x-tnd.be/fedora/php-Slim/php-Slim-2.1.0-4.fc17.src.rpm And the specfile's diff: http://odysseus.x-tnd.be/fedora/php-Slim/2.1.0-3_2.1.0-4.diff
I did not pay attention to a rpmlint issue on phpunit.xml.dist permissions. I've also removed the %if in %check that is not needeed. Here the new version: Spec URL: http://odysseus.x-tnd.be/fedora/php-Slim/php-Slim.spec SRPM URL: http://odysseus.x-tnd.be/fedora/php-Slim/php-Slim-2.1.0-5.fc17.src.rpm And the specfile's diff: http://odysseus.x-tnd.be/fedora/php-Slim/2.1.0-4_2.1.0-5.diff
All blockers taken off, looks good. ==== APPROVED ====
New Package SCM Request ======================= Package Name: php-Slim Short Description: PHP micro framework Owners: trasher Branches: f17 f18 el6 InitialCC:
Git done (by process-git-requests).
php-Slim-2.1.0-5.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/php-Slim-2.1.0-5.fc17
php-Slim-2.1.0-5.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-Slim-2.1.0-5.el6
php-Slim-2.1.0-5.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-Slim-2.1.0-5.fc18
php-Slim-2.1.0-5.fc17 has been pushed to the Fedora 17 testing repository.
php-Slim-2.1.0-5.fc17 has been pushed to the Fedora 17 stable repository.
php-Slim-2.1.0-5.fc18 has been pushed to the Fedora 18 stable repository.
php-Slim-2.1.0-5.el6 has been pushed to the Fedora EPEL 6 stable repository.