Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 880039

Summary: repo URLs are not escaped correctly when written to /etc/yum.repos.d
Product: [Retired] Beaker Reporter: Dan Callaghan <dcallagh>
Component: schedulerAssignee: Dan Callaghan <dcallagh>
Status: CLOSED CURRENTRELEASE QA Contact: Qixiang Wan <qwan>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 0.9CC: asaha, bhu, bpeck, davids, dcallagh, jburke, jstancek, mboswell, mishin, qwan, rglasz, rmancy, santiago
Target Milestone: 0.11   
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
Whiteboard: Kickstart
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 869758 Environment:
Last Closed: 2013-01-17 04:33:55 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Comment 1 Dan Callaghan 2012-11-27 04:23:14 UTC
On Gerrit: http://gerrit.beaker-project.org/1515

Comment 2 Jan Stancek 2012-11-27 08:03:43 UTC
Will the old way still work or do we need to make sure that all workflows/users switch to new format (without escaping '$')?

Comment 3 Dan Callaghan 2012-11-27 08:13:25 UTC
(In reply to comment #2)
> Will the old way still work or do we need to make sure that all
> workflows/users switch to new format (without escaping '$')?

I was expecting we would include a note in the release announcement warning people that they no longer need to escape $ to work around this bug. Do you think changing it would be too burdensome?

I think it would be a nasty hack to make Beaker find escaped \$ and unescape them first, so I would rather not do that...

Comment 4 Jan Stancek 2012-11-27 08:40:06 UTC
(In reply to comment #3)
> (In reply to comment #2)
> > Will the old way still work or do we need to make sure that all
> > workflows/users switch to new format (without escaping '$')?
> 
> I was expecting we would include a note in the release announcement warning
> people that they no longer need to escape $ to work around this bug. Do you
> think changing it would be too burdensome?

I think it shouldn't be hard to change, but it may take some time to update any scripts/tools/etc.

> I think it would be a nasty hack to make Beaker find escaped \$ and unescape 
> them first, so I would rather not do that...

Can users be warned before this change is deployed?

Comment 5 Nick Coghlan 2012-11-27 09:01:23 UTC
We'll send an alert to the mailing lists when we merge this for 0.11, and highlight it in the release announcement.

Comment 9 Dan Callaghan 2013-01-17 04:33:55 UTC
Beaker 0.11.0 has been released.