Spec URL: http://people.freedesktop.org/~hughsient/temp/PackageKit-Qt.spec SRPM URL: http://people.freedesktop.org/~hughsient/temp/PackageKit-Qt-0.8.6-1.fc18.src.rpm Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4728316 Description: PackageKit-qt is a Qt support library for PackageKit Fedora Account System Username: rhughes $ rpmlint rpmbuild/*RPMS/PackageKit-Qt-* 4 packages and 0 specfiles checked; 0 errors, 0 warnings. This package is the Qt code split out from the PackageKit project. The new package is blocking the release of PackageKit 0.8.6 as projects such as apper require the Qt interfaces provided by PackageKit-Qt. I'd really appreciate any help on this package as I'm a bit of a cmake newbie. Thanks. Richard.
I can help with the review, it's fairly small and should be pretty simple and straight-forward...
$ rpmlint *.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. naming: ok sources: ok 41f6fa67e980733d7d8a2cd881bbe5b4 PackageKit-Qt-0.8.6.tar.gz license: ok $ licensecheck -r src src/daemonprivate.h: LGPL (v2 or later) src/transactionprivate.h: LGPL (v2 or later) src/common.h: LGPL (v2 or later) src/bitfield.cpp: *No copyright* UNKNOWN src/daemonprivate.cpp: LGPL (v2 or later) src/daemon.cpp: LGPL (v2 or later) src/transaction.h: LGPL (v2 or later) src/bitfield.h: *No copyright* UNKNOWN src/transaction.cpp: LGPL (v2 or later) src/transactionprivate.cpp: LGPL (v2 or later) src/daemon.h: LGPL (v2 or later) macros: ok builds/installs: mostly ok, but... 1. MUST: need some Obsoletes (and at least a temporary Provides) here to handle upgrade from older PackageKit-qt... Obsoletes: PackageKit-qt < 0.8.6 Provides: PackageKit-qt = %{version}-%{release} Provides: PackageKit-qt%{?_isa} = %{version}-%{release} and for -devel subpkg: Obsoletes: PackageKit-qt-devel < 0.8.6 Provides: PackageKit-qt-devel = %{version}-%{release} that seems to be the only review blocker i see. there's a handful of smaller SHOULD things we can do, but i'll be happy to wait until after import to help implement that.
(In reply to comment #2) > 1. MUST: need some Obsoletes (and at least a temporary Provides) here to > handle upgrade from older PackageKit-qt... > > Obsoletes: PackageKit-qt < 0.8.6 > Provides: PackageKit-qt = %{version}-%{release} > Provides: PackageKit-qt%{?_isa} = %{version}-%{release} > > and for -devel subpkg: > Obsoletes: PackageKit-qt-devel < 0.8.6 > Provides: PackageKit-qt-devel = %{version}-%{release} Fixed in: Spec URL: http://people.freedesktop.org/~hughsient/temp/PackageKit-Qt.spec SRPM URL: http://people.freedesktop.org/~hughsient/temp/PackageKit-Qt-0.8.6-1.fc18.src.rpm Thanks for the super-speedy review. Richard.
invert the order of your changelog (newest first), and we have a winner. :) please add me (rdieter) as comaintainer. APPROVED
(In reply to comment #4) > invert the order of your changelog (newest first), and we have a winner. :) Gahh, Monday :) Sorry about that. Fixed.
New Package SCM Request ======================= Package Name: PackageKit-Qt Short Description: Qt support library for PackageKit Owners: rhughes rdieter Branches: f17 f18 InitialCC: rdieter
Git done (by process-git-requests).
Thanks guys!