Bugzilla (bugzilla.redhat.com) will be under maintenance for infrastructure upgrades and will not be available on July 31st between 12:30 AM - 05:30 AM UTC. We appreciate your understanding and patience. You can follow status.redhat.com for details.
Bug 880155 - Review Request: PackageKit-Qt - Qt support library for PackageKit
Summary: Review Request: PackageKit-Qt - Qt support library for PackageKit
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-11-26 11:31 UTC by Richard Hughes
Modified: 2012-11-27 08:11 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-11-27 08:11:47 UTC
Type: ---
rdieter: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Richard Hughes 2012-11-26 11:31:58 UTC
Spec URL: http://people.freedesktop.org/~hughsient/temp/PackageKit-Qt.spec
SRPM URL: http://people.freedesktop.org/~hughsient/temp/PackageKit-Qt-0.8.6-1.fc18.src.rpm
Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4728316
Description: PackageKit-qt is a Qt support library for PackageKit
Fedora Account System Username: rhughes

$ rpmlint rpmbuild/*RPMS/PackageKit-Qt-*
4 packages and 0 specfiles checked; 0 errors, 0 warnings.

This package is the Qt code split out from the PackageKit project. The new package is blocking the release of PackageKit 0.8.6 as projects such as apper require the Qt interfaces provided by PackageKit-Qt. I'd really appreciate any help on this package as I'm a bit of a cmake newbie. Thanks.

Richard.

Comment 1 Rex Dieter 2012-11-26 15:21:14 UTC
I can help with the review, it's fairly small and should be pretty simple and straight-forward...

Comment 2 Rex Dieter 2012-11-26 15:55:50 UTC
$ rpmlint *.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

naming: ok

sources: ok
41f6fa67e980733d7d8a2cd881bbe5b4  PackageKit-Qt-0.8.6.tar.gz

license: ok
$ licensecheck -r src
src/daemonprivate.h: LGPL (v2 or later)
src/transactionprivate.h: LGPL (v2 or later)
src/common.h: LGPL (v2 or later)
src/bitfield.cpp: *No copyright* UNKNOWN
src/daemonprivate.cpp: LGPL (v2 or later)
src/daemon.cpp: LGPL (v2 or later)
src/transaction.h: LGPL (v2 or later)
src/bitfield.h: *No copyright* UNKNOWN
src/transaction.cpp: LGPL (v2 or later)
src/transactionprivate.cpp: LGPL (v2 or later)
src/daemon.h: LGPL (v2 or later)

macros: ok

builds/installs: mostly ok, but...

1.  MUST: need some Obsoletes (and at least a temporary Provides) here to handle upgrade from older PackageKit-qt... 

Obsoletes: PackageKit-qt < 0.8.6
Provides:  PackageKit-qt = %{version}-%{release}
Provides:  PackageKit-qt%{?_isa} = %{version}-%{release}

and for -devel subpkg:
Obsoletes: PackageKit-qt-devel < 0.8.6
Provides:  PackageKit-qt-devel = %{version}-%{release}


that seems to be the only review blocker i see.  there's a handful of smaller SHOULD things we can do, but i'll be happy to wait until after import to help implement that.

Comment 3 Richard Hughes 2012-11-26 16:03:21 UTC
(In reply to comment #2)
> 1.  MUST: need some Obsoletes (and at least a temporary Provides) here to
> handle upgrade from older PackageKit-qt... 
> 
> Obsoletes: PackageKit-qt < 0.8.6
> Provides:  PackageKit-qt = %{version}-%{release}
> Provides:  PackageKit-qt%{?_isa} = %{version}-%{release}
> 
> and for -devel subpkg:
> Obsoletes: PackageKit-qt-devel < 0.8.6
> Provides:  PackageKit-qt-devel = %{version}-%{release}

Fixed in:

Spec URL: http://people.freedesktop.org/~hughsient/temp/PackageKit-Qt.spec
SRPM URL: http://people.freedesktop.org/~hughsient/temp/PackageKit-Qt-0.8.6-1.fc18.src.rpm

Thanks for the super-speedy review.

Richard.

Comment 4 Rex Dieter 2012-11-26 16:05:49 UTC
invert the order of your changelog (newest first), and we have a winner. :)

please add me (rdieter) as comaintainer.

APPROVED

Comment 5 Richard Hughes 2012-11-26 16:42:43 UTC
(In reply to comment #4)
> invert the order of your changelog (newest first), and we have a winner. :)

Gahh, Monday :) Sorry about that. Fixed.

Comment 6 Richard Hughes 2012-11-26 16:45:24 UTC
New Package SCM Request
=======================
Package Name: PackageKit-Qt
Short Description: Qt support library for PackageKit
Owners: rhughes rdieter
Branches: f17 f18
InitialCC: rdieter

Comment 7 Gwyn Ciesla 2012-11-26 16:53:50 UTC
Git done (by process-git-requests).

Comment 8 Richard Hughes 2012-11-27 08:11:47 UTC
Thanks guys!


Note You need to log in before you can comment on or make changes to this bug.