Spec URL: http://msivak.fedorapeople.org/newpkg/python-di.spec SRPM URL: http://msivak.fedorapeople.org/newpkg/python-di-0.1-1.fc17.src.rpm Description: Python library for dependency injection design patterns (also known as Inversion of Control). Its purpose is to help isolate units from each other without changing the code and algorithms much. It is helping mostly in environments and teams where high unittest coverage is a goal. Fedora Account System Username: msivak
The source tarball contains a bundled egg-info. Please remove it before building your package (in the %prep section): rm -rf di.egg-info See https://fedoraproject.org/wiki/Packaging:Python_Eggs#Upstream_Eggs for more information. Additionally, you will need python-setuptools in BuildRequires. Another question: Are you planning to provide this package for EPEL 5?
Thanks, new versions of the spec file and SRPM should be at the addresses in #1. I wasn't planning on providing it for EPEL 5 since I am using some new python features (functools) which were not available in 2.4. It might be possible to port it there though.
I'll review this
Tarball inside srpm is different from upstream. I'll continue the review after this is fixed since I can't be sure about rest of my results before that.
Updated SRPM and spec file: Spec URL: http://msivak.fedorapeople.org/newpkg/python-di.spec SRPM URL: http://msivak.fedorapeople.org/newpkg/python-di-0.2-1.fc17.src.rpm
Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package contains BR: python2-devel or python3-devel See: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package contains no bundled libraries. [x]: Changelog in prescribed format. - I'd suggest verifying your git configuration since your email domain is a bit weird [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. It doesn't have any docs for that matter... [-]: Package is not known to require ExcludeArch. [x]: Package complies to the Packaging Guidelines [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [-]: Large documentation must go in a -doc subpackage. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Binary eggs must be removed in %prep [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [!]: Package meets the Packaging Guidelines::Python See buildrequires guidelines ===== SHOULD items ===== Generic: [!]: Buildroot is not present Note: Buildroot: present but not needed Buildroot is not needed [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. Since you are the upstream...please add license text to your releases [x]: Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [!]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) clean section is not needed any more [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Spec file according to URL is the same as in SRPM. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: python-di-0.2-1.fc19.noarch.rpm python-di.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint python-di python-di.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. # echo 'rpmlint-done:' Requires -------- python-di (rpmlib, GLIBC filtered): python(abi) Provides -------- python-di: python-di MD5-sum check ------------- http://pypi.python.org/packages/source/d/di/di-0.2.tar.gz : CHECKSUM(SHA256) this package : 5581a84ae561663ed6049591837121b33092e62533866e92b1a8a1ee5a42e9b2 CHECKSUM(SHA256) upstream package : 5581a84ae561663ed6049591837121b33092e62533866e92b1a8a1ee5a42e9b2 Generated by fedora-review 0.3.1 (f7281d5) last change: 2012-10-16 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -b 880195 All in all: the spec could use a few cleanups from unneeded cruft (buildroot definition, clean section), there's a license which you as upstream should add and it's missing python2-devel buildrequires. Other than that it's pretty simple package, but I'll wait for new release before approving if you don't midn
I'd prefer a new tarball & new srpm release during review but oh well... Looks OK now.
New Package SCM Request ======================= Package Name: python-di Short Description: Dependency injection library for python unittesters Owners: msivak Branches: f17 f18 el6 InitialCC:
Git done (by process-git-requests).