RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 880598 - objdb: Don't read uninitialized memory in inc/dec
Summary: objdb: Don't read uninitialized memory in inc/dec
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: corosync
Version: 6.3
Hardware: All
OS: All
low
low
Target Milestone: rc
: ---
Assignee: Jan Friesse
QA Contact: Cluster QE
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-11-27 12:11 UTC by Jan Friesse
Modified: 2013-11-21 04:31 UTC (History)
3 users (show)

Fixed In Version: corosync-1.4.1-16.el6
Doc Type: Bug Fix
Doc Text:
Cause: Value of [u]int16 type is incremented/decremented via objdb/confdb call Consequence: API can return invalid value, because uninitialized memory is read Fix: Read only 16-bits of value instead of 32 Result: Correct value is returned and uninitialized memory is not read.
Clone Of:
Environment:
Last Closed: 2013-11-21 04:31:58 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Proposed patch (3.24 KB, patch)
2012-11-27 12:11 UTC, Jan Friesse
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2013:1531 0 normal SHIPPED_LIVE corosync bug fix and enhancement update 2013-11-21 00:40:57 UTC

Description Jan Friesse 2012-11-27 12:11:23 UTC
Created attachment 652644 [details]
Proposed patch

Description of problem:

When object_key_increment or _decrement is called on [u]int16 value,
uninitialized value is read as result value.

Version-Release number of selected component (if applicable):
All

How reproducible:
100%

Steps to Reproduce:
1. Store [u]int16 value in confdb
2. Call object_key_increment on this key
3. valgrind will tell about access to uninitialized memory. From time to time, returned value (last parameter of object_key_increment) can be unexpected value.
  
Actual results:
Read of uninitialized value

Expected results:
No read of uninitialized value

Additional info:
"Unit test":
https://github.com/jfriesse/csts/blob/master/tests/confdb-incdec.sh

Comment 9 Jaroslav Kortus 2013-09-11 15:38:15 UTC
Verified using confdb-incdec.sh:

FAIL on corosync-1.4.1-15.el6.x86_64 (RHEL6.4) (/root/csts-apps/confdb-incdec.c:68: incdec: Assertion `res == i16inc' failed)
PASS on corosync-1.4.1-17.el6.x86_64 (RHEL6.5)

Comment 11 errata-xmlrpc 2013-11-21 04:31:58 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2013-1531.html


Note You need to log in before you can comment on or make changes to this bug.