Bug 880767 - pep8 checking not working
Summary: pep8 checking not working
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: eclipse-pydev
Version: 18
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Sami Wagiaalla
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-11-27 18:55 UTC by Carlos Soriano
Modified: 2016-06-07 22:46 UTC (History)
10 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2013-02-21 05:40:13 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
project used to test pep8 (774 bytes, application/zip)
2012-11-27 18:55 UTC, Carlos Soriano
no flags Details
Normal sintax checking and pep8 not working (86.70 KB, image/png)
2013-01-20 18:17 UTC, Carlos Soriano
no flags Details
Screen shot of pep8 violations (65.38 KB, image/png)
2013-02-07 16:43 UTC, Sami Wagiaalla
no flags Details

Description Carlos Soriano 2012-11-27 18:55:47 UTC
Created attachment 653018 [details]
project used to test pep8

Description of problem:
pep8 checking in eclipse is not working, it not mark anything as incorrect.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
Fresh install of fedora 18 or fresh install of fedora 17
Install fedora eclipse.
Then go to pydev, editor, code analysis and pep8 tab, and check error.
Apply
Restart eclipse
Right click on a known bad pep8 syntax python file.
Code analysis.
Some dialogue appears during half second.
Nothing happens

*Things I checked:
pydev->editor->code analysis -> do code analysis already checked.
Path of pep8.py by default. The file already exists.

  
Actual results:
nothing happens

Expected results:
pep8 checking and error markers in eclipse

Additional info:

Comment 1 Carlos Soriano 2012-12-13 19:50:14 UTC
I just take notice that the entire code analysis of pydev is not working.

Comment 2 Sami Wagiaalla 2012-12-13 21:26:51 UTC
I can reproduce this. I'll take a look.

Comment 3 Fedora Update System 2012-12-17 18:30:45 UTC
eclipse-pydev-2.7.1-3.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/eclipse-pydev-2.7.1-3.fc18

Comment 4 Fedora Update System 2012-12-17 18:31:59 UTC
eclipse-pydev-2.7.1-3.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/eclipse-pydev-2.7.1-3.fc17

Comment 5 Sami Wagiaalla 2012-12-17 19:09:45 UTC
Carols,

Can you try one of the above updates and let me know if it fixes your issue

Comment 6 Fedora Update System 2012-12-18 02:32:59 UTC
Package eclipse-pydev-2.7.1-3.fc17:
* should fix your issue,
* was pushed to the Fedora 17 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing eclipse-pydev-2.7.1-3.fc17'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-20538/eclipse-pydev-2.7.1-3.fc17
then log in and leave karma (feedback).

Comment 7 Fedora Update System 2013-01-07 19:28:47 UTC
eclipse-pydev-2.7.1-4.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/eclipse-pydev-2.7.1-4.fc18

Comment 8 Carlos Soriano 2013-01-08 00:06:51 UTC
I tested now in fedora 18 and seems that's not working.

I did:
su -c 'yum update --enablerepo=updates-testing eclipse-pydev-2.7.1-3.fc18'

sudo yum update

then:
Open eclipse, and right click into a wrong pep8 file and Code analisys, and nothing happens.

Comment 9 Sami Wagiaalla 2013-01-08 15:06:51 UTC
Can you give me an example file with wrong pep8.
I was hoping it would be fixed now that general error checking is working.

Comment 10 Carlos Soriano 2013-01-08 16:13:09 UTC
Do you have one at the first comment in this bug report. The example contains syntax errors and pep8 errors.
Some wrong things that pep8 has to take notice you are:
-Not enough space between class statement and first function "def" statement
-Class name must has the first letter in uppercase
-Function name must has the first letter in lowercase
- etc.

Now, only syntax errors are displayed.

Comment 11 Fedora Update System 2013-01-20 03:10:51 UTC
eclipse-pydev-2.7.1-3.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2013-01-20 03:12:06 UTC
eclipse-pydev-2.7.1-4.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 13 Carlos Soriano 2013-01-20 18:17:45 UTC
Created attachment 683760 [details]
Normal sintax checking and pep8 not working

The bug is closed, but I still have the errors with the latest update. I checked if this update is in the latest update, and yes, it is.

Also, I don't think the "general error checking" is working, the current behaviour is showing the warnings with red color, and I don't think it is the wanted behaviour.

See picture attached.

Comment 14 Sami Wagiaalla 2013-01-21 14:56:06 UTC
The bug is closed automatically because I associated it with the update. I am reopening it.

Comment 15 Sami Wagiaalla 2013-02-07 16:43:38 UTC
Created attachment 694590 [details]
Screen shot of pep8 violations

Comment 16 Sami Wagiaalla 2013-02-07 16:43:56 UTC
Hi Carlos,

Sorry for the delay; it took me a while to get to this bug.
Take a look at the attached screenshot. Is the error checking there correct ?

Comment 17 Fedora Update System 2013-02-12 15:22:26 UTC
eclipse-pydev-2.7.1-6.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/eclipse-pydev-2.7.1-6.fc18

Comment 18 Fedora Update System 2013-02-12 15:23:41 UTC
eclipse-pydev-2.7.1-6.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/eclipse-pydev-2.7.1-6.fc17

Comment 19 Fedora Update System 2013-02-13 04:30:35 UTC
Package eclipse-pydev-2.7.1-6.fc18:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing eclipse-pydev-2.7.1-6.fc18'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-2369/eclipse-pydev-2.7.1-6.fc18
then log in and leave karma (feedback).

Comment 20 Fedora Update System 2013-02-21 05:40:15 UTC
eclipse-pydev-2.7.1-6.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 21 Fedora Update System 2013-02-21 05:41:08 UTC
eclipse-pydev-2.7.1-6.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 22 Carlos Soriano 2013-02-26 15:43:36 UTC
Sami Wagiaalla,

Yes, the screenshot is correct =)
Thanks for the patch!


Note You need to log in before you can comment on or make changes to this bug.