Hide Forgot
Created attachment 653168 [details] Screenshot of two openshift pages using different favicons Description of problem: The favicon for the community site is incorrect. Version-Release number of selected component (if applicable): How reproducible: Always Steps to Reproduce: 1. Open any page in the community site 2. View favicon Actual results: Favicon is wrong Expected results: Favicon is normal OpenShift logo Additional info: The console and home page have the correct favicon, but the drupal site is using an old, incorrect favicon of dubious origin.
Looks correct to me?
(In reply to comment #1) hi Clayton, I think Emily means this Bug 879510, which is already closed as not a bug.
(In reply to comment #1) Hi Clayton, did you fix this bug? Can you give me the pull request? Thanks!
Tested on devenv_2582, it is still not fixed, so assign it back.
(In reply to comment #1) This issue also exists on safari, details see my screenshot on Mac.
Created attachment 662106 [details] different favicons on Safari
Fixed in https://github.com/openshift/li/pull/780
Commit pushed to master at https://github.com/openshift/li https://github.com/openshift/li/commit/e820417da9a6b9c6443092c86fb66a630102d58d Bug 880854 - Fix community favicon in some browsers
(In reply to comment #7) Tested on devenv_2716, community is using the same favicon on Safari5, on Chrome24, the favicon of community is different with console, the circle is bolder, it's not easy to figure, but that should be Emily's point. on IE9 and IE10, the favicon can not be displayed correctly, details you can see in the attachment.So, could you please check this again? Thanks!
Created attachment 686423 [details] favicons on Chrome24,IE9 and IE10
I've added a note to the operations ticket for both openshift.redhat.com and openshift.com to make sure this icon is available.
Verify this on INT once https://engineering.redhat.com/trac/Libra/wiki/Releases/2.0.24#Comment22clayton is completed
Tested on INT(devenv_2905), the issue still exists, will test it again when the above note is completed.
Tested on INT(devenv_2910), the issue still exists, could you please check this again? Details see in attachment.
Created attachment 706943 [details] new screenshot
Ops fixed another issue.
Tried on devenv-stage_331, this issue still exists, could you please specify the pull request? or where should I test this issue? Thanks!
Additional fix https://github.com/sg00dwin/li/commit/4bc445ed16bb59354a46ec468e8d68da33ae08c9
Created attachment 732262 [details] different on chrome 26 tried on devenv_304,still appear
Created attachment 732263 [details] different on chrome 26 tried on devenv_304 , still appear
Assign this bug back as it's still reproduced on devenv_3049 as mentioned above. Thanks.
Are you seeing this on Chrome on the Windows platform? I'm seeing the same favicon on Chrome 26 on the OS X. see screenshot
Created attachment 735957 [details] Chrome 26 on Mac shows same favicon
Created attachment 737109 [details] chrome26 on win7 with the code of the part of "head"
the head code of "community" have two rel="shortcut icon", and /app/login page have only one. I guess maybe browser use the first "shortcut icon" on community page.
We pushed a small fix as part of changes last sprint, is this still occurring? I can't reproduce against production (the icon doesn't show up at first, but on subsequent loads it does show up).
Created attachment 745149 [details] google-chrome 26 for devenv_3194
That looks correct to me?
Please notice the head part code of every page, some page(community releated) have two rel="shortcut icon", and one pointed to "/sites/all/themes/openshift-theme/favicon.ico", another pointed to "/app/assets/favicon32.png". "favicon.ico" will cover "favicon32.png" when browser rendering the page. You can zoom in the picture and will notice that "favicon.ico" is a little bigger than "favicon32.png".
Fix committed and merged
I tried on devenv_3439 and found that chrome/firefox is ok now but IE10/IE9 not display, and on stg community page display and console page not display for IE10.
STG is not updated with Steve's changes yet. Steve, can you look at IE9/10?
I'm waiting on a request from servicedesk for access to a VM to test IE IE9 should show https://github.com/openshift/li/blob/master/site/app/assets/images/favicon.ico IE10 should show /favicon.ico in our root directory. which one? https://github.com/openshift/li/blob/master/site/public/images/favicon.ico https://github.com/openshift/li/blob/master/site/public/favicon.ico
Addition fix committed devenv_3488 ...me crossing fingers
I tried on devenv_3514& STG(dev_stage_406), and found that STG work well for IE9/IE10, but devenv_3514 still can not display favicon.
Test on STG and devenv_3810, I find the favicon.ico on web console and community have the same md5sum. And they display well on firefox & chrome. But on devenv_3810, the favicon.ico are disappear on IE9 & IE10.
Created attachment 801475 [details] devenv_3810_IE10
Created attachment 801476 [details] devenv_3810_IE9
I don't know why a devenv would not show the favicon in IE. If QE can confirm it shows correctly in IE 9 & 10 on INT, STG, and production environments, I vote to mark this bug as fixed, unless there are any objections.
I agree with Steve. Things always perform weird on IE. Since favicon performs well on INT, STG and PROD, no need to dig out the reason why favicon is not correct on devenv. So verify this bug, thanks all!