RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 881729 - logsys: Race between logsys_format_set and log_printf_to_logs functions
Summary: logsys: Race between logsys_format_set and log_printf_to_logs functions
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: corosync
Version: 6.3
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: rc
: ---
Assignee: Jan Friesse
QA Contact: Cluster QE
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-11-29 13:13 UTC by Jan Friesse
Modified: 2013-11-21 04:32 UTC (History)
3 users (show)

Fixed In Version: corosync-1.4.1-16.el6
Doc Type: Bug Fix
Doc Text:
Cause: Corosync logging system is reconfigured Consequence: Corosync can crash (with extremely low probability) with NULL pointer access Fix: Add proper locking of formatting variable Result: Corosync don't crash
Clone Of:
Environment:
Last Closed: 2013-11-21 04:32:03 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Proposed patch (1.21 KB, patch)
2012-11-29 13:13 UTC, Jan Friesse
no flags Details | Diff
Proposed patch - part 2 - Avoid deadlock (986 bytes, patch)
2012-12-03 08:42 UTC, Jan Friesse
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2013:1531 0 normal SHIPPED_LIVE corosync bug fix and enhancement update 2013-11-21 00:40:57 UTC

Description Jan Friesse 2012-11-29 13:13:42 UTC
Created attachment 654285 [details]
Proposed patch

Description of problem:
When logsys_format_set is called, it can set format to NULL and if
logsys thread is actually reading it, corosync can segfault (NULL
pointer access).

Version-Release number of selected component (if applicable):
All

How reproducible:
0.00000000000001%

Steps to Reproduce:
1. Start corosync
2. Cause intensive logging of corosync (run cpgbench)
3. run corosync-objctl -w logging.fileline=on; corosync-objctl -w logging.fileline=off in cycle

or reliable with change in code:
- Add sleep in logsys_format_set function between lines

if (format_buffer) {
free(format_buffer);
format_buffer = NULL;

and

format_buffer = strdup(format ? format : "%p [%6s] %b");
if (format_buffer == NULL) {
ret = -1;

Actual results:
Corosync segfault

Expected results:
No segfault

Additional info:
For QA: Without change of code, I was unable to reproduce problem. Problem can be found by analysis of code. It was also reproduced by community (it's community patch). So it's worth to recommend bug as SanityOnly.

Comment 1 Jan Friesse 2012-12-03 08:42:08 UTC
Created attachment 656433 [details]
Proposed patch - part 2 - Avoid deadlock

Comment 11 errata-xmlrpc 2013-11-21 04:32:03 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2013-1531.html


Note You need to log in before you can comment on or make changes to this bug.