Note: This bug is displayed in read-only format because
the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Created attachment 654285[details]
Proposed patch
Description of problem:
When logsys_format_set is called, it can set format to NULL and if
logsys thread is actually reading it, corosync can segfault (NULL
pointer access).
Version-Release number of selected component (if applicable):
All
How reproducible:
0.00000000000001%
Steps to Reproduce:
1. Start corosync
2. Cause intensive logging of corosync (run cpgbench)
3. run corosync-objctl -w logging.fileline=on; corosync-objctl -w logging.fileline=off in cycle
or reliable with change in code:
- Add sleep in logsys_format_set function between lines
if (format_buffer) {
free(format_buffer);
format_buffer = NULL;
and
format_buffer = strdup(format ? format : "%p [%6s] %b");
if (format_buffer == NULL) {
ret = -1;
Actual results:
Corosync segfault
Expected results:
No segfault
Additional info:
For QA: Without change of code, I was unable to reproduce problem. Problem can be found by analysis of code. It was also reproduced by community (it's community patch). So it's worth to recommend bug as SanityOnly.
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.
http://rhn.redhat.com/errata/RHBA-2013-1531.html
Created attachment 654285 [details] Proposed patch Description of problem: When logsys_format_set is called, it can set format to NULL and if logsys thread is actually reading it, corosync can segfault (NULL pointer access). Version-Release number of selected component (if applicable): All How reproducible: 0.00000000000001% Steps to Reproduce: 1. Start corosync 2. Cause intensive logging of corosync (run cpgbench) 3. run corosync-objctl -w logging.fileline=on; corosync-objctl -w logging.fileline=off in cycle or reliable with change in code: - Add sleep in logsys_format_set function between lines if (format_buffer) { free(format_buffer); format_buffer = NULL; and format_buffer = strdup(format ? format : "%p [%6s] %b"); if (format_buffer == NULL) { ret = -1; Actual results: Corosync segfault Expected results: No segfault Additional info: For QA: Without change of code, I was unable to reproduce problem. Problem can be found by analysis of code. It was also reproduced by community (it's community patch). So it's worth to recommend bug as SanityOnly.