Spec URL: http://data-strzibny.rhcloud.com/rubygem-pdf-inspector.spec SRPM URL: http://data-strzibny.rhcloud.com/rubygem-pdf-inspector-1.0.2-1.fc17.src.rpm Description: This library provides a number of PDF::Reader[0] based tools for use in testing PDF output. Presently, the primary purpose of this tool is to support the tests found in Prawn[1], a pure Ruby PDF generation library. However, it may be useful to others, so we have made it available as a gem in its own right. [0] https://github.com/yob/pdf-reader [1] https://github.com/sandal/prawn Fedora Account System Username: jstribny Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4740723 Note: The gem doesn't come with a test suite, tested only using rpmlint, koji and mock --shell
I'll take this for a review.
- rpmlint gives me: "incorrect-fsf-address /usr/share/gems/gems/pdf-inspector-1.0.2/GPLv2", which means that the LICENSE file is probably older. Although this is not a showstopper, you should contact the upstream (or ideally send a pull request) to fix this. - Since this is a pure ruby Gem, it is not optimal to have runtime dependency on Ruby. When we have more Ruby interpreters (e.g. JRuby), this gem should also be usable with these. So please remove Requires: ruby, keeping only the runtime requirement on ruby(abi). - Please check the wordwrapping in description, it seems to be a little weird :) (word "testing" is on its own line, etc.)
Hi, I informed upstream and submitted a pull request [1], deleted the requirement of Ruby and fixed the bad word wrapping. Spec URL: http://data-strzibny.rhcloud.com/rubygem-pdf-inspector.spec SRPM URL: http://data-strzibny.rhcloud.com/rubygem-pdf-inspector-1.0.2-1.fc17.src.rpm [1] https://github.com/prawnpdf/pdf-inspector/pull/8
Great, the package looks good now. Only a minor issue: It is customary to bump the release if doing changes during review. So please bump the release and move the two changes you made from release 1 to release 2 before committing. APPROVED.
New Package SCM Request ======================= Package Name: rubygem-pdf-inspector Short Description: A tool for analyzing PDF output Owners: jstribny Branches: InitialCC:
Git done (by process-git-requests).