Red Hat Bugzilla – Bug 881989
[PATCH] for uint64 values on i386
Last modified: 2012-12-05 19:36:28 EST
Created attachment 654641 [details]
patch for using buildvalud("K") instead of buildvalue("l") for lvm sizes
Description of problem:
LVM sizes are in uint64_t, python-lvm currently specifies "l" which is (long) ... this is very bad on i386 due to buildvalue being varargs. Patch attached and at:
...added helper function, due to the needed cast.
Also the F17 python-lvm just segfaults, and I have to hack patch out lvm_config_find_bool to make the F18 python-lvm work on F17 ... so would it be possible to release an official rebased python-lvm on F17?
I'd be slightly happier with the casts in all the callsites rather than the helper function, I think. Any objections?
Regarding F17, sorry about that. I'll get on it.
BTW please note that python-lvm is now part of lvm2 proper, so the separate src pkg will be going away.
Created attachment 655083 [details]
New version of buildvalue patch without the helper
No problem, here is a new version of the patch without the helper.
Applied to lvm2 and python-lvm repos. Thanks again!