Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-Pimple.spec SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-Pimple-1.0.0-1.fc17.src.rpm Description: Pimple is a small Dependency Injection Container for PHP 5.3 that consists of just one file and one class. Fedora Account System Username: siwinski
Created attachment 655441 [details] php-Pimple-review.txt Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16 Buildroot used: fedora-17-x86_64 Command line :/usr/bin/fedora-review -b 882418
Tips: you could simply use (in bootstrap.php) require_once 'Pimple/Pimple.php'; On so, rely on standard php include_path. During the check, you can override this value (to avoid another sed) phpunit -d include_path=%{buildroot}%{_datadir}/php:.:%{pear_phpdir} ... Please consider removing "5.3" from Summary and %description. This seems really "restrictive", and it works perfectly with PHP 5.5.0. I don't see any blockers, === APPROVED ====
Thanks for the review and the tips! New Package SCM Request ======================= Package Name: php-Pimple Short Description: A simple Dependency Injection Container for PHP Owners: siwinski Branches: f17 f18 el6 InitialCC:
Git done (by process-git-requests).
php-Pimple-1.0.0-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-Pimple-1.0.0-2.fc18
php-Pimple-1.0.0-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-Pimple-1.0.0-2.el6
php-Pimple-1.0.0-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/php-Pimple-1.0.0-2.fc17
php-Pimple-1.0.0-2.fc17 has been pushed to the Fedora 17 testing repository.
php-Pimple-1.0.0-2.fc18 has been pushed to the Fedora 18 stable repository.
php-Pimple-1.0.0-2.fc17 has been pushed to the Fedora 17 stable repository.
php-Pimple-1.0.0-2.el6 has been pushed to the Fedora EPEL 6 stable repository.