Bug 883001 - Review Request: shim-signed - shim bootloader signed by UEFI signing service
Summary: Review Request: shim-signed - shim bootloader signed by UEFI signing service
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Matthew Garrett
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-12-03 15:35 UTC by Peter Jones
Modified: 2016-08-14 15:55 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2016-08-14 15:55:38 UTC
Type: ---
Embargoed:
mjg59: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Peter Jones 2012-12-03 15:35:57 UTC
Spec URL: http://pjones.fedorapeople.org/shim-signed/shim-signed.spec
SRPM URL: http://pjones.fedorapeople.org/shim-signed/shim-signed-0.2-2.fc18.src.rpm
Description: shim bootloader signed by UEFI signing service
Fedora Account System Username: pjones

Comment 1 Matthew Garrett 2012-12-03 16:07:41 UTC
rpmlint output:

shim-signed.src: W: spelling-error Summary(en_US) bootloader -> boot loader, boot-loader, boatload
shim-signed.src: W: spelling-error %description -l en_US bootloader -> boot loader, boot-loader, boatload
shim-signed.src:5: W: macro-in-comment %{version}
shim-signed.src:5: W: macro-in-comment %{release}
shim-signed.src:5: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 5)
shim-signed.spec:5: W: macro-in-comment %{version}
shim-signed.spec:5: W: macro-in-comment %{release}
shim-signed.spec:5: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 5)

Probably ought to declare %global debug_package %{nil} . Other than that, everything looks good.

Comment 2 Peter Jones 2012-12-03 18:32:20 UTC
Okay, I've made that change.  With that in mind:

New Package SCM Request
=======================
Package Name: shim-signed
Short Description: UEFI shim bootloader signed by the UEFI signing service.
Owners: pjones
Branches: f18
InitialCC: mjg59

Comment 3 Kevin Fenzi 2012-12-03 18:45:00 UTC
I rather think we may need some kind of exception to: 

http://fedoraproject.org/wiki/Packaging:Guidelines#No_inclusion_of_pre-built_binaries_or_libraries

here. The binary is included as a source no?

Comment 4 Matthew Garrett 2012-12-03 18:47:25 UTC
The binary is built from the source code that's included in the package that this depends on, so I don't think the reasoning applies here.

Comment 5 Matthew Garrett 2012-12-03 18:49:14 UTC
The alternative is that we simply classify it as binary firmware - it meets all the listed criteria.

Comment 6 Gwyn Ciesla 2012-12-03 18:52:03 UTC
"mjg59" is not a valid FAS account.

Comment 7 Peter Jones 2012-12-03 18:54:23 UTC
My mistake: should be mjg59.org

Comment 8 Gwyn Ciesla 2012-12-03 19:05:32 UTC
Clarification, use a FAS account, not an email address.

Comment 9 Peter Jones 2012-12-03 19:07:45 UTC
(the fas account is "mjg59")

Comment 10 Gwyn Ciesla 2012-12-03 19:09:51 UTC
Git done (by process-git-requests).

Comment 11 Kevin Fenzi 2012-12-03 19:32:14 UTC
(In reply to comment #5)
> The alternative is that we simply classify it as binary firmware - it meets
> all the listed criteria.

Indeed it seems to. ;) Handy. Sounds reasonable to me...


Note You need to log in before you can comment on or make changes to this bug.