Bug 883490 - Libdvdread possible miscompilation
Summary: Libdvdread possible miscompilation
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: libdvdread
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
Assignee: Dominik 'Rathann' Mierzejewski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-12-04 17:35 UTC by Frantisek Kluknavsky
Modified: 2015-02-23 23:27 UTC (History)
5 users (show)

Fixed In Version: libdvdnav-5.0.3-1.fc20
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-02-16 03:26:01 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Frantisek Kluknavsky 2012-12-04 17:35:31 UTC
Description of problem:
Dereferencing type-casted pointer (in md5.c and nav_print.c) combined with gcc -O2 optimization is dangerous. 

Version-Release number of selected component (if applicable):
4.2.0-3

How reproducible:
Difficult to reproduce, compiler and platform specific errors. Easy to detect on any platform by examining compiler warnings.

Steps to Reproduce:
1. Rebuild package
2. Inspect build.log
3.
  
Actual results:
/builddir/build/BUILD/libdvdread-4.2.0/src/md5.c:107:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]

Expected results:
No warnings, safe code.

Additional info:
Solution: Add -fno-strict-aliasing to cflags in spec file _after_ -O2.

- --extra-cflags="%{optflags}" \
+ --extra-cflags="%{optflags} -fno-strict-aliasing" \

Comment 1 Fedora End Of Life 2013-12-21 09:38:10 UTC
This message is a reminder that Fedora 18 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 18. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '18'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 18's end of life.

Thank you for reporting this issue and we are sorry that we may not be 
able to fix it before Fedora 18 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior to Fedora 18's end of life.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 2 Fedora End Of Life 2014-02-05 13:33:30 UTC
Fedora 18 changed to end-of-life (EOL) status on 2014-01-14. Fedora 18 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 3 Dominik 'Rathann' Mierzejewski 2014-02-11 23:37:16 UTC
This is not fixed yet.

Comment 4 Fedora Update System 2015-02-07 16:30:02 UTC
libdvdread-5.0.2-1.fc21, libdvdnav-5.0.3-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/libdvdread-5.0.2-1.fc21,libdvdnav-5.0.3-1.fc21

Comment 5 Fedora Update System 2015-02-07 16:31:52 UTC
libdvdnav-5.0.3-1.fc20, libdvdread-5.0.2-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/libdvdread-5.0.2-1.fc20,libdvdnav-5.0.3-1.fc20

Comment 6 Fedora Update System 2015-02-08 08:56:44 UTC
Package libdvdnav-5.0.3-1.fc20, libdvdread-5.0.2-1.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing libdvdnav-5.0.3-1.fc20 libdvdread-5.0.2-1.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-1846/libdvdread-5.0.2-1.fc20,libdvdnav-5.0.3-1.fc20
then log in and leave karma (feedback).

Comment 7 Fedora Update System 2015-02-16 03:26:01 UTC
libdvdread-5.0.2-1.fc21, libdvdnav-5.0.3-1.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2015-02-23 23:27:09 UTC
libdvdnav-5.0.3-1.fc20, libdvdread-5.0.2-1.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.