Spec URL: https://github.com/F1ash/plasmaVolume/blob/master/kde-plasma-alsa-volume.spec SRPM URL: http://kojipkgs.fedoraproject.org//work/tasks/3303/4763303/kde-plasma-alsa-volume-0.41.2-1.fc18.src.rpm Description: kde-plasma-alsa-volume ALSA Volume Control plasmoid Fedora Account System Username: f1ash Addition: succesful build http://koji.fedoraproject.org/koji/taskinfo?taskID=4763303
Uhm, you do know that KMix has an ALSA mode, too (KMIX_PULSEAUDIO_DISABLE=1)?
(In reply to comment #1) > Uhm, you do know that KMix has an ALSA mode, too (KMIX_PULSEAUDIO_DISABLE=1)? but this plasmoid is more convenient, because it allows each device to reflect on the panel (or workspace) for control. ( http://kde-look.org/content/show.php/ALSA+Volume+Control+plasmoid?content=138990 )
new successfull build : http://koji.fedoraproject.org/koji/taskinfo?taskID=4772537
The SRPM gives HTTP 404 Not Found.
Sorry, fresh build :) http://kojipkgs.fedoraproject.org//work/tasks/19/4860019/kde-plasma-alsa-volume-0.41.2-1.fc17.src.rpm
Some initial issues: Please provide a more informative description, if possible. Repeating the package name doesn't make much sense. You should know what to do because you are the upstream author ;) The source tarball is not downloadable: $ wget http://cloud.github.com/downloads/F1ash/plasmaVolume/kde-plasma-alsa-volume-0.41.2.tar.bz2 --2013-01-13 20:37:09-- http://cloud.github.com/downloads/F1ash/plasmaVolume/kde-plasma-alsa-volume-0.41.2.tar.bz2 Auflösen des Hostnamen »cloud.github.com (cloud.github.com)«... 54.240.162.142, 54.240.162.98, 54.240.162.18, ... Verbindungsaufbau zu cloud.github.com (cloud.github.com)|54.240.162.142|:80... verbunden. HTTP-Anforderung gesendet, warte auf Antwort... 403 Forbidden 2013-01-13 20:37:10 FEHLER 403: Forbidden.
(In reply to comment #6) > Some initial issues: > > Please provide a more informative description, if possible. Repeating the > package name doesn't make much sense. You should know what to do because you > are the upstream author ;) > > The source tarball is not downloadable: > ... Fixed both: https://raw.github.com/F1ash/plasmaVolume/master/kde-plasma-alsa-volume.spec
Changed git-repo name: https://github.com/F1ash/kde-plasma-alsa-volume SPEC: https://raw.github.com/F1ash/kde-plasma-alsa-volume/master/kde-plasma-alsa-volume.spec
fresh build: http://kojipkgs.fedoraproject.org//work/tasks/9498/4939498/kde-plasma-alsa-volume-0.41.2-1.fc18.src.rpm
naming: ok sources: NOT ok. md5sum checksum in SRPM: 5c5167a012f43ccd0204fe600ef32095 kde-plasma-alsa-volume-0.41.2.tar.gz md5sum of Source0 URL content: 146e0b1dae8ef5cfaa47b5fd75b93bdb kde-plasma-alsa-volume-0.41.2.tar.gz 1. srpm MUST contain verifiable sources license: ok 2. MUST: add missing runtime dependency for plasma-scriptengine-python. i'd suggest simply adding this to the top of your %build section: if [ -x %{_bindir}/plasma-dataengine-depextractor ] ; then plasma-dataengine-depextractor . fi then, it'll get added automatically for you. Doing this, you could probably even drop the explicit, Requires: PyKDE4 macros: ok scriplets: n/a, ok 3. SHOULD simplify .spec and remove deprecated/used "Group:" tag Otherwise, relatively small, simple package. Address at least MUST items 1,2 and i'll approve this.
Dependencies on script engines are actually detected automatically (the required metadata for those is already in the upstream metadata.desktop), but it needs a BuildRequires of (at least) kde-settings, which is missing in your package. If you're going to run the plasma-dataengine-depextractor (which you should, really, because you don't know what data engines upstream will start using in the future, though currently I can't see any being used in the code), you need BuildRequires: kdelibs4-devel, which will also drag in kde-settings.
OK, augment my suggestion for 2 with Kevin's, and add: BuildRequires: kdelibs4-devel as well.
Fixes: SPEC: https://raw.github.com/F1ash/kde-plasma-alsa-volume/master/kde-plasma-alsa-volume.spec SRPM: http://kojipkgs.fedoraproject.org//work/tasks/6662/4946662/kde-plasma-alsa-volume-0.41.2-1.fc18.src.rpm
If using plasma-dataengine-depextractor approach, you need to BuildRequires: kdelibs4-devel
Fixed: SPEC: https://raw.github.com/F1ash/kde-plasma-alsa-volume/master/kde-plasma-alsa-volume.spec SRPM: http://kojipkgs.fedoraproject.org//work/tasks/9404/4949404/kde-plasma-alsa-volume-0.41.2-1.fc18.src.rpm
fyi, for future reference, it is best practice to bump Release: and add new %changelog entries when making changes (esp those in a package review), so it's easier to track what has changed. thanks. sources: ok now b8709502c561d8fc5ab6aaccccda3e02 0.41.2.tar.gz Looks good, APPROVED.
Thanks!
New Package SCM Request ======================= Package Name: kde-plasma-alsa-volume Short Description: ALSA Volume Control plasmoid Owners: f1ash Branches: f17 f18 InitialCC:
Git done (by process-git-requests).
kde-plasma-alsa-volume-0.41.2-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/kde-plasma-alsa-volume-0.41.2-1.fc18
kde-plasma-alsa-volume-0.41.2-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/kde-plasma-alsa-volume-0.41.2-1.fc17
kde-plasma-alsa-volume-0.41.2-1.fc17 has been pushed to the Fedora 17 testing repository.
kde-plasma-alsa-volume-0.41.2-1.fc18 has been pushed to the Fedora 18 stable repository.
kde-plasma-alsa-volume-0.41.2-1.fc17 has been pushed to the Fedora 17 stable repository.
New Package SCM Request ======================= Package Name: kde-plasma-alsa-volume Short Description: ALSA Volume Control plasmoid Owners: f1ash Branches: f19 InitialCC:
Already exists.