Bug 885316 - Ark needs to know about application/x-source-rpm
Summary: Ark needs to know about application/x-source-rpm
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: ark
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-12-08 15:29 UTC by Sandro Mani
Modified: 2013-01-05 19:34 UTC (History)
6 users (show)

Fixed In Version: ark-4.9.97-2
Clone Of:
Environment:
Last Closed: 2013-01-05 19:34:14 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Patch (1.20 KB, patch)
2012-12-08 15:29 UTC, Sandro Mani
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
KDE Software Compilation 311349 0 None None None Never

Description Sandro Mani 2012-12-08 15:29:42 UTC
Created attachment 659859 [details]
Patch

Description of problem:
Something changed in the mime-type database lately, and ark won't recognize src.rpm files anymore. Ark only looks for application/x-rpm but src.rpm files now are application/x-source-rpm. The attached patch adds the corresponding MIME type to ark.

Version-Release number of selected component (if applicable):
ark-4.9.90-1.fc19.x86_64
(though I guess this applies to any ark in currently maintained fedora releases)

How reproducible:
Always

Steps to Reproduce:
1. Attempt to open a src.rpm with ark
2. Ark will tell you "Ark was unable to determine the archive type of the filename"

Comment 1 Sandro Mani 2013-01-05 00:58:11 UTC
Any chance of having this patch included? Sorta annoying having to rebuild ark every time ;)

Btw, I've also posted the patch upstream on kde reviewboard [1] (along with a two other simple ark patches [2], [3]), but things seem rather silent concerning kdeutils. Anyone with commit rights here?

[1] https://git.reviewboard.kde.org/r/108187/
[2] https://git.reviewboard.kde.org/r/107634/
[3] https://git.reviewboard.kde.org/r/107635/

Comment 2 Rex Dieter 2013-01-05 17:45:00 UTC
Thanks for the reminder, I'll review these and help get them integrated

Comment 3 Rex Dieter 2013-01-05 17:50:09 UTC
Fwiw, items 1 and 3 seem fairly safe and obvious fixes, i'll commit those asap.

2 should get a little more review and testing, which hopefully i can do soon too.

Comment 4 Rex Dieter 2013-01-05 19:34:14 UTC
%changelog
* Sat Jan 05 2013 Rex Dieter <rdieter> - 4.9.97-2
- Ark needs to know about application/x-source-rpm (#885316)
- Improve subfolder autodetection (kde review 107634)
- Don't delete the KPart in the MainWindow destructor (kde review 107635)


Note You need to log in before you can comment on or make changes to this bug.