Description of problem: You can change and save configuration of Tomcat web application without filling Text field "Config File" (required field). I think Config File text field should not be required. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
This attribute is among the attributes I identified as problematic if required. Another issue for this particular one is that there's a type conflict between Tomcat 6 and 7 (a String became a URL).
There appear to be two issues here: 1) "You can change and save configuration of Tomcat web application without filling Text field "Config File" (required field). " This sounds like we allow people to leave required fields blank. If this is is the case then we need to fix that in core JON 2) "I think Config File text field should not be required." Making a field not required is done by the updating the rhq-plugin which is done by the EWS team.
" Another issue for this particular one is that there's a type conflict between Tomcat 6 and 7 (a String became a URL)." Remy please raise a new EWS issue if this is a problem
(In reply to comment #4) Assigning to 3.2 so that we can see if 1) is actually a problem in core JON
Fixed in master commit 2f15379bb357495c558b05fb271e247fa1681d01 Author: Thomas Segismont <tsegismo> Date: Tue May 28 17:36:13 2013 +0200 Bug 885686 - Tomcat web application configuration form allows save without Config File required field It's not a Tomcat specific issue. We had a problem in *EditView classes: the check to enable/disable the save button was only based on the invalid properties set having been changed. Now it also looks at the set being empty or not.
(In reply to Charles Crouch from comment #5) > " Another issue for this particular one is that there's a type conflict > between Tomcat 6 and 7 (a String became a URL)." > > Remy please raise a new EWS issue if this is a problem The "required" attribute has been set to false in this commit: commit 417fbb59817edf64a93d3cca00f2c51926379ab2 Author: Rémy Maucherat <rmaucher> Date: Tue Mar 26 14:51:55 2013 +0100 Fix some roles operations. Fix some attributes (not valid across all versions).
This bz is available for testing with the latest 3.2.x brew build: https://brewweb.devel.redhat.com//buildinfo?buildID=280316
JON EWS Tomcat plugin 3.2.0 with EWS 2.0.1 T6/T7 did not discovered child resources after proper configuration jmx connection and proper principal/credentials on RHEL6. So i can't test configuration of Tomcat web application. Note: Tomcat plugin was updated during EWS 2.0.1 release. See customer portal. This updated and fixed JON EWS Tomcat plugin functionality should be included in JON 3.2.0 release. Please update Tomcat plugin with 3.2.0. Jean-Frederic can provide more info about tomcat plugin update.
As reported, there are changes made to the JON 3.1.x stream that have not been merged/ported back to master. This needs to be done before QA will be able to test in a new 3.2.x build. i)Assigning to myself to merge those changes to master ii)after which the status will be moved to MODIFIED for testing in a later 3.2.x build. iii)Will reassign back to thomas.
These are merged into master with commits: 0ac6f0c f625bff f04c9ef a978c9b 0aec2ec 07dd8cd 4db8471
Moving this to ON_QA as this is available for test in ER1.
Text field "Config File" is no longer required in 3.2.0.ER1