Bug 886184 - cmake should be patched to look for ninja-build as the ninjaCmd
Summary: cmake should be patched to look for ninja-build as the ninjaCmd
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: cmake
Version: rawhide
Hardware: All
OS: Linux
unspecified
low
Target Milestone: ---
Assignee: Orion Poplawski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-12-11 17:49 UTC by Edward Rudd
Modified: 2013-05-05 02:26 UTC (History)
7 users (show)

Fixed In Version: cmake-2.8.10.2-4.fc19
Clone Of:
Environment:
Last Closed: 2013-02-08 16:36:43 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Edward Rudd 2012-12-11 17:49:52 UTC
Description of problem:
When using the ninja generator in cmake 2.8.8+ cmake looks for "ninja", which the ninja-build package for fedora 16+ uses the binary ninja-build so as to not conflict with the ninja irc client.

Version-Release number of selected component (if applicable):
cmake-2.8.8-4.fc16 - cmake-2.8.10.2-1.fc18

How reproducible:
everytime

Steps to Reproduce:
1. in a project source dir w/ CMakeLists.txt
2. cmake -G Ninja .
  
Actual results:

Couldn't find ninja

Expected results:

it to "know to use" ninja-build

Additional info:

A workaround is to pass -DCMAKE_MAKE_PROGRAM=ninja-build

The patch would be to modify Source/cmGlobalNinjaGenerator.cxx around line 1037 (ninjaCmd() method).  and change the return from

return "ninja";

to 

return "ninja-build";

Comment 1 Orion Poplawski 2013-02-08 16:36:43 UTC
Should be fixed with cmake-2.8.10.2-4.fc19.

Comment 2 Fedora Update System 2013-04-24 23:15:40 UTC
cmake-2.8.10.2-5.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/cmake-2.8.10.2-5.fc18

Comment 3 Fedora Update System 2013-05-05 02:26:52 UTC
cmake-2.8.10.2-5.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.