Bug 886192 - Review Request: perl-Module-Package-Au - Reusable Module::Install bits
Summary: Review Request: perl-Module-Package-Au - Reusable Module::Install bits
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 874743
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-12-11 18:20 UTC by Tom "spot" Callaway
Modified: 2014-09-09 22:26 UTC (History)
3 users (show)

Fixed In Version: perl-Module-Package-Au-2-1.fc20
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-09-09 22:08:47 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Tom "spot" Callaway 2012-12-11 18:20:19 UTC
Spec URL: http://spot.fedorapeople.org/perl-Module-Package-Au.spec
SRPM URL: http://spot.fedorapeople.org/perl-Module-Package-Au-0.01-1.fc18.src.rpm
Description: This module defines a set of standard configurations for Makefile.PL
files based on Module::Package.
Fedora Account System Username: spot

Comment 1 Tom "spot" Callaway 2012-12-11 18:23:52 UTC
Ugh, wrong SRPM. Proper SRPM URL is:

SRPM URL: http://spot.fedorapeople.org/perl-Module-Package-Au-2-1.fc18.src.rpm

Comment 2 Jitka Plesnikova 2012-12-12 12:13:05 UTC
Package Review
==============

Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[-]: Package uses nothing in %doc for runtime.
[-]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Package complies to the Packaging Guidelines
[-]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
[x]: Package consistently uses macro is (instead of hard-coded directory
     names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package is not relocatable.
[x]: Requires correct, justified where necessary.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[-]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[-]: Large documentation must go in a -doc subpackage.
     Note: Documentation size is 10240 bytes in 2 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Perl:
[x]: Package contains the mandatory BuildRequires and Requires:.
[x]: CPAN urls should be non-versioned.

===== SHOULD items =====

Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Final provides and requires are sane (rpm -q --provides and rpm -q
     --requires).
[-]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[-]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Spec use %global instead of %define.

===== EXTRA items =====

Generic:
[x]: Spec file according to URL is the same as in SRPM.
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.

$ rpmlint ./perl-Module-Package-Au.spec ./perl-Module-Package-Au-2-1.fc19.*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok.
$ rpm -qp --provides perl-Module-Package-Au-2-1.fc19.noarch.rpm | sort | uniq -c
      1 perl(Module::Package::Au)
      1 perl(Module::Package::Au::dry)
      1 perl-Module-Package-Au = 2-1.fc19
Binary provides are ok.

$ rpm -qp --requires perl-Module-Package-Au-2-1.fc19.noarch.rpm | sort | uniq -c
      1 perl >= 0:5.008003
      1 perl(:MODULE_COMPAT_5.16.2)
      1 perl(Module::Install::GithubMeta) >= 0.10
      1 perl(Module::Install::ReadmeFromPod) >= 0.12
      1 perl(Module::Install::ReadmeMarkdownFromPod) >= 0.03
      1 perl(Module::Package) >= 0.24
      1 perl(Module::Package::Plugin)
      1 perl(Pod::Markdown) >= 1.301
      1 perl(base)
      1 perl(strict)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are ok.

MD5-sum check
-------------
http://search.cpan.org/CPAN/authors/id/A/AU/AUDREYT/Module-Package-Au-0.01.tar.gz :
  CHECKSUM(SHA256) this package     : fce689be4644fb11b4758de957731115ae7a8a8cc218111f62246df6432b25ce
  CHECKSUM(SHA256) upstream package : fce689be4644fb11b4758de957731115ae7a8a8cc218111f62246df6432b25ce


TODO: Remove BR perl(Test). I did not find any requirement of it.

Please consider fixing 'TODO' item.

Package APPROVED.

Comment 3 Jitka Plesnikova 2014-07-03 08:45:24 UTC
Do you still wanr to add the package to Fedora?

Btw. there is a newer release of the module.

Comment 4 Tom "spot" Callaway 2014-07-08 18:54:27 UTC
New Package SCM Request
=======================
Package Name: perl-Module-Package-Au
Short Description: Reusable Module::Install bits
Upstream URL: http://search.cpan.org/dist/Module-Package-Au/
Owners: spot
Branches: f19 f20 el6 el7
InitialCC: perl-sig

Comment 5 Gwyn Ciesla 2014-07-08 20:05:06 UTC
Git done (by process-git-requests).

Comment 6 Jitka Plesnikova 2014-07-09 08:50:23 UTC
The branch f21 is missing.

https://admin.fedoraproject.org/pkgdb/package/perl-Module-Package-Au/

Comment 7 Tom "spot" Callaway 2014-07-09 13:32:40 UTC
Package Change Request
======================
Package Name: perl-Module-Package-Au
New Branches: f21
Owners: spot
InitialCC: perl-sig

Comment 8 Fedora Update System 2014-07-09 13:37:01 UTC
perl-Module-Package-Au-2-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/perl-Module-Package-Au-2-1.fc20

Comment 9 Fedora Update System 2014-07-09 13:37:08 UTC
perl-Module-Package-Au-2-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/perl-Module-Package-Au-2-1.fc19

Comment 10 Gwyn Ciesla 2014-07-09 14:03:49 UTC
Git done (by process-git-requests).

Comment 11 Fedora Update System 2014-07-10 00:23:23 UTC
perl-Module-Package-Au-2-1.fc20 has been pushed to the Fedora 20 testing repository.

Comment 12 Fedora Update System 2014-09-09 22:08:47 UTC
perl-Module-Package-Au-2-1.fc19 has been pushed to the Fedora 19 stable repository.

Comment 13 Fedora Update System 2014-09-09 22:26:12 UTC
perl-Module-Package-Au-2-1.fc20 has been pushed to the Fedora 20 stable repository.


Note You need to log in before you can comment on or make changes to this bug.