Bug 886364 (CVE-2012-5635) - CVE-2012-5635 GlusterFS: insecure temporary file creation
Summary: CVE-2012-5635 GlusterFS: insecure temporary file creation
Keywords:
Status: CLOSED ERRATA
Alias: CVE-2012-5635
Product: Security Response
Classification: Other
Component: vulnerability
Version: unspecified
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Red Hat Product Security
QA Contact:
URL:
Whiteboard:
: 894870 894871 894872 (view as bug list)
Depends On: 886365
Blocks: 886367
TreeView+ depends on / blocked
 
Reported: 2012-12-12 06:35 UTC by Kurt Seifried
Modified: 2023-05-12 19:00 UTC (History)
9 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2013-08-22 02:51:42 UTC
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2013:0691 0 normal SHIPPED_LIVE Important: Red Hat Storage 2.0 security, bug fix, and enhancement update #4 2013-03-29 02:21:19 UTC

Description Kurt Seifried 2012-12-12 06:35:11 UTC
Following the fixing of several /tmp/ flaws in CVE-2012-4417 we have the 
remaining issues in Gluster reported by Kurt Seifried (kseifried):

==============
This issue was previously not reported:
This should probably use /var/run/gluster/glusterdump.%d.options

tests/volume.rc:        rm -f /tmp/glusterdump.$mount_pid.dump.* 2>/dev/null
tests/volume.rc:        fname=$(ls /tmp | grep -E "glusterdump.$mount_pid.dump.*")
tests/volume.rc:        echo /tmp/$fname
==============
 
==============
This issue was previously not reported:
This should use mktemp
Also this should use cp instead of mv so you don't lose SELinux context when 
copying the file back to /etc/samba/smb.conf which might break Samba

extras/hook-scripts/S30samba-stop.sh:        cp /etc/samba/smb.conf /tmp/smb.conf
extras/hook-scripts/S30samba-stop.sh:        sed -i "/gluster-$volname/,/^$/d" /tmp/smb.conf &&\
extras/hook-scripts/S30samba-stop.sh:                mv /tmp/smb.conf /etc/samba/smb.conf
==============

==============
This issue was previously reported:
This should use mkstemp()

libglusterfs/src/run.c:        fd = open ("/tmp/foof", O_WRONLY|O_CREAT|O_TRUNC, 0600);
==============

==============
This issue was previously reported:
This should probably use /var/run/gluster/glusterdump.%d.options

libglusterfs/src/statedump.c:/* These options are dumped by default if /tmp/glusterdump.options
libglusterfs/src/statedump.c:        /* glusterd will create a file /tmp/glusterdump.<pid>.options and
libglusterfs/src/statedump.c:           both cli command and SIGUSR1, /tmp/glusterdump.options file
libglusterfs/src/statedump.c:                  "/tmp/glusterdump.options");
libglusterfs/src/statedump.c:                          "/tmp/glusterdump.%d.options", getpid ());
libglusterfs/src/statedump.c:                   ((ctx->statedump_path != NULL)?ctx->statedump_path:"/tmp")),
==============

==============
This issue was previously reported:
This should probably use /var/run/gluster/glusterdump.%d.options

xlators/protocol/server/src/server.c:          .default_value = "/tmp",
xlators/protocol/server/src/server.c:                         " statedumps. By default it is the /tmp directory"
==============
 
==============
This issue was previously reported:
This should probably use /var/run/gluster/%s-"RB_CLIENT_MOUNTPOINT

xlators/mgmt/glusterd/src/glusterd-replace-brick.c:        snprintf (path, len, "/tmp/%s-"RB_CLIENT_MOUNTPOINT, volinfo->volname);
==============

 
==============
This issue was previously reported:
This should probably use /var/run/gluster/glusterdump.%d.options

xlators/mgmt/glusterd/src/glusterd-utils.c:                  snprintf (dumpoptions_path, sizeof (dumpoptions_path), "/tmp/glusterdump.%d.options", pid);
xlators/mgmt/glusterd/src/glusterd-utils.c:                  snprintf (dumpoptions_path, sizeof (dumpoptions_path), "/tmp/glusterdump.%d.options", pid);
==============

Comment 1 Kurt Seifried 2013-01-31 05:02:50 UTC
*** Bug 894870 has been marked as a duplicate of this bug. ***

Comment 2 Kurt Seifried 2013-01-31 05:03:18 UTC
*** Bug 894871 has been marked as a duplicate of this bug. ***

Comment 3 Kurt Seifried 2013-01-31 05:04:07 UTC
*** Bug 894872 has been marked as a duplicate of this bug. ***

Comment 4 Murray McAllister 2013-02-14 03:45:28 UTC
Acknowledgements:

These issues were discovered by Kurt Seifried of the Red Hat Security Response Team and Michael Scherer of the Red Hat Regional IT team.

Comment 6 errata-xmlrpc 2013-03-28 22:28:05 UTC
This issue has been addressed in following products:

  Red Hat Storage 2.0
  Red Hat Storage 2.0 Console
  Native Client for RHEL 5 for Red Hat Storage
  Native Client for RHEL 6 for Red Hat Storage

Via RHSA-2013:0691 https://rhn.redhat.com/errata/RHSA-2013-0691.html


Note You need to log in before you can comment on or make changes to this bug.