Bug 886552 - Review Request: python-stevedore - Manage dynamic plugins for Python applications
Summary: Review Request: python-stevedore - Manage dynamic plugins for Python applicat...
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Pádraig Brady
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: 956429
TreeView+ depends on / blocked
Reported: 2012-12-12 14:30 UTC by Pádraig Brady
Modified: 2016-01-04 14:41 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2013-01-11 12:47:08 UTC
Type: ---
p: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Pádraig Brady 2012-12-12 14:30:56 UTC
Spec URL: http://fedorapeople.org/~pbrady/python-stevedore.spec
SRPM URL: http://fedorapeople.org/~pbrady/python-stevedore-0.7.2-1.fc15.src.rpm
Description: Manage dynamic plugins for Python applications
Fedora Account System Username: dprince

Comment 1 Pádraig Brady 2012-12-12 14:36:08 UTC
Checking: python-stevedore-0.7.2-1.fc15.noarch.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

[x]: EXTRA Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: EXTRA Spec file according to URL is the same as in SRPM.
[x]: MUST Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: MUST Package successfully compiles and builds into binary rpms on at
     least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
     Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[-]: MUST Package contains desktop file if it is a GUI application.
[-]: MUST Development files must be in a -devel package
[-]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Package complies to the Packaging Guidelines
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf would be needed if support for EPEL5 is required
[-]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. No licenses
     found. Please check the source files for licenses manually.
[x]: MUST Package consistently uses macro is (instead of hard-coded directory
[x]: MUST Package is named using only allowed ascii characters.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
     Note: Package contains no Conflicts: tag(s)
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[-]: MUST If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Package is not relocatable.
[x]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: MUST Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
[-]: MUST Package contains systemd file(s) if in need.
[x]: MUST File names are valid UTF-8.
[x]: SHOULD Reviewer should test that the package builds in mock.
[x]: SHOULD Buildroot is not present
     Note: Unless packager wants to package for EPEL5 this is fine
[x]: SHOULD Package has no %clean section with rm -rf %{buildroot} (or
     Note: Clean would be needed if support for EPEL5 is required
[-]: SHOULD If the source package does not include license text(s) as a
     separate file from upstream, the packager SHOULD query upstream to
     include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
[x]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[x]: SHOULD Package does not include license text files separate from
[x]: SHOULD SourceX tarball generation or download is documented.
[x]: SHOULD SourceX / PatchY prefixed with %{name}.
     Note: Source0 (stevedore-0.7.2.tar.gz)
[x]: SHOULD SourceX is a working URL.
[x]: SHOULD Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[-]: SHOULD Package should compile and build into binary rpms on all supported
[-]: SHOULD %check is present and all tests pass.
[x]: SHOULD Packages should try to preserve timestamps of original installed
[x]: SHOULD Spec use %global instead of %define.

Comment 2 Pádraig Brady 2012-12-12 14:38:02 UTC
New Package SCM Request
Package Name: python-stevedore
Short Description: Manage dynamic plugins for Python applications
Owners: dprince pbrady
Branches: f17 f18 el6

Comment 3 Gwyn Ciesla 2012-12-12 15:08:56 UTC
You can't review your own package.

Comment 4 Pádraig Brady 2012-12-12 15:49:35 UTC
It's actually dprince's package as indicated in the "Fedora Account System Username:" field above. I just submitted it for him.

Comment 5 Dan Prince 2012-12-12 16:13:38 UTC
Thanks for posting this for me Pádraig. I can confirm this is my package and that it is works. This is now a requirement for upstream OpenStack Nova (Grizzly)

Comment 6 Pádraig Brady 2012-12-12 16:18:19 UTC
Readding "cvs ?"
Sorry for not following process exacctly.
Please indicate if you'd like to close this and start with a new bug.

Comment 7 Gwyn Ciesla 2012-12-12 16:26:29 UTC
dprince needs to be in the packager group first.

Comment 8 Pádraig Brady 2013-01-07 13:59:44 UTC
Dan, I notice that your email is missing from the changelog.
Also stevedore-0.8 is now available.
Can you post a new spec and srpm please.
I'll get mrunge to sponsor you to the packager group.

Comment 9 Matthias Runge 2013-01-07 16:12:57 UTC
Dan, I've just sponsor you into packager group.

New Package SCM Request
Package Name: python-stevedore
Short Description: Manage dynamic plugins for Python applications
Owners: dprince pbrady
Branches: f17 f18 el6
InitialCC: mrunge

Comment 10 Matthias Runge 2013-01-07 16:19:37 UTC
Padraig, please assign yourself to the review

Comment 11 Gwyn Ciesla 2013-01-07 16:26:50 UTC
Git done (by process-git-requests).

Comment 12 Pádraig Brady 2013-01-11 12:47:08 UTC
python-stevedore-0.8 now in rawhide

Comment 13 Fedora Update System 2013-01-11 14:18:40 UTC
python-stevedore-0.8-1.fc17 has been submitted as an update for Fedora 17.

Comment 14 Fedora Update System 2013-01-11 14:19:26 UTC
python-stevedore-0.8-1.fc18 has been submitted as an update for Fedora 18.

Comment 15 Fedora Update System 2013-01-11 14:20:18 UTC
python-stevedore-0.8-1.el6 has been submitted as an update for Fedora EPEL 6.

Comment 16 Fedora Update System 2013-01-23 01:54:13 UTC
python-stevedore-0.8-1.fc17 has been pushed to the Fedora 17 stable repository.

Comment 17 Fedora Update System 2013-01-23 02:08:36 UTC
python-stevedore-0.8-1.fc18 has been pushed to the Fedora 18 stable repository.

Comment 18 Fedora Update System 2013-01-29 20:01:30 UTC
python-stevedore-0.8-1.el6 has been pushed to the Fedora EPEL 6 stable repository.

Note You need to log in before you can comment on or make changes to this bug.