Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Description of problem:
When I tried to start machine on 6.3 node, it failed with this error in vdsm.log:

The vm start process failed
Traceback (most recent call last):
  File "/usr/share/vdsm/vm.py", line 597, in _startUnderlyingVm
    self._run()
  File "/usr/share/vdsm/libvirtvm.py", line 1392, in _run
    domxml = hooks.before_vm_start(self._buildCmdLine(), self.conf)
  File "/usr/share/vdsm/libvirtvm.py", line 1250, in _buildCmdLine
    devElem = dev.getXML()
  File "/usr/share/vdsm/libvirtvm.py", line 1098, in getXML
    if  utils.tobool(self.shared):
AttributeError: 'Drive' object has no attribute 'shared'

Version-Release number of selected component (if applicable):
vdsm-4.9.6-44.0.el6_3

How reproducible:
not sure

Additional info:
Removal of the following statement from Drive.getXML is enough to fix the traceback:

        if  utils.tobool(self.shared):
            shareable = doc.createElement('shareable')
            diskelem.appendChild(shareable)

Note this statement is not present in the latest vdms supplied by oVirt project.

Please attach full vdsm.log

This request was not resolved in time for the current release.
Red Hat invites you to ask your support representative to
propose this request, if still desired, for consideration in
the next release of Red Hat Enterprise Linux.

Please attach full engine.log

Created attachment 664760 [details]
Requested vdsm.log

Please note that I performed some experiments with vdsm 4.10 on the node so you can safely ignore traceback & errors from vdsm 4.10.X

Created attachment 664774 [details]
Requested engine.log

engine.log which comes from ovirt shipped for Fedora 17 (ovirt 3.1.0-2.fc17)

'shared' is initialized in buildConfDevices.
In libvirtvm.py the only flow I can see that doesn't call buildConfDevices is if the conf already has a devices section (the last 'else' section below):

        if not 'recover' in self.conf:
...

            # For BC we should to keep running VM run after vdsm upgrade.
            # So, because this vm doesn't have normalize conf we need to build it
            # in recovery flow
            if not self.conf.get('devices'):
                devices = self.buildConfDevices()
            else:
                devices = self.getConfDevices()