887407 – UpdateNotice.xml() will render bad XML if an errata spans more than 1 collection

RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 887407 - UpdateNotice.xml() will render bad XML if an errata spans more than 1 collection

Summary: UpdateNotice.xml() will render bad XML if an errata spans more than 1 collection

Keywords:
Status:	CLOSED ERRATA
Alias:	None
Product:	Red Hat Enterprise Linux 6
Classification:	Red Hat
Component:	yum
Sub Component:
Version:	6.2
Hardware:	Unspecified
OS:	Unspecified
Priority:	unspecified
Severity:	unspecified
Target Milestone:	rc
Target Release:	---
Assignee:	Valentina Mukhamedzhanova
QA Contact:	Marek Marusic
Docs Contact:
URL:
Whiteboard:
Depends On:
Blocks:	907631
TreeView+	depends on / blocked

Reported:	2012-12-14 23:23 UTC by John Matthews
Modified:	2015-07-22 07:20 UTC (History)
CC List:	6 users (show)
Fixed In Version:	yum-3.2.29-63.el6
Doc Type:	Bug Fix
Doc Text:
Clone Of:
Clones:	907631 (view as bug list)
Environment:
Last Closed:	2015-07-22 07:20:46 UTC
Target Upstream Version:
Embargoed:

Attachments	(Terms of Use)

Links
System	ID	Private	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHBA-2015:1384	0	normal	SHIPPED_LIVE	yum bug fix and enhancement update	2015-07-20 18:07:41 UTC

Description John Matthews 2012-12-14 23:23:22 UTC

Description of problem:

When yum is used a library and yum.update_md.UpdateNotice is used to render XML data of errata objects there is potential for the XML to be rendered incorrectly.  Extra "</pkglist>" tags are included.


from yum/update_md.py  notice that line 346 "</pkglist>" is inside the for loop, when it should be outside to match line 330

329         if self._md['pkglist']:
330             msg += """  <pkglist>\n"""
331             for coll in self._md['pkglist']:
332                 msg += """    <collection short="%s">\n      <name>%s</name>\n""" % (
333                       to_xml(coll['short'], attrib=True),
334                       to_xml(coll['name']))
335 
336                 for pkg in coll['packages']:
337                     msg += """      <package arch="%s" name="%s" release="%s" src="%s" version="%s">
338         <filename>%s</filename>
339       </package>\n""" % (to_xml(pkg['arch'], attrib=True),
340                                 to_xml(pkg['name'], attrib=True),
341                                 to_xml(pkg['release'], attrib=True),
342                                 to_xml(pkg['src'], attrib=True),
343                                 to_xml(pkg['version'], attrib=True),
344                                 to_xml(pkg['filename']))
345                 msg += """    </collection>\n"""
346                 #msg += """  </pkglist>\n"""  <--- NOTICE THIS IS WHERE THE CHANGE IS, move </pkglist> to outside of loop
347             msg += """  </pkglist>\n"""
348         msg += """</update>\n"""
349         return msg


Version-Release number of selected component (if applicable):
yum-3.2.29-22.el6.noarch

How reproducible:


Steps to Reproduce:
1.  Requires an errata that spans 2 collections
2.  Run the xml() method on UpdatedNotice
3.
  
Actual results:

<pkglist>
    <collection short="rhel-x86_64-server-5">
      <name>Red Hat Enterprise Linux (v. 5 for 64-bit x86_64)</name>
      <package arch="x86_64" name="openssl-perl" release="22.el5_8.3" src="openssl-0.9.8e-22.el5_8.3.src.rpm" version="0.9.8e">
        <filename>openssl-perl-0.9.8e-22.el5_8.3.x86_64.rpm</filename>
      </package>
      <package arch="i386" name="openssl-devel" release="22.el5_8.3" src="openssl-0.9.8e-22.el5_8.3.src.rpm" version="0.9.8e">
        <filename>openssl-devel-0.9.8e-22.el5_8.3.i386.rpm</filename>
      </package>
      <package arch="i686" name="openssl" release="22.el5_8.3" src="openssl-0.9.8e-22.el5_8.3.src.rpm" version="0.9.8e">
        <filename>openssl-0.9.8e-22.el5_8.3.i686.rpm</filename>
      </package>
      <package arch="x86_64" name="openssl" release="22.el5_8.3" src="openssl-0.9.8e-22.el5_8.3.src.rpm" version="0.9.8e">
        <filename>openssl-0.9.8e-22.el5_8.3.x86_64.rpm</filename>
      </package>
      <package arch="x86_64" name="openssl-devel" release="22.el5_8.3" src="openssl-0.9.8e-22.el5_8.3.src.rpm" version="0.9.8e">
        <filename>openssl-devel-0.9.8e-22.el5_8.3.x86_64.rpm</filename>
      </package>
      <package arch="x86_64" name="openssl097a" release="11.el5_8.2" src="openssl097a-0.9.7a-11.el5_8.2.src.rpm" version="0.9.7a">
        <filename>openssl097a-0.9.7a-11.el5_8.2.x86_64.rpm</filename>
      </package>
      <package arch="i386" name="openssl097a" release="11.el5_8.2" src="openssl097a-0.9.7a-11.el5_8.2.src.rpm" version="0.9.7a">
        <filename>openssl097a-0.9.7a-11.el5_8.2.i386.rpm</filename>
      </package>
    </collection>
  </pkglist>
    <collection short="rhel-x86_64-server-6">
      <name>Red Hat Enterprise Linux Server (v. 6 for 64-bit x86_64)</name>
      <package arch="i686" name="openssl" release="20.el6_2.4" src="openssl-1.0.0-20.el6_2.4.src.rpm" version="1.0.0">
        <filename>openssl-1.0.0-20.el6_2.4.i686.rpm</filename>
      </package>
      <package arch="i686" name="openssl-devel" release="20.el6_2.4" src="openssl-1.0.0-20.el6_2.4.src.rpm" version="1.0.0">
        <filename>openssl-devel-1.0.0-20.el6_2.4.i686.rpm</filename>
      </package>
      <package arch="x86_64" name="openssl" release="20.el6_2.4" src="openssl-1.0.0-20.el6_2.4.src.rpm" version="1.0.0">
        <filename>openssl-1.0.0-20.el6_2.4.x86_64.rpm</filename>
      </package>
      <package arch="x86_64" name="openssl-devel" release="20.el6_2.4" src="openssl-1.0.0-20.el6_2.4.src.rpm" version="1.0.0">
        <filename>openssl-devel-1.0.0-20.el6_2.4.x86_64.rpm</filename>
      </package>
      <package arch="i686" name="openssl098e" release="17.el6_2.2" src="openssl098e-0.9.8e-17.el6_2.2.src.rpm" version="0.9.8e">
        <filename>openssl098e-0.9.8e-17.el6_2.2.i686.rpm</filename>
      </package>
      <package arch="x86_64" name="openssl098e" release="17.el6_2.2" src="openssl098e-0.9.8e-17.el6_2.2.src.rpm" version="0.9.8e">
        <filename>openssl098e-0.9.8e-17.el6_2.2.x86_64.rpm</filename>
      </package>
    </collection>
  </pkglist>



Expected results:

  <pkglist>
    <collection short="rhel-x86_64-server-5">
      <name>Red Hat Enterprise Linux (v. 5 for 64-bit x86_64)</name>
      <package arch="x86_64" name="openssl-perl" release="22.el5_8.3" src="openssl-0.9.8e-22.el5_8.3.src.rpm" version="0.9.8e">
        <filename>openssl-perl-0.9.8e-22.el5_8.3.x86_64.rpm</filename>
      </package>
      <package arch="i386" name="openssl-devel" release="22.el5_8.3" src="openssl-0.9.8e-22.el5_8.3.src.rpm" version="0.9.8e">
        <filename>openssl-devel-0.9.8e-22.el5_8.3.i386.rpm</filename>
      </package>
      <package arch="i686" name="openssl" release="22.el5_8.3" src="openssl-0.9.8e-22.el5_8.3.src.rpm" version="0.9.8e">
        <filename>openssl-0.9.8e-22.el5_8.3.i686.rpm</filename>
      </package>
      <package arch="x86_64" name="openssl" release="22.el5_8.3" src="openssl-0.9.8e-22.el5_8.3.src.rpm" version="0.9.8e">
        <filename>openssl-0.9.8e-22.el5_8.3.x86_64.rpm</filename>
      </package>
      <package arch="x86_64" name="openssl-devel" release="22.el5_8.3" src="openssl-0.9.8e-22.el5_8.3.src.rpm" version="0.9.8e">
        <filename>openssl-devel-0.9.8e-22.el5_8.3.x86_64.rpm</filename>
      </package>
      <package arch="x86_64" name="openssl097a" release="11.el5_8.2" src="openssl097a-0.9.7a-11.el5_8.2.src.rpm" version="0.9.7a">
        <filename>openssl097a-0.9.7a-11.el5_8.2.x86_64.rpm</filename>
      </package>
      <package arch="i386" name="openssl097a" release="11.el5_8.2" src="openssl097a-0.9.7a-11.el5_8.2.src.rpm" version="0.9.7a">
        <filename>openssl097a-0.9.7a-11.el5_8.2.i386.rpm</filename>
      </package>
    </collection>
    <collection short="rhel-x86_64-server-6">
      <name>Red Hat Enterprise Linux Server (v. 6 for 64-bit x86_64)</name>
      <package arch="i686" name="openssl" release="20.el6_2.4" src="openssl-1.0.0-20.el6_2.4.src.rpm" version="1.0.0">
        <filename>openssl-1.0.0-20.el6_2.4.i686.rpm</filename>
      </package>
      <package arch="i686" name="openssl-devel" release="20.el6_2.4" src="openssl-1.0.0-20.el6_2.4.src.rpm" version="1.0.0">
        <filename>openssl-devel-1.0.0-20.el6_2.4.i686.rpm</filename>
      </package>
      <package arch="x86_64" name="openssl" release="20.el6_2.4" src="openssl-1.0.0-20.el6_2.4.src.rpm" version="1.0.0">
        <filename>openssl-1.0.0-20.el6_2.4.x86_64.rpm</filename>
      </package>
      <package arch="x86_64" name="openssl-devel" release="20.el6_2.4" src="openssl-1.0.0-20.el6_2.4.src.rpm" version="1.0.0">
        <filename>openssl-devel-1.0.0-20.el6_2.4.x86_64.rpm</filename>
      </package>
      <package arch="i686" name="openssl098e" release="17.el6_2.2" src="openssl098e-0.9.8e-17.el6_2.2.src.rpm" version="0.9.8e">
        <filename>openssl098e-0.9.8e-17.el6_2.2.i686.rpm</filename>
      </package>
      <package arch="x86_64" name="openssl098e" release="17.el6_2.2" src="openssl098e-0.9.8e-17.el6_2.2.src.rpm" version="0.9.8e">
        <filename>openssl098e-0.9.8e-17.el6_2.2.x86_64.rpm</filename>
      </package>
    </collection>
  </pkglist>

Additional info:

Intended patch to fix this

$ cat 0001-Fixes-extra-pkglist-tags-being-inserted-when-renderi.patch 
From d3004df2dd98f29303a65a8c96871b0de9494963 Mon Sep 17 00:00:00 2001
From: John Matthews <jmatthews>
Date: Fri, 14 Dec 2012 16:51:35 -0500
Subject: [PATCH] Fixes extra '</pkglist>' tags being inserted when rendering a UpdateNotice to XML
 Only impacts Errata/UpdateInfo objects that span more than 1 collection

---
 yum/update_md.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/yum/update_md.py b/yum/update_md.py
index 4fe802b..e71f9ef 100644
--- a/yum/update_md.py
+++ b/yum/update_md.py
@@ -371,7 +371,7 @@ class UpdateNotice(object):
                                 to_xml(pkg['version'], attrib=True),
                                 to_xml(pkg['filename']))
                 msg += """    </collection>\n"""
-                msg += """  </pkglist>\n"""
+            msg += """  </pkglist>\n"""
         msg += """</update>\n"""
         return msg
 
-- 
1.7.1

Comment 2 RHEL Program Management 2012-12-21 06:47:32 UTC

This request was not resolved in time for the current release.
Red Hat invites you to ask your support representative to
propose this request, if still desired, for consideration in
the next release of Red Hat Enterprise Linux.

Comment 3 James Antill 2013-04-15 20:02:18 UTC

commit 6e56ea6a6236dde080d60f091a7854d204825bd4
Author: John Matthews <jmatthew>
Date:   Fri Dec 14 18:25:55 2012 -0500

Comment 5 RHEL Program Management 2013-10-14 00:09:36 UTC

This request was evaluated by Red Hat Product Management for
inclusion in the current release of Red Hat Enterprise Linux.
Because the affected component is not scheduled to be updated
in the current release, Red Hat is unable to address this
request at this time.

Red Hat invites you to ask your support representative to
propose this request, if appropriate, in the next release of
Red Hat Enterprise Linux.

Comment 9 errata-xmlrpc 2015-07-22 07:20:46 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-1384.html

Note You need to log in before you can comment on or make changes to this bug.