Spec URL: http://fedorapeople.org/~bubeck/vdr-vnsiserver.spec SRPM URL: http://fedorapeople.org/~bubeck/vdr-vnsiserver-0.0.1-1.20121216git.fc17.src.rpm Description: VDR plugin to handle XBMC clients. It is needed to use XBMC as a frontend and VDR as a backend. With the plugin it is possible to get TV and PVR functionality from a VDR into a XBMC. It is able to handle several XBMC clients connecting via the VNSI addon. Fedora Account System Username: bubeck
Here are the results of rpmlint. I see only false positives of spelling mistakes: [bubeck@sam vdr-vnsi-server]$ rpmlint /home/bubeck/rpmbuild/SRPMS/vdr-vnsiserver-0.0.1-1.20121216git.fc17.src.rpm vdr-vnsiserver.src: W: spelling-error %description -l en_US frontend -> fronted, front end, front-end vdr-vnsiserver.src: W: spelling-error %description -l en_US backend -> backed, back end, back-end vdr-vnsiserver.src: W: spelling-error %description -l en_US addon -> ad don, ad-don, add on vdr-vnsiserver.src: W: spelling-error %description -l en_US demuxing -> Deming vdr-vnsiserver.src: W: spelling-error %description -l en_US demuxer -> demurer, demurrer vdr-vnsiserver.src: W: invalid-url Source0: xbmc-pvr-addons-master-20121216git.zip 1 packages and 0 specfiles checked; 0 errors, 6 warnings. [bubeck@sam vdr-vnsi-server]$ rpmlint /home/bubeck/rpmbuild/RPMS/x86_64/vdr-vnsiserver-0.0.1-1.20121216git.fc17.x86_64.rpm vdr-vnsiserver.x86_64: W: spelling-error %description -l en_US frontend -> fronted, front end, front-end vdr-vnsiserver.x86_64: W: spelling-error %description -l en_US backend -> backed, back end, back-end vdr-vnsiserver.x86_64: W: spelling-error %description -l en_US addon -> ad don, ad-don, add on vdr-vnsiserver.x86_64: W: spelling-error %description -l en_US demuxing -> Deming vdr-vnsiserver.x86_64: W: spelling-error %description -l en_US demuxer -> demurer, demurrer 1 packages and 0 specfiles checked; 0 errors, 5 warnings.
Some drive-by notes: - rm -rf $RPM_BUILD_ROOT at the beginning of %install is not required anymore - no need for %defattr(-,root,root,-) in %files anymore - clean section is also not required anymore https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean - several files in lib/platform carry this copyright notice: This file is part of the libCEC(R) library. It looks like, they were copied from somewhere else. You need to unbundle those. https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries - Also: project/BuildDependencies/bin carries compiled files from Windows (dlls, exe file) You need to remove that during prep.
Thanks for your feedback, which is reflected in an updated version: Spec URL: http://fedorapeople.org/~bubeck/vdr-vnsiserver.spec SRPM URL: http://fedorapeople.org/~bubeck/vdr-vnsiserver-0.9.0-0.1.20121216git14a1fe5c58.fc17.src.rpm
Can anyone please review? This RPM is needed to connect the upcoming XBMC "Frodo" with a Fedora Video Disk Recorder (VDR). The package is very small and simple and I worked in all previous feedback. Please review and set flags accordingly. Thanks!
Till, if you want this reviewed, you might ask at devel-list for a review. Usually it helps, if you also offer to trade reviews.
Some other drive-by comments: - As Mathias says, it's better to offer to trade reviews than to just ask for one. - Obviously you have updated the spec, but there are no notes in the changelog [1] - Are the %{optflags} in effect as required by[2]? - The Buildroot: tag is not needed unless you are heading for EPEL5 [3] - Use %global instead of %define [4] - You should inform upstream about the bad FSF address in COPYING [5] I'm particularly concerned about Mathias comment #2 about the lib/platform files. What happened to those? [1] https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs [2] https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags [3] https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag [4] https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define [5] http://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address
Thanks for your feedback, which is reflected in an updated version: Spec URL: http://fedorapeople.org/~bubeck/vdr-vnsiserver.spec SRPM URL: http://fedorapeople.org/~bubeck/vdr-vnsiserver-0.9.0-0.2.20130104git04258ed894.fc17.src.rpm (In reply to comment #6) > Some other drive-by comments: > - As Mathias says, it's better to offer to trade reviews than to just ask > for one. What do you mean? Should I offer to review someone elses packages if he reviews mine? Am I allowed to review other peoples packages? > - Obviously you have updated the spec, but there are no notes in the > changelog [1] done > - Are the %{optflags} in effect as required by[2]? yes, done > - The Buildroot: tag is not needed unless you are heading for EPEL5 [3] removed > - Use %global instead of %define [4] done > - You should inform upstream about the bad FSF address in COPYING [5] done, see https://github.com/opdenkamp/xbmc-pvr-addons/issues/137 > I'm particularly concerned about Mathias comment #2 about the lib/platform > files. What happened to those? I am only packaging the vdr-vnsiserver. The git repository holds many more plugins and addons and the DLL and binary files from comment #2. After getting the feedback I only package a subfolder of the git repository because I did not need the others at all. Therefore, they are not part of the Source0 anymore. For a description on how to prepare the Source0, see the comments in the specfile.
(In reply to comment #7) > Thanks for your feedback, which is reflected in an updated version: > > Spec URL: http://fedorapeople.org/~bubeck/vdr-vnsiserver.spec > SRPM URL: > http://fedorapeople.org/~bubeck/vdr-vnsiserver-0.9.0-0.2. > 20130104git04258ed894.fc17.src.rpm > > (In reply to comment #6) > > Some other drive-by comments: > > - As Mathias says, it's better to offer to trade reviews than to just ask > > for one. > > What do you mean? Should I offer to review someone elses packages if he > reviews mine? Am I allowed to review other peoples packages? Since you ask, and since I cannot find you in the packagers group: it looks like you not are sponsored. If so, you need to add FE_NEEDSPONSOR to the list of Blocks: bugs above, see http://fedoraproject.org/wiki/Package_Review_Process. If so, it also means that you cannot trade reviews and that this package must be reviewed by someone who can sponsor you. Unfortunately, I'm no such person. > I am only packaging the vdr-vnsiserver. The git repository holds many more > plugins and addons and the DLL and binary files from comment #2. After > getting the feedback I only package a subfolder of the git repository > because I did not need the others at all. Therefore, they are not part of > the Source0 anymore. For a description on how to prepare the Source0, see > the comments in the specfile. Which is perfectly fine, but deserved an explanation :) Perhaps it would have been easier to use the complete tarball and remove everything besides the subdir used in %prep, but it's more a question of personal preferences IMHO.
BTW: I cannot see any of the changes you have done in that specfile link. Did you accidentally publish the old version again?
Sorry, my bad: nothing is wrong in that link. My browser cache fooled me.
Hm. I am already a packager owning a few packages for Fedora and I am also sponsored. Does that mean, that I can review other peoples review request? Am I allowed to review my own requests? :-) > Since you ask, and since I cannot find you in the packagers group: it looks > like you not are sponsored. If so, you need to add FE_NEEDSPONSOR to the > list of Blocks: bugs above, see > http://fedoraproject.org/wiki/Package_Review_Process. > > If so, it also means that you cannot trade reviews and that this package > must be reviewed by someone who can sponsor you. Unfortunately, I'm no such > person.
(In reply to comment #11) > Hm. I am already a packager owning a few packages for Fedora and I am also > sponsored. Does that mean, that I can review other peoples review request? yes > > Am I allowed to review my own requests? :-) No :) So, the best option is to try to trade reviews.
> License: GPLv2 GPLv2+ according to the README and the C source files Also see: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#.22or_later_version.22_licenses
Thanks! License changed to GPLv2+ and updated in: Spec URL: http://fedorapeople.org/~bubeck/vdr-vnsiserver.spec SRPM URL: http://fedorapeople.org/~bubeck/vdr-vnsiserver-0.9.0-0.3.20130104git04258ed894.fc17.src.rpm
I'm one of the two downstream maintainers (along with Ken Dreyer) of XBMC in RPM Fusion, see: http://rpmfusion.org/AlexLancaster You can track our packaging efforts in git here: http://fedorapeople.org/cgit/alexlan/public_git/xbmc-rpm.git I think this package would have to be ported to RPM Fusion, as it's completely non-functional without the core XBMC package, unless there's some kind of precedent for having it in Fedora.
(In reply to comment #15) > I think this package would have to be ported to RPM Fusion, as it's > completely non-functional without the core XBMC package, unless there's some > kind of precedent for having it in Fedora. I know that XBMC is part of rpmfusion and I am thankful for the work you do there. However, VDR is part of Fedora. "My" package is a plugin of VDR to offer an additional access to VDR named "VNSI". Any frontend (not only XBMC) could use that protocol to access VDR. You are right, that XBMC uses that protocol to access VDR. Please note, that this VDR plugin was named "VNSI" and not "XBMC" to express that it is not thought of a "XBMC only" access. At least, this is my understanding. So I see it as part of VDR simlar to the streamingserver plugin of VDR. I see the addons needed in XBMC to connect to a PVR belonging to XBMC and therefore belonging to RPM Fusion. So I see this package as part of Fedora. However, my primary interest is to get the users of Fedora (including rpmfusion) an easy access to VDR and XBMC. Therefore, I do not mind _that_ much, where it belongs. If no one is stepping up to review this package I am thankfully moving to rpmfusion.
I'd be glad to review this package. I see also no problem to include this package in the official repositories. Some comments: - is there any reason you base your plugin on a git commit? Using the latest tag (Frodo_rc3 ) isn't OK? I've been using this tag for a moment with XBMC, with no particular issue. - vdr-devel provides many useful RPM macros (see /etc/rpm/macros.vdr) you should use instead of those you set on your .spec file: %{plugindir} --> %{vdr_plugindir} %{apiver} --> %{vdr_apiversion} %{configdir} --> %{vdr_configdir} - Is there a reason you add extra flags to %{optflags}? I can understand -fPIC is needed, but what about all the others?
Mohamed, Thanks for reviewing the package. I will post an updated version soon. (In reply to comment #17) > - is there any reason you base your plugin on a git commit? Using the latest > tag (Frodo_rc3 ) isn't OK? I've been using this tag for a moment with XBMC, > with no particular issue. You are right, I will change this. At the time I first wrote the SPEC file, there was no tag at all. This is why I choose the git commit to get a stable base. However, there is indeed a problem with RC3 (see https://github.com/opdenkamp/xbmc-pvr-addons/issues/160 for the description and solution). However, I would like to follow the "official" plugin instead of any feature clones of others. So I stay with RC3 until Frodo 12 and the addon come out officially. > - vdr-devel provides many useful RPM macros (see /etc/rpm/macros.vdr) you > should use instead of those you set on your .spec file: Thanks for that. I will use it. > - Is there a reason you add extra flags to %{optflags}? I can understand > -fPIC is needed, but what about all the others? I will check the others and enter the reasone into the SPEC file.
> (In reply to comment #17) > > - is there any reason you base your plugin on a git commit? Using the latest > > tag (Frodo_rc3 ) isn't OK? I've been using this tag for a moment with XBMC, > > with no particular issue. > > You are right, I will change this. At the time I first wrote the SPEC file, > there was no tag at all. This is why I choose the git commit to get a stable > base. However, there is indeed a problem with RC3 (see > https://github.com/opdenkamp/xbmc-pvr-addons/issues/160 for the description > and solution). However, I would like to follow the "official" plugin instead > of any feature clones of others. So I stay with RC3 until Frodo 12 and the > addon come out officially. The issue you reported with HDTV is probably a good reason to use a snapshot version of the plugin instead of the last stable tag, unless a backport is possible and not too complicated. I'd like to reproduce this issue, I realize I haven't tested yet HDTV on DVB-T. I'll try tonight...
Here we go. Please find an updated version at Spec URL: http://fedorapeople.org/~bubeck/vdr-vnsiserver3.spec SRPM URL: http://fedorapeople.org/~bubeck/vdr-vnsiserver3-0.9.0-1.fc18.src.rpm Please note, that I changed the packagename to "vdr-vnsiserver3" which included the VNSI protocol name, as stated by the package owners: http://forum.xbmc.org/showthread.php?tid=153801 This allows us to create multiple package, one for each VNSI protocol version. The user can then decide, which package to install depending on the protocol version needed by the XBMC. Please note also, that I stay at the released git tag "12.0-Frodo", also it contains the bug described in https://github.com/opdenkamp/xbmc-pvr-addons/issues/160. I did not switch to the experimental branch mentioned in comment #18 because the package owners decided this. See the above issue for an explanation. Basically the experimental branch also is a large refactorization and the authors see the inclusion at too risky at the moment. They will include it after the release. Then I will update, too. Is now anything OK? Could you give the needed flags, after review? THANKS!
New Package SCM Request ======================= Package Name: vdr-vnsiserver3 Short Description: VDR plugin to handle XBMC clients via VNSI Owners: bubeck Branches: f18 InitialCC:
Actually, I haven't finished my review yet... I've just set up the fedora-review tag to « ? ». I will review this package later in the morning. Be patient ;)
Uh, sorry. I misunderstood your flag. Sorry! Take your time...
(In reply to comment #20) > Please note, that I changed the packagename to "vdr-vnsiserver3" which > included the VNSI protocol name, as stated by the package owners: > http://forum.xbmc.org/showthread.php?tid=153801 > This allows us to create multiple package, one for each VNSI protocol > version. The user can then decide, which package to install depending on the > protocol version needed by the XBMC. It's OK. > Please note also, that I stay at the released git tag "12.0-Frodo", also it > contains the bug described in > https://github.com/opdenkamp/xbmc-pvr-addons/issues/160. I did not switch to > the experimental branch mentioned in comment #18 because the package owners > decided this. See the above issue for an explanation. Basically the > experimental branch also is a large refactorization and the authors see the > inclusion at too risky at the moment. They will include it after the > release. Then I will update, too. It's OK too. Here is the review: Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. >> Notice that the plugin includes demuxing support for some patented formats (no decoding involved), so it should be OK for legal [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package contains no bundled libraries. [x]: Changelog in prescribed format. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Sources contain only permissible code or content. [x]: %config files are marked noreplace or the reason is justified. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package complies to the Packaging Guidelines [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later) (with incorrect FSF address)", "GPL (v2 or later)", "Unknown or generated". 3 files have unknown license. Detailed output of licensecheck in /home/mohamed/rpmbuild/SPECS/review-vdr- vnsiserver3/licensecheck.txt [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named using only allowed ASCII characters. [x]: Package is named according to the Package Naming Guidelines. [x]: No %config files under /usr. [x]: Package does not generate any conflict. Note: Package contains no Conflicts: tag(s) [x]: Package do not use a name that already exist [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package installs properly. [-]: Package is not relocatable. [x]: Requires correct, justified where necessary. [x]: CheckResultdir [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file is legible and written in American English. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: Package contains systemd file(s) if in need. [x]: File names are valid UTF-8. [x]: Useful -debuginfo package or justification otherwise. [x]: Large documentation must go in a -doc subpackage. Note: Documentation size is 30720 bytes in 3 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [!]: SourceX / PatchY prefixed with %{name}. Note: Source0 (vdr-plugin-vnsiserver.tar.xz) [x]: SourceX is a working URL. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: vdr-vnsiserver3-0.9.0-1.fc18.x86_64.rpm vdr-vnsiserver3-0.9.0-1.fc18.src.rpm vdr-vnsiserver3-debuginfo-0.9.0-1.fc18.x86_64.rpm vdr-vnsiserver3.x86_64: W: spelling-error %description -l en_US frontend -> fronted, front end, front-end vdr-vnsiserver3.x86_64: W: spelling-error %description -l en_US backend -> backed, back end, back-end vdr-vnsiserver3.x86_64: W: spelling-error %description -l en_US addon -> ad don, ad-don, add on vdr-vnsiserver3.x86_64: W: spelling-error %description -l en_US demuxing -> Deming vdr-vnsiserver3.x86_64: W: spelling-error %description -l en_US demuxer -> demurer, demurrer vdr-vnsiserver3.src: W: spelling-error %description -l en_US frontend -> fronted, front end, front-end vdr-vnsiserver3.src: W: spelling-error %description -l en_US backend -> backed, back end, back-end vdr-vnsiserver3.src: W: spelling-error %description -l en_US addon -> ad don, ad-don, add on vdr-vnsiserver3.src: W: spelling-error %description -l en_US demuxing -> Deming vdr-vnsiserver3.src: W: spelling-error %description -l en_US demuxer -> demurer, demurrer vdr-vnsiserver3.src: W: invalid-url Source0: vdr-plugin-vnsiserver.tar.xz vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/config.c vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/hash.h vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/demuxer_AC3.h vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/config.h vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/demuxer_MPEGVideo.h vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/demuxer_AC3.c vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/hash.c vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/recordingscache.h vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/recordingscache.c vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/requestpacket.h vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/vnsiserver.h vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/demuxer_MPEGVideo.c vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/requestpacket.c vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/vnsiclient.h vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/demuxer.h vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/demuxer_MPEGAudio.c vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/cxsocket.c vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/demuxer_MPEGAudio.h vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/demuxer.c vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/vnsiclient.c vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/receiver.h vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/vnsiserver.c vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/demuxer_Subtitle.c vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/demuxer_h264.h vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/bitstream.h vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/demuxer_DTS.c vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/demuxer_AAC.c vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/bitstream.c vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/demuxer_h264.c vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/demuxer_Subtitle.h vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/demuxer_AAC.h vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/vnsi.c vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/demuxer_DTS.h vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/recplayer.c vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/demuxer_Teletext.h vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/receiver.c vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/demuxer_Teletext.c vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/recplayer.h vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/responsepacket.h vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/vnsi.h vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/cxsocket.h vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/responsepacket.c 3 packages and 0 specfiles checked; 42 errors, 11 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint vdr-vnsiserver3 vdr-vnsiserver3-debuginfo vdr-vnsiserver3.x86_64: W: spelling-error %description -l en_US frontend -> fronted, front end, front-end vdr-vnsiserver3.x86_64: W: spelling-error %description -l en_US backend -> backed, back end, back-end vdr-vnsiserver3.x86_64: W: spelling-error %description -l en_US addon -> ad don, ad-don, add on vdr-vnsiserver3.x86_64: W: spelling-error %description -l en_US demuxing -> Deming vdr-vnsiserver3.x86_64: W: spelling-error %description -l en_US demuxer -> demurer, demurrer vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/config.c vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/hash.h vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/demuxer_AC3.h vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/config.h vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/demuxer_MPEGVideo.h vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/demuxer_AC3.c vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/hash.c vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/recordingscache.h vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/recordingscache.c vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/requestpacket.h vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/vnsiserver.h vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/demuxer_MPEGVideo.c vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/requestpacket.c vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/vnsiclient.h vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/demuxer.h vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/demuxer_MPEGAudio.c vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/cxsocket.c vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/demuxer_MPEGAudio.h vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/demuxer.c vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/vnsiclient.c vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/receiver.h vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/vnsiserver.c vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/demuxer_Subtitle.c vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/demuxer_h264.h vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/bitstream.h vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/demuxer_DTS.c vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/demuxer_AAC.c vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/bitstream.c vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/demuxer_h264.c vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/demuxer_Subtitle.h vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/demuxer_AAC.h vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/vnsi.c vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/demuxer_DTS.h vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/recplayer.c vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/demuxer_Teletext.h vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/receiver.c vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/demuxer_Teletext.c vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/recplayer.h vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/responsepacket.h vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/vnsi.h vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/cxsocket.h vdr-vnsiserver3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vdr-plugin-vnsiserver/responsepacket.c 2 packages and 0 specfiles checked; 42 errors, 5 warnings. # echo 'rpmlint-done:' Requires -------- vdr-vnsiserver3-0.9.0-1.fc18.x86_64.rpm (rpmlib, GLIBC filtered): config(vdr-vnsiserver3) = 0.9.0-1.fc18 libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) vdr(abi)(x86-64) = 1.7.31 vdr-vnsiserver3-debuginfo-0.9.0-1.fc18.x86_64.rpm (rpmlib, GLIBC filtered): Provides -------- vdr-vnsiserver3-0.9.0-1.fc18.x86_64.rpm: config(vdr-vnsiserver3) = 0.9.0-1.fc18 libvdr-vnsiserver.so.1.7.31()(64bit) vdr-vnsiserver3 = 0.9.0-1.fc18 vdr-vnsiserver3(x86-64) = 0.9.0-1.fc18 vdr-vnsiserver3-debuginfo-0.9.0-1.fc18.x86_64.rpm: vdr-vnsiserver3-debuginfo = 0.9.0-1.fc18 vdr-vnsiserver3-debuginfo(x86-64) = 0.9.0-1.fc18 Issues: - rpmlint outputs are OK (incorrect-fsf-address warnings are not a blocker, maybe you should report them upstream). - Be very careful not to mix variable and macro styles in your .spec file (see "%{optflags}" and "$RPM_BUILD_ROOT" both used). - You should change the tarball name to reflect the package renaming (vdr-vnsiserver -> vdr-vnsiserver3). Once the two last issues fixed, I will approve your package.
Here we go. Please find an updated version at Spec URL: http://fedorapeople.org/~bubeck/vdr-vnsiserver3.spec SRPM URL: http://fedorapeople.org/~bubeck/vdr-vnsiserver3-0.9.0-2.fc18.src.rpm Thanks for doing the detailled review and giving valuable feedback!
I think it's OK now :) This package is APPROVED!
Mohamed, thanks for all your work. I've been going through a number of reviews in the past. But your review was very good and very detailled. Thanks a lot!
Requested package name vdr-vnsiserver3 doesn't match bug summary vdr-vnsiserver, please correct.
We changed the name in the middle of the review process (see comment #20) and did not update the bugzilla entry. This is now done.
Git done (by process-git-requests).
Thanks to anyone helping this package come to Fedora!