Bug 887911 (libigtl) - Review Request: libigtl - Network communication library for image-guided therapy
Summary: Review Request: libigtl - Network communication library for image-guided therapy
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: libigtl
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jerry James
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-12-17 15:35 UTC by Mario Ceresa
Modified: 2013-01-23 02:04 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2013-01-23 01:36:45 UTC
Type: ---
Embargoed:
loganjerry: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Mario Ceresa 2012-12-17 15:35:56 UTC
Spec URL: https://github.com/mrceresa/fedora_medical/blob/master/libopenigtlink/libopenigt.spec
SRPM URL: http://mrceresa.fedorapeople.org/libigtl-1.9.7-1.fc17.src.rpm
Description: 
OpenIGTLink provides a standardized mechanism for communications among computers
and devices in operating rooms (OR) for wide variety of image-guided therapy (IGT)
applications. Examples of such applications include:

* Stereotactic surgical guidance using optical position sensor.
* Intraoperative image guidance using real-time MRI.
* Robot-assisted intervention using robotic device and surgical planning software 

OpenIGTLink is a set of digital messaging formats and rules (protocol) used for data 
exchange on a local area network (LAN). The specification of OpenIGTLink and its 
reference implementation, the OpenIGTLink Library, are available free of charge 
for any purpose including commercial use. 

An OpenIGTLink interface is available in popular medical image processing and 
visualization software 3D Slicer.

Fedora Account System Username: mrceresa

Comment 1 Mario Ceresa 2012-12-17 15:56:26 UTC
Builds in koji:

http://koji.fedoraproject.org/koji/taskinfo?taskID=4796930

Comment 2 Mario Ceresa 2012-12-17 16:49:31 UTC
Fixed several errors pointed out by fedora-review:
http://mrceresa.fedorapeople.org/libigtl-1.9.7-2.fc17.src.rpm

Comment 3 Mario Ceresa 2012-12-17 17:03:34 UTC
Package Review
==============

Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[-]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
[?]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
     names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: No %config files under /usr.
[x]: Package does not generate any conflict.
     Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[-]: Package is not relocatable.
[-]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[-]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[?]: Useful -debuginfo package or justification otherwise.
[x]: Large documentation must go in a -doc subpackage.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Final provides and requires are sane (rpm -q --provides and rpm -q
     --requires).
[x]: Package functions as described.
[x]: Latest version is packaged.
[?]: Package does not include license text files separate from upstream.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Scriptlets must be sane, if used.
[x]: SourceX tarball generation or download is documented.
[!]: SourceX / PatchY prefixed with %{name}.
     Note: Source0 (openigtlink-OpenIGTLink-00c007f.tar.gz)
[x]: SourceX is a working URL.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: %check is present and all tests pass. 
     Note: tests pass locally. Still have to change the specfile.
[?]: Packages should try to preserve timestamps of original installed files.
[x]: Spec use %global instead of %define.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.


Rpmlint
-------
Checking: libigtl-1.9.7-2.fc17.x86_64.rpm
          libigtl-devel-1.9.7-2.fc17.x86_64.rpm
          libigtl-debuginfo-1.9.7-2.fc17.x86_64.rpm
          libigtl-1.9.7-2.fc17.src.rpm
libigtl.x86_64: W: no-documentation
libigtl-devel.x86_64: W: only-non-binary-in-usr-lib
libigtl-devel.x86_64: W: no-documentation
libigtl.src:6: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 6)
4 packages and 0 specfiles checked; 0 errors, 4 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint libigtl-devel libigtl libigtl-debuginfo
libigtl-devel.x86_64: W: only-non-binary-in-usr-lib
libigtl-devel.x86_64: W: no-documentation
libigtl.x86_64: W: no-documentation
3 packages and 0 specfiles checked; 0 errors, 3 warnings.
# echo 'rpmlint-done:'



Requires
--------
libigtl-1.9.7-2.fc17.x86_64.rpm (rpmlib, GLIBC filtered):
    
    /sbin/ldconfig  
    config(libigtl) = 1.9.7-2.fc17
    libc.so.6()(64bit)  
    libgcc_s.so.1()(64bit)  
    libgcc_s.so.1(GCC_3.0)(64bit)  
    libm.so.6()(64bit)  
    libpthread.so.0()(64bit)  
    libstdc++.so.6()(64bit)  
    libstdc++.so.6(CXXABI_1.3)(64bit)  
    rtld(GNU_HASH)  

libigtl-devel-1.9.7-2.fc17.x86_64.rpm (rpmlib, GLIBC filtered):
    
    libOpenIGTLink.so.1()(64bit)  
    libigtl(x86-64) = 1.9.7-2.fc17

libigtl-debuginfo-1.9.7-2.fc17.x86_64.rpm (rpmlib, GLIBC filtered):
    



Provides
--------
libigtl-1.9.7-2.fc17.x86_64.rpm:
    
    config(libigtl) = 1.9.7-2.fc17
    libOpenIGTLink.so.1()(64bit)  
    libigtl = 1.9.7-2.fc17
    libigtl(x86-64) = 1.9.7-2.fc17

libigtl-devel-1.9.7-2.fc17.x86_64.rpm:
    
    libigtl-devel = 1.9.7-2.fc17
    libigtl-devel(x86-64) = 1.9.7-2.fc17

libigtl-debuginfo-1.9.7-2.fc17.x86_64.rpm:
    
    libigtl-debuginfo = 1.9.7-2.fc17
    libigtl-debuginfo(x86-64) = 1.9.7-2.fc17



MD5-sum check
-------------
https://github.com/openigtlink/OpenIGTLink/tarball/development/openigtlink-OpenIGTLink-00c007f.tar.gz :
  CHECKSUM(SHA256) this package     : 3726d2197010823b4b1ba706fad7d4c0e6f208a3445935b1eb0387067e9c41f6
  CHECKSUM(SHA256) upstream package : 3726d2197010823b4b1ba706fad7d4c0e6f208a3445935b1eb0387067e9c41f6

Comment 4 eric 2012-12-17 17:37:00 UTC
Spec file URL doesn't resolve.

Comment 5 Mario Ceresa 2012-12-18 08:19:12 UTC
Oops! it changed name midway:

https://github.com/mrceresa/fedora_medical/blob/master/libopenigtlink/libigtl.spec

Comment 6 Mario Ceresa 2012-12-18 09:29:56 UTC
This should add license information and some more fixes:
http://mrceresa.fedorapeople.org/libigtl-1.9.7-3.fc17.src.rpm
http://koji.fedoraproject.org/koji/taskinfo?taskID=4798995

I still have to patch to build documentation (it misses a CMakeLists file) and BR doxygen. Also should check that all libs have proper sonames.

Comment 7 Mario Ceresa 2012-12-18 11:05:21 UTC
Here there is also the documentation: 
http://mrceresa.fedorapeople.org/libigtl-1.9.7-4.fc17.src.rpm
http://koji.fedoraproject.org/koji/taskinfo?taskID=4799429

It should be in a fine shape by now.

Comment 8 Jerry James 2012-12-19 15:29:38 UTC
I will take this review.  Could you review bug 888598 for me?

Comment 9 Jerry James 2012-12-19 15:35:51 UTC
That's annoying.  Your spec file link in comment 5 returns a bunch of HTML, which breaks fedora-review.  I'll extract the spec file from your SRPM for now, but in the future please post a link to the actual spec file.

Comment 10 Mario Ceresa 2012-12-19 16:04:28 UTC
Sure Jerry, thanks! Sorry for the spec, I thought it was nice to directly link the last github version, but now I see it was a bad idea.

Comment 11 Jerry James 2012-12-19 16:45:27 UTC
No problem.  I see this in the build log:

-- Found Doxygen: /usr/bin/doxygen (found version "1.8.2") 
pdflatex compiler was not found. Please pass to advanced mode and provide its full path

I see that you have "BuildRequires: texlive-latex" (which should be "BuildRequires: tex(latex)", by the way), but the build system isn't finding it.  I think you have to pass "-DPDFLATEX_COMPILER=%{_bindir}/pdflatex" to %cmake.  Yes, that works, but now it fails due to missing fonts.  For Fedora 18 and later only, you also need these:

BuildRequires: tex-helvetic
BuildRequires: tex-symbol
BuildRequires: tex-times

Even then, it fails:

! Package hyperref Error: Wrong DVI mode driver option `dvips',
(hyperref)                because pdfTeX or LuaTeX is running in PDF mode.
See the hyperref package documentation for explanation.
Type  H <return>  for immediate help.
 ...                                              
                                                  
l.4319 \ProcessKeyvalOptions{Hyp}
                                 
? 
! Emergency stop.
 ...                                              
                                                  
l.4319 \ProcessKeyvalOptions{Hyp}
                                 
!  ==> Fatal error occurred, no output PDF file produced!
Transcript written on OpenIGTLinkIJ2008.log.

For this to work, you'll need to patch Documents/Papers/InsightJournal2008/OpenIGTLinkIJ2008.tex to make the following changes:

Line 11: change \usepackage[dvips]{graphicx} to \usepackage[pdftex]{graphicx}.
Line 18: change \usepackage[dvips, to \usepackage[pdftex,.

Simply doing "sed s/dvips/pdftex/ Documents/Papers/InsightJournal2008/OpenIGTLinkIJ2008.tex" in %prep is sufficient, if you like that better than an actual patch.

Comment 12 Jerry James 2012-12-19 21:20:16 UTC
Random issues:

1) Inside of %files doc you have this:

   %dir %{_docdir}/%{name}-%{version}

   But that is the name of the doc dir for the main package, which already has
   LICENSE.txt and README in there.  The end result is that all of the
   documentation appears in both the main package and the -doc subpackage.

2) The summary line is too long for some of the GUI tools to display it
   properly.  One way to shorten it is to remove the first two words: "Free,
   open-source".  If it wasn't free and open source, it wouldn't be in Fedora,
   so I think those words are redundant.

   If you change the summary line, be sure to change the bug name, too.

3) What is the purpose in putting the library files in a subdirectory of
   %{_libdir} and then mucking around with /etc/ld.so.conf.d?  Usually,
   subdirectories of %{_libdir} are for private application stuff that should
   not be visible to other packages.  But this is a library that presumably is
   to be used by as-yet-unreviewed other packages, so the library files should
   go into %{_libdir}, and no /etc/ld.so.conf.d file is necessary.  Is there
   some reason for doing things this way?

Package Review
==============

Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
[!]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
     Note: Upstream MD5sum check error, diff is in
     /home/jamesjer/887911-libigtl/review-libigtl/diff.txt
See: http://fedoraproject.org/wiki/Packaging/SourceURL

[!]: Changelog in prescribed format.
     The string "libOpenIGTLink" should not be given, and angle brackets
     around the email address are missing.
See: https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs

SHOULD:
[!]: Patches link to upstream bugs/comments/lists or are otherwise justified.
See: https://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment

[!]: %check is present and all tests pass.


===== MUST items =====

C/C++:
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[!]: Changelog in prescribed format.
     The package name should not be given, and angle brackets around the email
     address are missing.  See
     https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs for a
     choice of 3 allowed formats.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Unknown or generated". 1 files have unknown license. Detailed output of
     licensecheck in /home/jamesjer/887911-libigtl/review-
     libigtl/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: No %config files under /usr.
[x]: Package does not generate any conflict.
     Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[x]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[!]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
     Note: Upstream MD5sum check error, diff is in
     /home/jamesjer/887911-libigtl/review-libigtl/diff.txt
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Large documentation must go in a -doc subpackage.
     Note: Documentation size is 501760 bytes in 90 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Final provides and requires are sane (rpm -q --provides and rpm -q
     --requires).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Scriptlets must be sane, if used.
[x]: SourceX tarball generation or download is documented.
[!]: SourceX / PatchY prefixed with %{name}.
     Note: Patch0 (0001-Add-generation-of-doxygen-documentation.patch) Patch1
     (0002-Add-doxygen-and-papers-dir.patch) Source0 (openigtlink-OpenIGTLink-
     00c007f.tar.gz) Patch2 (0003-Use-original-doxyfile.patch)
[x]: SourceX is a working URL.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Spec use %global instead of %define.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.


Rpmlint
-------
Checking: libigtl-doc-1.9.7-4.fc19.i686.rpm
	  libigtl-debuginfo-1.9.7-4.fc19.i686.rpm
	  libigtl-devel-1.9.7-4.fc19.i686.rpm
	  libigtl-1.9.7-4.fc19.i686.rpm
	  libigtl-1.9.7-4.fc19.src.rpm
libigtl-devel.i686: W: only-non-binary-in-usr-lib
libigtl-devel.i686: W: no-documentation
libigtl.src:6: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 6)
libigtl.src: W: file-size-mismatch openigtlink-OpenIGTLink-00c007f.tar.gz = 351369, https://github.com/openigtlink/OpenIGTLink/tarball/development/openigtlink-OpenIGTLink-00c007f.tar.gz = 351897
5 packages and 0 specfiles checked; 0 errors, 4 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint libigtl-devel libigtl-debuginfo libigtl-doc libigtl
libigtl-devel.i686: W: only-non-binary-in-usr-lib
libigtl-devel.i686: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 2 warnings.
# echo 'rpmlint-done:'



Requires
--------
libigtl-doc-1.9.7-4.fc19.i686.rpm (rpmlib, GLIBC filtered):

    libigtl(x86-32) = 1.9.7-4.fc19

libigtl-debuginfo-1.9.7-4.fc19.i686.rpm (rpmlib, GLIBC filtered):


libigtl-devel-1.9.7-4.fc19.i686.rpm (rpmlib, GLIBC filtered):

    libOpenIGTLink.so.1
    libigtl(x86-32) = 1.9.7-4.fc19

libigtl-1.9.7-4.fc19.i686.rpm (rpmlib, GLIBC filtered):

    /sbin/ldconfig
    config(libigtl) = 1.9.7-4.fc19
    libc.so.6
    libgcc_s.so.1
    libgcc_s.so.1(GCC_3.0)
    libm.so.6
    libpthread.so.0
    libstdc++.so.6
    libstdc++.so.6(CXXABI_1.3)
    rtld(GNU_HASH)



Provides
--------
libigtl-doc-1.9.7-4.fc19.i686.rpm:

    libigtl-doc = 1.9.7-4.fc19
    libigtl-doc(x86-32) = 1.9.7-4.fc19

libigtl-debuginfo-1.9.7-4.fc19.i686.rpm:

    libigtl-debuginfo = 1.9.7-4.fc19
    libigtl-debuginfo(x86-32) = 1.9.7-4.fc19

libigtl-devel-1.9.7-4.fc19.i686.rpm:

    libigtl-devel = 1.9.7-4.fc19
    libigtl-devel(x86-32) = 1.9.7-4.fc19

libigtl-1.9.7-4.fc19.i686.rpm:

    config(libigtl) = 1.9.7-4.fc19
    libOpenIGTLink.so.1
    libigtl = 1.9.7-4.fc19
    libigtl(x86-32) = 1.9.7-4.fc19



MD5-sum check
-------------
https://github.com/openigtlink/OpenIGTLink/tarball/development/openigtlink-OpenIGTLink-00c007f.tar.gz :
  CHECKSUM(SHA256) this package     : 3726d2197010823b4b1ba706fad7d4c0e6f208a3445935b1eb0387067e9c41f6
  CHECKSUM(SHA256) upstream package : db027b63f6ae95084dcf3e348e9485be3bd8f91d8db3cb01a1696f66546bfc1c
diff -r also reports differences


Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16
Buildroot used: fedora-rawhide-i386
Command line :/usr/bin/fedora-review -n libigtl -m fedora-rawhide-i386

Comment 13 Mario Ceresa 2012-12-19 23:11:40 UTC
Thanks Jerry for your feedback. The package is way better now:

Spec URL: http://mrceresa.fedorapeople.org/libigtl.spec
SRPM URL: http://mrceresa.fedorapeople.org/libigtl-1.9.7-5.fc17.src.rpm

Comment 14 Jerry James 2012-12-20 21:29:22 UTC
Oops, I messed up on that sed expression.  It's missing "-i"; very important!  Make that "sed -i s/dvips/pdftex/ Documents/Papers/InsightJournal2008/OpenIGTLinkIJ2008.tex".

The documentation in the -doc subpackage is still showing up in the main package, too.  I suspect the %doc macro is grabbing everything in the documentation directory.  I think what you want to do is explictly copy LICENSE.txt and README there in %install, then put this in %files:

%dir %{_docdir}/%{name}-%{version}
%{_docdir}/%{name}-%{version}/LICENSE.txt
%{_docdir}/%{name}-%{version}/README

and this in %files doc:

%{_docdir}/%{name}-%{version}/OpenIGTLinkIJ2008.pdf
%{_docdir}/%{name}-%{version}/html/

Or you could just give up, use %doc for both, and live with the documentation being in /usr/share/doc/libigtl-doc-%{version}/. :-)

That's all the major stuff left.  Otherwise, we're down to nitpicking.  First, notice that rpmlint is complaining about your spec file in a couple of ways.  Choose spaces or tabs for the fields at the top of the spec file, and then rerun rpmlint on your spec file when you are done to see if it has any other complaints.

Also, remove the %{?dist} tag from the Changelog entries.  Note that they are not part of the prescribed changelog format.

And speaking of nitpicking, you misspelled my first name in the comment above the sed expression in %prep.  I'm fine with you not giving credit, actually.  You could maybe make it read:

# Build documentation with pdflatex instead of latex + dvips.

Whatever you like. :-)

Comment 15 Mario Ceresa 2012-12-21 09:47:44 UTC
Thanks Jerry for your comments, this is the new version:

Spec URL: http://mrceresa.fedorapeople.org/libigtl.spec
SRPM URL: http://mrceresa.fedorapeople.org/libigtl-1.9.7-6.fc17.src.rpm

Builds in koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4810235

Comment 16 Jerry James 2012-12-21 19:07:15 UTC
That fixes everything.  This package is APPROVED.

Comment 17 Mario Ceresa 2012-12-22 10:09:08 UTC
Thanks Jerry for the review!

New Package SCM Request
=======================
Package Name: libigtl
Short Description: Network communication library for image-guided therapy
Owners: mrceresa
Branches: f17 f18 el6
InitialCC: peter

Comment 18 Gwyn Ciesla 2012-12-22 17:01:20 UTC
Git done (by process-git-requests).

Comment 19 Fedora Update System 2013-01-03 18:41:06 UTC
libigtl-1.9.7-6.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/libigtl-1.9.7-6.fc18

Comment 20 Fedora Update System 2013-01-03 18:42:27 UTC
libigtl-1.9.7-6.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/libigtl-1.9.7-6.fc17

Comment 21 Fedora Update System 2013-01-03 23:47:00 UTC
libigtl-1.9.7-6.fc18 has been pushed to the Fedora 18 testing repository.

Comment 22 Fedora Update System 2013-01-07 19:40:46 UTC
libigtl-1.9.7-7.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/libigtl-1.9.7-7.fc17

Comment 23 Fedora Update System 2013-01-07 19:40:59 UTC
libigtl-1.9.7-7.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/libigtl-1.9.7-7.fc18

Comment 24 Fedora Update System 2013-01-23 01:36:47 UTC
libigtl-1.9.7-7.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 25 Fedora Update System 2013-01-23 02:04:50 UTC
libigtl-1.9.7-7.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.