Bug 887971 – pvcreate fails if partition contains a swap signature

Bug 887971 - pvcreate fails if partition contains a swap signature

Summary:	pvcreate fails if partition contains a swap signature

Status:	CLOSED UPSTREAM

Aliases:	None

Product:	Virtualization Tools
Classification:	Community
Component:	libguestfs (Show other bugs)
Sub Component:
Version:	unspecified
Hardware:	Unspecified Unspecified

Priority	unspecified Severity unspecified
Target Milestone:	---
Target Release:	---
Assigned To:	Richard W.M. Jones
QA Contact:
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2012-12-17 12:38 EST by Richard W.M. Jones
Modified:	2012-12-21 04:16 EST (History)
CC List:	2 users (show)

See Also:
Fixed In Version:
Doc Type:	Bug Fix
Doc Text:
Story Points:	---
Clone Of:
Environment:
Last Closed:	2012-12-17 14:55:49 EST
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Groups: None (edit)

Description Richard W.M. Jones 2012-12-17 12:38:02 EST

Description of problem:

$ guestfish -N part mkswap /dev/sda1 : pvcreate /dev/sda1
libguestfs: error: pvcreate: WARNING: swap signature detected on /dev/sda1. Wipe it? [y/n] 
  Aborting pvcreate on /dev/sda1.

But note that other content is fine.  For example if the
partition contained an ext2 filesystem before, then pvcreate works:

$ guestfish -N part mkfs ext2 /dev/sda1 : pvcreate /dev/sda1
[no error]

Version-Release number of selected component (if applicable):

libguestfs 1.20.0

How reproducible:

100%

Steps to Reproduce:
See above.

Additional information:

For some reason this especially affects the test suite under
RHEL 7.  It may be that a combination of tests has been disabled,
such that when we come to test pvcreate there happens to be
a swap space signature on the partition.

Comment 1 Richard W.M. Jones 2012-12-17 14:55:49 EST

Fixed upstream in:
https://github.com/libguestfs/libguestfs/commit/8237ac89c5b51490f3f3c6f44d35ecaa184dca05

Comment 2 Richard W.M. Jones 2012-12-21 04:16:29 EST

With 1.20.1-2 package, this works.

Note You need to log in before you can comment on or make changes to this bug.