Bug 888056 - production.rb should not be marked as a conf file
Summary: production.rb should not be marked as a conf file
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Node
Version: 1.0.1
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
: ---
Assignee: Brenton Leanhardt
QA Contact: libra bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-12-17 22:43 UTC by Luke Meyer
Modified: 2017-03-08 17:34 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-01-31 20:33:40 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2013:0220 0 normal SHIPPED_LIVE Important: Red Hat OpenShift Enterprise 1.1 update 2013-02-01 01:23:24 UTC

Description Luke Meyer 2012-12-17 22:43:33 UTC
Description of problem:
In openshift-origin-broker.spec, see:
%config(noreplace) %{brokerdir}/config/environments/production.rb
As I understand it, this will keep future changes to production.rb from overwriting any changes the end user makes. I don't think this should be considered a config file. It may make sense for origin but for Enterprise, if someone has to mess around in there it's a bug. We don't want people to touch something in there, put it back, and then not receive any updates to it. Discuss.

Version-Release number of selected component (if applicable):
1.0.5-1 and prior

Comment 2 Brenton Leanhardt 2012-12-18 14:04:20 UTC
This is fixed in the next puddle.

http://download.devel.redhat.com/brewroot/packages/openshift-origin-broker/1.0.6/1.el6op/noarch/openshift-origin-broker-1.0.6-1.el6op.noarch.rpm

I think this is a fix we should upstream as well.

Comment 3 xjia 2012-12-19 08:57:37 UTC
If I misunderstand something, please let me know, thanks.

Test:
[root@broker ~]# rpm -qc openshift-origin-broker-1.0.6-1.el6op.noarch
/etc/httpd/conf.d/000000_openshift_origin_broker_proxy.conf
/etc/openshift/broker.conf
/var/www/openshift/broker/config/environments/development.rb
/var/www/openshift/broker/config/environments/production.rb

Version:
OpenShiftEnterprise/1.1.x/2012-12-18.1

Comment 4 xjia 2012-12-19 11:57:15 UTC
My fault, 
I verify it in a wrong mean. 
So move to "ON_QA" again.

Comment 5 xjia 2012-12-19 11:57:57 UTC
[root@broker ~]# cat  /var/www/openshift/broker/config/environments/production.rb  | grep whiny_nils
  config.whiny_nils = true
[root@broker ~]# vim /var/www/openshift/broker/config/environments/production.rb 
[root@broker ~]# cat  /var/www/openshift/broker/config/environments/production.rb  | grep whiny_nils
  config.whiny_nils = false 
[root@broker ~]# yum remove openshift-origin-broker
Loaded plugins: product-id, rhnplugin, security, subscription-manager
Updating certificate-based repositories.
Unable to read consumer identity
This system is receiving updates from RHN Classic or RHN Satellite.
Setting up Remove Process
Resolving Dependencies
--> Running transaction check
---> Package openshift-origin-broker.noarch 0:1.0.6-1.el6op will be erased
--> Finished Dependency Resolution

Dependencies Resolved

===============================================================================================================================================================================================================
 Package                                                 Arch                                   Version                                        Repository                                                 Size
===============================================================================================================================================================================================================
Removing:
 openshift-origin-broker                                 noarch                                 1.0.6-1.el6op                                  @openshift_infrastructure                                 141 k

Transaction Summary
===============================================================================================================================================================================================================
Remove        1 Package(s)

Installed size: 141 k
Is this ok [y/N]: y
Downloading Packages:
Running rpm_check_debug
Running Transaction Test
Transaction Test Succeeded
Running Transaction
  Erasing    : openshift-origin-broker-1.0.6-1.el6op.noarch                                                                                                                                                1/1 
warning: /var/www/openshift/broker/config/environments/production.rb saved as /var/www/openshift/broker/config/environments/production.rb.rpmsave
Installed products updated.
  Verifying  : openshift-origin-broker-1.0.6-1.el6op.noarch                                                                                                                                                1/1 

Removed:
  openshift-origin-broker.noarch 0:1.0.6-1.el6op                                                                                                                                                               

Complete!
[root@broker ~]# yum install openshift-origin-broker
Loaded plugins: product-id, rhnplugin, security, subscription-manager
Updating certificate-based repositories.
Unable to read consumer identity
This system is receiving updates from RHN Classic or RHN Satellite.
Setting up Install Process
Resolving Dependencies
--> Running transaction check
---> Package openshift-origin-broker.noarch 0:1.0.6-1.el6op will be installed
--> Finished Dependency Resolution

Dependencies Resolved

===============================================================================================================================================================================================================
 Package                                                 Arch                                   Version                                         Repository                                                Size
===============================================================================================================================================================================================================
Installing:
 openshift-origin-broker                                 noarch                                 1.0.6-1.el6op                                   openshift_infrastructure                                  68 k

Transaction Summary
===============================================================================================================================================================================================================
Install       1 Package(s)

Total download size: 68 k
Installed size: 141 k
Is this ok [y/N]: y
Downloading Packages:
openshift-origin-broker-1.0.6-1.el6op.noarch.rpm                                                                                                                                        |  68 kB     00:00     
Running rpm_check_debug
Running Transaction Test
Transaction Test Succeeded
Running Transaction
  Installing : openshift-origin-broker-1.0.6-1.el6op.noarch                                                                                                                                                1/1 
Installed products updated.
  Verifying  : openshift-origin-broker-1.0.6-1.el6op.noarch                                                                                                                                                1/1 

Installed:
  openshift-origin-broker.noarch 0:1.0.6-1.el6op                                                                                                                                                               

Complete!
[root@broker ~]# cat  /var/www/openshift/broker/config/environments/production.rb  | grep whiny_nils
  config.whiny_nils = true
[root@broker ~]# cat  /var/www/openshift/broker/config/environments/production.rb.rpmsave  | grep whiny_nils
  config.whiny_nils = false 


Verify:

OpenShiftEnterprise/1.1.x/2012-12-18.1

Comment 6 Brenton Leanhardt 2012-12-19 13:01:01 UTC
I would have been more clear.  The issue wasn't that the production.rb was labeled as a conf file but rather that it was label 'noreplace'.  By labeling as a config file if a user has made modifications they will at least be backed up if they perform and upgrade.

Comment 8 errata-xmlrpc 2013-01-31 20:33:40 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2013-0220.html


Note You need to log in before you can comment on or make changes to this bug.