Bug 888059 – guestfs_inspect_os() fails with Win7 image with registry in "non-pristine" state

Bug 888059 - guestfs_inspect_os() fails with Win7 image with registry in "non-pristine" state

Summary:	guestfs_inspect_os() fails with Win7 image with registry in "non-pristine" state

Status:	CLOSED UPSTREAM

Aliases:	None

Product:	Virtualization Tools
Classification:	Community
Component:	libguestfs (Show other bugs)
Sub Component:
Version:	unspecified
Hardware:	x86_64 Unspecified

Priority	unspecified Severity unspecified
Target Milestone:	---
Target Release:	---
Assigned To:	Richard W.M. Jones
QA Contact:
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2012-12-17 17:56 EST by skippyvondrake
Modified:	2012-12-18 03:14 EST (History)
CC List:	2 users (show)

See Also:
Fixed In Version:
Doc Type:	Bug Fix
Doc Text:
Story Points:	---
Clone Of:
Environment:
Last Closed:	2012-12-18 03:14:51 EST
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
see "Additional info" above for steps taken to create debug log. (37.49 MB, text/plain) 2012-12-17 17:56 EST, skippyvondrake	no flags	Details
Add an attachment (proposed patch, testcase, etc.)

Groups: None (edit)

Description skippyvondrake 2012-12-17 17:56:39 EST

Created attachment 665162 [details]
see "Additional info" above for steps taken to create debug log.

Description of problem:
Windows 7 image can be booted in Xen, but upon startup (in Xen) a "Registry Recovery... recovery was successful" message appears. The libguestfs cannot digest such "impure" registry entries.

Version-Release number of selected component (if applicable):1.19.61


How reproducible: Very - with my specific image. I may be able to provide it. (about 20GB).


Steps to Reproduce:
1. load image with guestfs and call guestfs_inspect_os()
2.
3.
  
Actual results:
guestfs_inspect_os fails.

Expected results:
guestfs_inspect_os not fail?

Additional info:
The debug info provide was obtained using 'guestfs_set_verbose(g,1)' in the application code. AND by hardcoding the "flags" in hivex.c, function 'do_hivex_open()' of the libguestfs sources (1.19.61). Flags is set to include HIVEX_OPEN_VERBOSE and HIVEX_OPEN_DEBUG.

Comment 1 Richard W.M. Jones 2012-12-18 03:14:51 EST

The registry is faulty:
hivex: /sysroot/Windows/System32/config/SOFTWARE: trailing garbage at end of file (at 0x245b000, after 8557 pages)

The problem with libguestfs failing when presented with
a bad registry has already been fixed.
https://github.com/libguestfs/libguestfs/commit/95df8a7c0cedb0daf8f5318fbeb931f6a67e6286

Note You need to log in before you can comment on or make changes to this bug.