Description of problem: Set /boot to RAID device with optimization (i.e. RAID 0). The following was filed automatically by anaconda: anaconda 18.37.3 exception report Traceback (most recent call first): File "/usr/lib64/python2.7/site-packages/pyanaconda/storage/devices.py", line 2667, in __init__ {"raidLevel": self.level, "minMembers": mdraid.get_raid_min_members(self.level)} File "/usr/lib64/python2.7/site-packages/pyanaconda/storage/__init__.py", line 1068, in newMDArray return MDRaidArrayDevice(name, *args, **kwargs) File "/usr/lib64/python2.7/site-packages/pyanaconda/storage/__init__.py", line 3324, in new_device return getattr(self.storage, self.new_device_attr)(*args, **kwargs) File "/usr/lib64/python2.7/site-packages/pyanaconda/storage/__init__.py", line 3509, in new_device return super(MDFactory, self).new_device(*args, **kwargs) File "/usr/lib64/python2.7/site-packages/pyanaconda/storage/__init__.py", line 2283, in newDevice **kwa) File "/usr/lib64/python2.7/site-packages/pyanaconda/ui/gui/spokes/custom.py", line 866, in _replace_device self.__storage.newDevice(*args, **kwargs) File "/usr/lib64/python2.7/site-packages/pyanaconda/ui/gui/spokes/custom.py", line 1084, in _save_right_side selector=selector) File "/usr/lib64/python2.7/site-packages/pyanaconda/ui/gui/spokes/custom.py", line 2120, in on_selector_clicked self._save_right_side(self._current_selector) File "/usr/lib64/python2.7/site-packages/pyanaconda/ui/gui/spokes/lib/accordion.py", line 195, in _onSelectorClicked cb(selector) ValueError: A RAID0 set requires at least 2 members Additional info: cmdline: /usr/bin/python /sbin/anaconda --liveinst --method=livecd:///dev/mapper/live-osimg-min --lang en_US.UTF-8 cmdline_file: initrd=initrd0.img root=live:CDLABEL=Fedora-18-TC3-x86_64-Live-Deskto rootfstype=auto ro rd.live.image quiet rhgb rd.luks=0 rd.md=0 rd.dm=0 BOOT_IMAGE=vmlinuz0 executable: /sbin/anaconda hashmarkername: anaconda kernel: 3.6.10-4.fc18.x86_64 other involved packages: package: anaconda-18.37.3-1.fc18.x86_64 packaging.log: product: Fedora release: Fedora release 18 (Spherical Cow) type: libreport version: 18
Created attachment 665206 [details] File: anaconda-tb
Created attachment 665207 [details] File: anaconda.log
Created attachment 665208 [details] File: environ
Created attachment 665209 [details] File: ifcfg.log
Created attachment 665210 [details] File: messages
Created attachment 665211 [details] File: program.log
Created attachment 665212 [details] File: storage.log
Steps to reproduce: 1. Two new virtual disks. 2. Launch installer > Installation Destination > Choose both disks. 3. Choose "customize the partitioning" checkbox to go to Manual Partitioning. 4. Manual Partitioning, click "click here to create them automatically" 5. Boot is already selected, click on Customize > Device Type set to RAID. 6. Click on Root Results: Crash Expected: a.) Don't let me do invalid things; or b.) don't crash. Regression: If I do it this way, it works (doesn't crash, installs, and boots.) 1. click on swap, set to standard partitioning, apply changes. 2. click on root, set to RAID0, apply changes. 3. click on boot, set to RAID0, apply changes. Additional info: Proposing as blocker: F18 Beta Release Criterion #11: must be able to install to RAID-0 *except* for /boot. i.e. it is obviously an invalid operation. F18 Beta Release Criterion #10: Installer should... Reject obviously invalid operations without crashing.
The device is switched to md, but one of the two disks has no free space so it fails. We need to catch this exception so it can be handled cleanly.
Sounds like another bug because both disks have only free space, not partitioned, and are identical in size.
Discussed at 2012-12-19 blocker review meeting: http://meetbot.fedoraproject.org/fedora-bugzappers/2012-12-19/f18final-blocker-review-6.2012-12-19-17.02.log.txt . Accepted as a blocker per criterion "The installer's custom partitioning mode must be capable of the following ... Rejecting obviously invalid operations without crashing".
So, the patch looks to have been acked: https://lists.fedorahosted.org/pipermail/anaconda-patches/2012-December/002581.html but never pushed to f18-branch: http://git.fedorahosted.org/cgit/anaconda.git/log/?h=f18-branch I don't see it there. David, Brian, why the hold-up in pushing this? Can it please get pushed? Thanks.
That patch referred to the wrong bz#. It was pushed with the right one, bug 885378
(In reply to comment #13) > That patch referred to the wrong bz#. It was pushed with the right one, bug > 885378 Well, this looks like a correct one - https://lists.fedorahosted.org/pipermail/anaconda-patches/2012-December/002578.html and got acked (ValueError to DeviceError to catch the exception as mentioned above in comment #9), the one you refer to is [PATCH 2/3].
Created attachment 671770 [details] anaconda-tb-qjilrm Still get a crash with 18.38.8-1, libreport says it's a dup of this bug. Attaching a current anaconda-tb.
So per IRC discussion yesterday, this just needed the correct patch to be cherry picked from master to f18-branch. Has someone done that yet?
Yes. It was cherry-picked and pushed earlier today.
anaconda-18.37.9-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/anaconda-18.37.9-1.fc18
anaconda-18.37.9-1.fc18 fixes this bug.
Package anaconda-18.37.9-1.fc18: * should fix your issue, * was pushed to the Fedora 18 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing anaconda-18.37.9-1.fc18' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-0206/anaconda-18.37.9-1.fc18 then log in and leave karma (feedback).
anaconda-18.37.10-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/anaconda-18.37.10-1.fc18
anaconda-18.37.11-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/anaconda-18.37.11-1.fc18
Still fixed in anaconda-18.37.11-1.fc18.
anaconda-18.37.11-1.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report.