Bug 888112 - Yellow error display bar is incapable of wrapping long errors, they are too wide and overflow the side of the screen
Summary: Yellow error display bar is incapable of wrapping long errors, they are too w...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: anaconda
Version: 18
Hardware: All
OS: All
unspecified
medium
Target Milestone: ---
Assignee: Chris Lumens
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: AcceptedNTH
Depends On:
Blocks: F18-accepted, F18FinalFreezeExcept
TreeView+ depends on / blocked
 
Reported: 2012-12-18 02:19 UTC by Adam Williamson
Modified: 2012-12-20 05:35 UTC (History)
4 users (show)

Fixed In Version: anaconda-18.37.4-1
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-12-20 05:35:40 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Adam Williamson 2012-12-18 02:19:50 UTC
newUI seems to have a sort of generic way of handling various error messages - they are displayed in a yellow bar at the bottom of the screen.

This does not seem to be capable of line wrapping. Any time an error message is too wide for the screen, it doesn't get wrapped, it just flows off the side of the screen. You can't read the end of it. And it also seems to screw up the display of the 'FEDORA 18-TC3 INSTALLATION PRE-RELEASE / TESTING' text at top right - until the error message goes away, that is rendered off the side of the screen too.

I've seen this with the new hostname setting code - the error message that starts "Hostname is not valid: Hostnames can only contain the characters 'a-z', 'A-Z', '0-9', '-' or '.', parts between periods must contain something and cannot start or end..." is too wide for a 1024x768 display (overflows at that point), and also with the root password setting code (the error about a password being based on a dictionary word is too wide and also overflows). I don't think the sensible response is 'make sure any error message anaconda can possibly display fits on a single line at 640x480' or anything like that, surely it makes more sense to allow them to wrap?

Comment 1 Adam Williamson 2012-12-18 02:21:02 UTC
Proposing as NTH, obviously we want people to be able to actually read the errors we're displaying, though they probably get the gist as things stand.

Comment 2 Adam Williamson 2012-12-18 22:48:03 UTC
So I suppose with the proposed fix for this (enabling wrap) we need to be on the look out for absurdly long errors that might flow over the whole screen or something. Perhaps there should be some kind of sanity cap on total length?

Comment 3 Fedora Update System 2012-12-19 01:34:25 UTC
anaconda-18.37.4-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/anaconda-18.37.4-1.fc18

Comment 4 Adam Williamson 2012-12-19 08:22:33 UTC
Confirmed in smoke8 (tested using the 'password is based on a dictionary word' root PW set error, in French - in English it just fits on one line at 1024x768, in French it goes over). Wrapped nicely onto a second line, no apparent ill effects.

Comment 5 Adam Williamson 2012-12-19 19:31:32 UTC
Discussed at 2012-12-19 NTH review meeting: http://meetbot.fedoraproject.org/fedora-bugzappers/2012-12-19/f18final-blocker-review-6.2012-12-19-17.02.log.txt . Accepted as NTH, it's a reasonably safe change and obviously it's important that people be able to read error messages.

Comment 6 Fedora Update System 2012-12-20 05:35:45 UTC
anaconda-18.37.4-1.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.