Bug 888560 - crash after encrypting a preexisting lv
Summary: crash after encrypting a preexisting lv
Alias: None
Product: Fedora
Classification: Fedora
Component: anaconda
Version: 18
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: David Lehman
QA Contact: Fedora Extras Quality Assurance
Whiteboard: AcceptedNTH
Depends On:
Blocks: F18Blocker, F18FinalBlocker F18-accepted, F18FinalFreezeExcept
TreeView+ depends on / blocked
Reported: 2012-12-18 21:33 UTC by David Lehman
Modified: 2012-12-21 09:40 UTC (History)
9 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2012-12-21 09:40:12 UTC
Type: Bug

Attachments (Terms of Use)
crash report (365.09 KB, application/octet-stream)
2012-12-18 21:33 UTC, David Lehman
no flags Details

Description David Lehman 2012-12-18 21:33:04 UTC
Created attachment 665771 [details]
crash report

Description of problem:
If you mark a preexisting (unencrypted) lv for reformat including encryption, you get asked for a passphrase but the passphrase doesn't get set in the device object, causing a traceback at activation time.

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. start with an existing unencrypted lv
2. mark it for reformat and encryption in the custom spoke
3. continue with installation
Actual results:
crash as detailed below

Expected results:
no crash

Additional info:
anaconda 18.37.2 exception report
Traceback (most recent call first):
  File "/usr/lib64/python2.7/site-packages/pyanaconda/storage/formats/luks.py", line 189, in create
    raise LUKSError("luks device has no key/passphrase")
  File "/usr/lib64/python2.7/site-packages/pyanaconda/storage/deviceaction.py", line 439, in execute
  File "/usr/lib64/python2.7/site-packages/pyanaconda/storage/devicetree.py", line 323, in processActions
  File "/usr/lib64/python2.7/site-packages/pyanaconda/storage/__init__.py", line 336, in doIt
  File "/usr/lib64/python2.7/site-packages/pyanaconda/storage/__init__.py", line 174, in turnOnFilesystems
  File "/usr/lib64/python2.7/site-packages/pyanaconda/install.py", line 114, in doInstall
  File "/usr/lib64/python2.7/threading.py", line 504, in run
    self.__target(*self.__args, **self.__kwargs)
  File "/usr/lib64/python2.7/site-packages/pyanaconda/threads.py", line 91, in run
    threading.Thread.run(self, *args, **kwargs)
LUKSError: luks device has no key/passphrase

Comment 1 David Lehman 2012-12-18 21:34:02 UTC
I have a working patch here.

Comment 2 Adam Williamson 2012-12-19 00:30:16 UTC
at least +1 nth, probably +1 blocker (per the 'do any partitioning you like' criterion)

Comment 3 Kevin Fenzi 2012-12-19 00:36:07 UTC
definitely +1 nth, weak +1 blocker...

Comment 4 Adam Williamson 2012-12-19 00:52:37 UTC
So doing a slightly fuzzy count as we're firing off an anaconda build here and it'd be a shame to miss this - that's +1 from dlehman (anaconda), +1 from nirik (releng) and +1 from me (qa), so accepted NTH at least.

Comment 5 Fedora Update System 2012-12-19 01:33:41 UTC
anaconda-18.37.4-1.fc18 has been submitted as an update for Fedora 18.

Comment 6 Fedora Update System 2012-12-19 22:39:57 UTC
Package anaconda-18.37.4-1.fc18:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing anaconda-18.37.4-1.fc18'
as soon as you are able to.
Please go to the following url:
then log in and leave karma (feedback).

Comment 7 Fedora Update System 2012-12-20 05:34:04 UTC
anaconda-18.37.4-1.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 8 Kamil Páral 2012-12-21 09:40:12 UTC
Petr verified, closing again.

Note You need to log in before you can comment on or make changes to this bug.