Bug 888728 - polkitd: memory leak in process_policy_file()
Summary: polkitd: memory leak in process_policy_file()
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: polkit
Version: 18
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Miloslav Trmač
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 888729
TreeView+ depends on / blocked
 
Reported: 2012-12-19 10:55 UTC by Florian Weimer
Modified: 2013-04-13 01:30 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2013-04-13 01:29:05 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
FreeDesktop.org 63492 0 None None None Never

Description Florian Weimer 2012-12-19 10:55:42 UTC
In src/polkitbackend/polkitbackendactionpool.c, function process_policy_file(), there is this code:

  pd.parser = XML_ParserCreate_MM (NULL, NULL, NULL);
  pd.parser = XML_ParserCreate (NULL);

I think this leaks the parser allocated by XML_ParserCreate_MM().

The parser runs with entity expansion enabled, but this doesn't appear to be a problem because the input file is trusted.

Comment 1 Fedora Admin XMLRPC Client 2013-02-01 23:59:39 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 2 Miloslav Trmač 2013-04-13 01:29:05 UTC
Thanks for your report.  Fix filed upstream at https://bugs.freedesktop.org/show_bug.cgi?id=63492 .  This can only be triggered by the system administrator manipulating /usr/share/polkit-1/actions, so not a vulnerability, and we'll get the fix on next upstream release (which is probably soon).


Note You need to log in before you can comment on or make changes to this bug.