Bug 889167 - Review Request: netatalk-3.0.1
Summary: Review Request: netatalk-3.0.1
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: 17
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-12-20 12:04 UTC by Petr Hosek
Modified: 2013-05-11 07:52 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-05-11 07:52:14 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Petr Hosek 2012-12-20 12:04:11 UTC
Spec URL: http://www.doc.ic.ac.uk/~ph1310/netatalk.spec
SRPM URL: http://www.doc.ic.ac.uk/~ph1310/netatalk-3.0.1-1.fc17.src.rpm
Description:

There is already a package available for netatalk-2.2.x, but version 3.x brought some significant improvements such as new metadata database (i.e. no more .AppleDB directories) and completely new simpler configuration. That's why I've prepared the package for the new version based on the original package, but reflecting the the changes.

Since this is my first package, I need a sponsor. Any help in that regard would be much appreciated.

Comment 1 Mario Blättermann 2012-12-20 18:30:52 UTC
(In reply to comment #0)
> There is already a package available for netatalk-2.2.x, but version 3.x
> brought some significant improvements such as new metadata database (i.e. no
> more .AppleDB directories) and completely new simpler configuration. That's
> why I've prepared the package for the new version based on the original
> package, but reflecting the the changes.

Netatalk needs to be updated only. This means, you have to file a bug report against that package.

Could be that the v3.x breaks some things, don't know. In this case, a new package named "netatalk3" could be built, but this must not conflict with the current one. In any case, it must not become an update, rather a completely independent one which is parallel installable besides v2.2.

Comment 2 HAT 2013-01-11 19:24:21 UTC
(In reply to comment #1)
> Could be that the v3.x breaks some things, don't know. In this case, a new
> package named "netatalk3" could be built, but this must not conflict with
> the current one. In any case, it must not become an update, rather a
> completely independent one which is parallel installable besides v2.2.

netatalk 2.x and 3.x never live together.
When netatalk3 mount netatalk2's volume, it is converted automatically.

Comment 3 HAT 2013-01-11 19:25:56 UTC
(In reply to comment #0)
> Since this is my first package, I need a sponsor. Any help in that regard
> would be much appreciated.

Hi,
I made two SRPMs based on your SRPM.
http://www003.upp.so-net.ne.jp/hat/files/netatalk-3.0.1-1.1.fc17.src.rpm
http://www003.upp.so-net.ne.jp/hat/files/netatalk-3.0.1-2.1.fc18.src.rpm
These differ in spec file.

1) Update "Summary", "%description" and "%description devel". AppleTalk is obsoleted.

2) BuildRequires libdb-devel. db4-devel is an old package for compatibility. See Bug 859118.
   https://bugzilla.redhat.com/show_bug.cgi?id=859118

3) Add netatalk-3.0.1-basedir.patch. In case of Fedora, basedir is /home.

4) Copy afp.conf, not afp.conf.tmpl.
   afp.conf.tmpl is a source file for generating afp.conf.
   Don't copy afp.conf.tmpl to /usr/share/doc because it may contain macro in the future.

5) merge netatalk-2.2.3-6 spec file.
   http://pkgs.fedoraproject.org/cgit/netatalk.git/commit/?h=f18&id=39e3953a75aeeda738039845b0e827e805ca0114

6) Scriptlets differ in F17 and F18.
   https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd

7) move afp_signature.conf and afp_voluuid.conf into /var/netatalk/ .
   http://netatalk.sourceforge.net/3.0/htmldocs/upgrade.html


TODO:
netatalk 3.0.2 will have new conffile "/etc/extmap.conf"

Comment 4 Mario Blättermann 2013-01-11 20:40:41 UTC
(In reply to comment #2)
> netatalk 2.x and 3.x never live together.
> When netatalk3 mount netatalk2's volume, it is converted automatically.

That's why it doesn't make sense to continue working on this review request. Just file a bug against the existing package if you want to get it updated.

Comment 5 Bob Gustafson 2013-01-29 23:06:19 UTC
I just built netatalk 3.0.2 from the SRPM.

It builds and installs and seems to run (not configured correctly yet by me).

The netatalk.service file is not copied to the /etc/systemd/system directory.

Also, the /etc/netatalk directory is not created or populated with sample files.

Comment 6 HAT 2013-01-30 10:56:52 UTC
The netatalk.service file is copied to the /usr/lib/systemd/system.
When doing "systemctl enable netatalk", symlink will be created in /etc/systemd/system/multi-user.target.wants.

The configuration file is /etc/afp.conf.
The sample files are in /usr/share/doc/netatalk-3.0.2/config.example.

The /etc/netatalk directory is not used any longer.
http://netatalk.sourceforge.net/3.0/htmldocs/upgrade.html#idp5720640

BTW, official rpm is not updated these days. Is Filip Kocina busy?

Comment 7 Bob Gustafson 2013-01-31 01:22:03 UTC
I'm working through the conf's and setup.

I can log into the netatalk machine from a remote Leopard Mac. But cannot transfer files as yet. Patience.

However, I did see a Seg Fault

[bobg@hoho0 ~]$ ad ls
Jan 30 19:19:33.975314 ad[2557] {netatalk_conf.c:1491} (E:Default): getvolbypath("/home/bobg/."): no volume for path
macdata  
Segmentation fault (core dumped)
[bobg@hoho0 ~]$

Comment 8 Bob Gustafson 2013-01-31 02:03:16 UTC
Odd - I thought I logged in as 'bobg'

[bobg@hoho0 ~]$ macusers
PID      UID      Username         Name                 Logintime Mac
749      0        root             root                 13:05     
[bobg@hoho0 ~]$

Comment 9 HAT 2013-01-31 10:34:22 UTC
You should post to netatalk's ML or site.
https://lists.sourceforge.net/lists/listinfo/netatalk-admins
http://sourceforge.net/p/netatalk/bugs/

Comment 10 Mario Blättermann 2013-05-11 07:52:14 UTC
This is not the place to discuss about bugs in Netatalk. Please file a bug against the netatalk package to get a new program version and to get bugs fixed.


Note You need to log in before you can comment on or make changes to this bug.