Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-PHPParser.spec SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-PHPParser-0.9.3-1.fc17.src.rpm Description: A PHP parser written in PHP to simplify static analysis and code manipulation. Fedora Account System Username: siwinski
Created attachment 670362 [details] phpci.log
Created attachment 670363 [details] php-PHPParser-review.txt Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16 Buildroot used: fedora-17-x86_64 Command line :/usr/bin/fedora-review -b 889400
[!]: Requires correct, justified where necessary. php(language) only available on fedora min PHP version is 5.3.0 (phpci) xmlreader and xmlwriter are provided by php-xml So: %if 0%{?fedora} Requires: php(language) >= 5.3.0 Requires: php-filter Requires: php-xmlreader Requires: php-xmlwriter %else Requires: php-common >= 5.3.0 Requires: php-xml %endif And, same change for BR.
(In reply to comment #3) Sorry for the delay. I made the updates a little while ago but never updated this review with the information. I chose to just use php-common for both Fedora and non-Fedora. Changelog: - Added php_min_ver - Fixed requires for php_min_ver and non-Fedora Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-PHPParser.spec SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-PHPParser-0.9.3-2.fc17.src.rpm
Requires fixed No blocker === APPROVED ===
THANKS for the review! New Package SCM Request ======================= Package Name: php-PHPParser Short Description: A PHP parser written in PHP Owners: siwinski Branches: f17 f18 el6 InitialCC:
Git done (by process-git-requests).
php-PHPParser-0.9.3-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-PHPParser-0.9.3-2.fc18
php-PHPParser-0.9.3-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-PHPParser-0.9.3-2.el6
php-PHPParser-0.9.3-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/php-PHPParser-0.9.3-2.fc17
php-PHPParser-0.9.3-2.fc18 has been pushed to the Fedora 18 testing repository.
php-PHPParser-0.9.3-2.fc17 has been pushed to the Fedora 17 stable repository.
php-PHPParser-0.9.3-2.fc18 has been pushed to the Fedora 18 stable repository.
php-PHPParser-0.9.3-2.el6 has been pushed to the Fedora EPEL 6 stable repository.