Red Hat Bugzilla – Bug 889411
Red border indicating failed validation shows on strings without validation warning/error
Last modified: 2013-02-25 23:06:24 EST
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20100101 Firefox/17.0
Some strings, as soon as I save them, do get a red border even though there is no validation warning or error in those strings.
Reproducible: Didn't try
Steps to Reproduce:
Not sure if reproducable any certain way. Happens occasionally, haven't found a pattern yet.
Red border on strings without error
No red border
I've fixed something in below commit before this bug is reported. But doesn't seem to be the cause after I review it.
How to reproduce the error:
1. select a row that source string is capable of producing validation error. i.e. having %s variables in it.
2. go to next page
next page entries will be validated correctly
it will validate next page's target strings against previously selected source on previous page. This will cause wrong validation warning border to appear.
found the problem:
Steps to Reproduce (depend on timing):
1. find a document and select plain text entry with next entry that has something will trigger validation error. i.e. contains line break or %s variables.
2. translation the plain text entry and input just plain text (should not have validation error)
3. save as approved
Selection moved to next row but red border appear in saving entry but no validation error.
Move to next row happens in order. Source is selected first and then target. Seems like validation request is happening in between so source will point to next row but target is still in previous row. And it generates false warning.
committed into master:
Ensure source and target id equality in validation.
This bug is more likely to happen with plain text area as editor. Since we use a timer to fire value change event.
VERIFIED with Zanata version 2.1-SNAPSHOT (20130107-1432)