Bug 889757 - gftp seg faults if you navigate to a parent directory during a download
Summary: gftp seg faults if you navigate to a parent directory during a download
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: gftp
Version: 24
Hardware: x86_64
OS: Linux
medium
high
Target Milestone: ---
Assignee: Itamar Reis Peixoto
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: abrt_hash:7ff10680cb4a30fdf68f67d2623...
: 850545 1387829 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-12-23 10:47 UTC by unix63
Modified: 2017-08-08 11:41 UTC (History)
8 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-08-08 11:41:30 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
File: backtrace (31.56 KB, text/plain)
2012-12-23 10:47 UTC, unix63
no flags Details
File: cgroup (129 bytes, text/plain)
2012-12-23 10:47 UTC, unix63
no flags Details
File: core_backtrace (2.88 KB, text/plain)
2012-12-23 10:48 UTC, unix63
no flags Details
File: dso_list (9.08 KB, text/plain)
2012-12-23 10:48 UTC, unix63
no flags Details
File: environ (1.56 KB, text/plain)
2012-12-23 10:48 UTC, unix63
no flags Details
File: limits (1.29 KB, text/plain)
2012-12-23 10:48 UTC, unix63
no flags Details
File: maps (47.98 KB, text/plain)
2012-12-23 10:48 UTC, unix63
no flags Details
File: open_fds (598 bytes, text/plain)
2012-12-23 10:48 UTC, unix63
no flags Details
File: proc_pid_status (923 bytes, text/plain)
2012-12-23 10:48 UTC, unix63
no flags Details
File: var_log_messages (299 bytes, text/plain)
2012-12-23 10:48 UTC, unix63
no flags Details
Patch that might fix the problem (711 bytes, patch)
2014-02-04 16:15 UTC, Steve Grubb
no flags Details | Diff

Description unix63 2012-12-23 10:47:52 UTC
Description of problem:
double clicked to go up one directory in the remote site window.

Version-Release number of selected component:
gftp-2.0.19-8.fc18

Additional info:
backtrace_rating: 4
cmdline:        /usr/bin/gftp-gtk
crash_function: gftp_expand_path
executable:     /usr/bin/gftp-gtk
kernel:         3.6.11-3.fc18.x86_64
remote_result:  659487
uid:            1000

Truncated backtrace:
Thread no. 1 (10 frames)
 #0 gftp_expand_path at misc.c:149
 #1 gftpui_run_chdir at gtkui.c:421
 #2 list_doaction at gftp-gtk.c:685
 #6 gtk_signal_emit at gtksignal.c:360
 #7 gtk_clist_button_press at gtkclist.c:4987
 #8 _gtk_marshal_BOOLEAN__BOXED at gtkmarshalers.c:86
 #13 gtk_widget_event_internal at gtkwidget.c:5017
 #14 gtk_widget_event at gtkwidget.c:4814
 #15 gtk_propagate_event at gtkmain.c:2490
 #16 gtk_main_do_event at gtkmain.c:1685

Potential duplicate: bug 704138

Comment 1 unix63 2012-12-23 10:47:57 UTC
Created attachment 667953 [details]
File: backtrace

Comment 2 unix63 2012-12-23 10:47:59 UTC
Created attachment 667954 [details]
File: cgroup

Comment 3 unix63 2012-12-23 10:48:01 UTC
Created attachment 667955 [details]
File: core_backtrace

Comment 4 unix63 2012-12-23 10:48:03 UTC
Created attachment 667956 [details]
File: dso_list

Comment 5 unix63 2012-12-23 10:48:05 UTC
Created attachment 667957 [details]
File: environ

Comment 6 unix63 2012-12-23 10:48:07 UTC
Created attachment 667958 [details]
File: limits

Comment 7 unix63 2012-12-23 10:48:12 UTC
Created attachment 667959 [details]
File: maps

Comment 8 unix63 2012-12-23 10:48:14 UTC
Created attachment 667960 [details]
File: open_fds

Comment 9 unix63 2012-12-23 10:48:16 UTC
Created attachment 667961 [details]
File: proc_pid_status

Comment 10 unix63 2012-12-23 10:48:18 UTC
Created attachment 667962 [details]
File: var_log_messages

Comment 11 Fedora End Of Life 2013-12-21 10:03:36 UTC
This message is a reminder that Fedora 18 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 18. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '18'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 18's end of life.

Thank you for reporting this issue and we are sorry that we may not be 
able to fix it before Fedora 18 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior to Fedora 18's end of life.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 12 Steve Grubb 2014-02-04 15:46:39 UTC
Changing this to F20 because I just got a recurrence using gftp-2.0.19-10.fc20.x86_64.

Comment 13 Steve Grubb 2014-02-04 16:15:28 UTC
Created attachment 859228 [details]
Patch that might fix the problem

Just looking at the evidence, it looks like a NULL is being passed down and dereferenced without checking. It can possibly come from gftp_build_path() which can return NULL on error. So, the patch checks for this and avoids the whole call chain in that event. Not 100% sure this is the problem, but I am testing a new build with the patch in place.

Comment 14 Joel Uckelman 2014-02-10 14:04:39 UTC
*** Bug 850545 has been marked as a duplicate of this bug. ***

Comment 15 Joel Uckelman 2014-02-10 14:05:38 UTC
Check Bug 850545 for how to reproduce this problem.

Comment 16 Joe Zeff 2014-09-24 04:54:27 UTC
Another user experienced a similar problem:

I had transferred some files from my desktop to my laptop.  When I double-clicked on a folder to select it and get another file, the program crashed.

reporter:       libreport-2.2.3
backtrace_rating: 4
cmdline:        /usr/bin/gftp-gtk
crash_function: gftp_expand_path
executable:     /usr/bin/gftp-gtk
kernel:         3.16.2-200.fc20.i686+PAE
package:        gftp-2.0.19-10.fc20
reason:         gftp-gtk killed by SIGSEGV
runlevel:       N 5
type:           CCpp
uid:            1000

Comment 17 Fedora End Of Life 2015-05-29 08:50:02 UTC
This message is a reminder that Fedora 20 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 20. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '20'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 20 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 18 Fedora End Of Life 2015-06-29 11:43:24 UTC
Fedora 20 changed to end-of-life (EOL) status on 2015-06-23. Fedora 20 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 19 Joel Uckelman 2015-06-29 12:03:54 UTC
This bug sill occurs in gftp-2.0.19-12.fc22.x86_64.

The bug is always reproducible as follows:

1. Start downloading a directory via FTP.
2. Navigate up to the parent directory while the download is in progress.

This problem goes all the way back to Fedora 14.

Comment 20 Persona non grata 2015-12-10 18:22:10 UTC
Another user experienced a similar problem:

While uploading a 800MB file, tried to go up from the root directory (which wouldn't be possible) on the remote server.

I was expecting "nothing" (stay at root) or an error message telling me that I cannot go up the folder hierarchy.

gFTP just crashed.

reporter:       libreport-2.6.3
backtrace_rating: 4
cmdline:        /usr/bin/gftp-gtk
crash_function: gftp_expand_path
executable:     /usr/bin/gftp-gtk
global_pid:     28321
kernel:         4.2.6-201.fc22.x86_64
package:        gftp-2.0.19-12.fc22
reason:         gftp-gtk killed by SIGSEGV
runlevel:       N 5
type:           CCpp
uid:            1000

Comment 21 Fedora End Of Life 2016-07-19 20:24:52 UTC
Fedora 22 changed to end-of-life (EOL) status on 2016-07-19. Fedora 22 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 22 Joel Uckelman 2016-07-29 11:36:40 UTC
The problem still occurs with gftp-2.0.19-14.fc24.x86_64 in F24. Reopening.

Comment 23 Nicholas Youell 2016-10-22 09:58:15 UTC
*** Bug 1387829 has been marked as a duplicate of this bug. ***

Comment 24 Fedora End Of Life 2017-07-25 18:31:29 UTC
This message is a reminder that Fedora 24 is nearing its end of life.
Approximately 2 (two) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 24. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '24'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 24 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 25 Fedora End Of Life 2017-08-08 11:41:30 UTC
Fedora 24 changed to end-of-life (EOL) status on 2017-08-08. Fedora 24 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.