Bug 890344 - spacewalk-service enable|disable relies on service scripts with potentially flawed dependancies.
Summary: spacewalk-service enable|disable relies on service scripts with potentially f...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Spacewalk
Classification: Community
Component: Server
Version: 1.8
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Stephen Herr
QA Contact: Red Hat Satellite QA List
URL:
Whiteboard:
Depends On:
Blocks: space19
TreeView+ depends on / blocked
 
Reported: 2012-12-26 14:54 UTC by William Brown
Modified: 2013-03-06 18:34 UTC (History)
0 users

Fixed In Version: spacewalk-java-1.9.36-1
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-03-06 18:34:46 UTC
Embargoed:


Attachments (Terms of Use)
Cobbler patch (492 bytes, patch)
2013-01-02 20:23 UTC, Stephen Herr
no flags Details | Diff

Description William Brown 2012-12-26 14:54:07 UTC
/var/log/messages contains:


Dec 27 01:17:28 spacewalk systemd[1]: Reloading.
Dec 27 01:17:28 spacewalk systemd[1]: [/etc/rc.d/init.d/cobblerd:10] Failed to add dependency on network,.service, ignoring: Invalid argument
Dec 27 01:17:28 spacewalk systemd[1]: [/etc/rc.d/init.d/cobblerd:10] Failed to add dependency on xinetd,.service, ignoring: Invalid argument
Dec 27 01:17:28 spacewalk systemd[1]: [/etc/rc.d/init.d/taskomatic:11] Failed to translate LSB dependency $local_fs,, ignoring: Invalid argument
Dec 27 01:17:28 spacewalk systemd[1]: [/etc/rc.d/init.d/taskomatic:11] Failed to add dependency on cobbler,.service, ignoring: Invalid argument


This may create an issue where dependancies for enabling or disabling of spacewalk are not resolved correctly. 

System is f17, x86_64.

Comment 1 Stephen Herr 2013-01-02 19:16:08 UTC
The problem appears to be that we have a comma-separated list of services we depend on in those two files. The list should be space-separated, not comma-separated. fedoraproject.org/wiki/Packaging:SysVInitScript

Comment 2 Stephen Herr 2013-01-02 20:23:43 UTC
Created attachment 671664 [details]
Cobbler patch

Committed taskomatic fix to Spacewalk master: 5519cb7ee8ddee38ccd740d7e6513553f3a0af96

**Note** when we port this fix over to an OS where we maintain the version of cobbler we use (e.g. RHEL) make sure to apply the attached patch to cobbler!

Comment 3 Stephen Herr 2013-01-02 20:26:20 UTC
We (the Spacewalk devs) don't maintain cobbler in Fedora, so I can't fix the first couple of warnings here.

Comment 4 Stephen Herr 2013-03-01 17:07:21 UTC
Marking bug as ON_QA since tonight's build of Spacewalk nightly is a release candidate for Spacewalk 1.9.

Comment 5 Stephen Herr 2013-03-06 18:34:46 UTC
Spacewalk 1.9 has been released.

https://fedorahosted.org/spacewalk/wiki/ReleaseNotes19


Note You need to log in before you can comment on or make changes to this bug.