Description of problem:
There are some issues in verifying  SMBIOS values in domain xml .

a) libvirt should verify if the value of "date" and "release" entry is date format.for example "04/03/2009"
 
b) libvirt should verify if the "uuid" entry is absolutely identical with a top-level "uuid" element

c) libvirt should verify if the entry name in xml is correct and not only delete the wrong entry . and there is one doc typo in  formatdomain.html .


Version-Release number of selected component (if applicable):
libvirt-0.10.2-13.el6.x86_64
qemu-kvm-rhev-0.12.1.2-2.344.el6.x86_64 

How reproducible:
100% 

Steps to Reproduce:

a) libvirt should verify if the value of "date" and "release" entry is date format.for example Release Date: 04/03/2009.

# virsh dumpxml rhel6
<domain type='kvm' id='29'>
 ......
  <sysinfo type='smbios'>
    <bios>
      <entry name='date'>LENOVO</entry>
      <entry name='release'>LENOVO</entry>
    </bios>
 ......
</domain>


Login in guest

# dmidecode
 
SMBIOS 2.5 present.
64 structures occupying 3149 bytes.
Table at 0x000EF3C0.

Handle 0x0000, DMI type 0, 24 bytes
BIOS Information
    Vendor: LENOVO
    Version: 5CKT67EUS
    Release Date: LENOVO
    Address: 0xE0830
    Runtime Size: 128976 bytes
    ROM Size: 4096 kB
    Characteristics:


Expect result :
libvirt should verfiy if  the format of  "date" and "release" entry value is date format.for example  04/03/2009

================================================================================

b) libvirt should verify if the "uuid" entry is absolutely identical with a top-level "uuid" element

Edit the uuid value as below and save xml.

<domain type='kvm'>
  <name>rhel6</name>
  <uuid>1db7cfab-267e-e959-becf-ba85453c72e3</uuid>
  ......
    <system>
      <entry name='uuid'>1db7cfab-267e-e959-becf-ba8545-3c72e3</entry>
    </system>
  </sysinfo>
  ......
</domain>

# virsh edit rhel6
Domain rhel6 XML configuration edited.

Expect result
error: internal error UUID mismatch between <uuid> and <sysinfo>
Failed. Try again? [y,n,f,?]:
================================================================================
c)  libvirt should verify if the entry name in xml is correct.When the entry name is wrong , there isn't any error occurs. it will be deleted from domain'xml

 Edit vendor entry in <system> as below.

<domain type='kvm'>
  ......
  <sysinfo type='smbios'>
    <bios>
      <entry name='vendor'>LENOVO</entry>
      <entry name='version'>3.3.45xd.df.1</entry>
    </bios>
    <system>
      <entry name='manufacturer'>Fedora</entry>
      <entry name='vendor'>IBM</entry>   <=== If the right entry name "product" is set as  "vendor" by mistake , it will be deleted.

      <entry name='version'>Fedora 17.0.z.1</entry>

    </system>
  </sysinfo>
  ......
</domain>

# virsh edit rhel6
Domain rhel6 XML configuration edited.


# virsh start rhel6
Domain rhel6 started

# virsh dumpxml rhel6
<domain type='kvm'>
......
  <sysinfo type='smbios'>
    <bios>
      <entry name='vendor'>LENOVO</entry>
      <entry name='version'>3.3.45xd.df.1</entry>
    </bios>
    <system>
      <entry name='manufacturer'>Fedora</entry>
      <entry name='version'>Fedora 17.0.z.1</entry>
    </system>
  </sysinfo>
......
</domain>

Expect result
libvirt should verify if the entry name in SMBIOS block in xml is right when save xml. libvirt should throws error and not only delete it from xml.


There is one doc typo in formatdomain.html .

 544   &lt;sysinfo type='smbios'&gt;
 545     &lt;bios&gt;
 546       &lt;entry name='vendor'&gt;LENOVO&lt;/entry&gt;
 547     &lt;/bios&gt;
 548     &lt;system&gt;
 549       &lt;entry name='manufacturer'&gt;Fedora&lt;/entry&gt;
 550       &lt;entry name='vendor'&gt;Virt-Manager&lt;/entry&gt; <== the entry name should be "product"
 551     &lt;/system&gt;
 552   &lt;/sysinfo&gt;



Actual result
as above

Expect result
as above

Additional info