Bug 890723 - diffuse shebang shouldn't use /usr/bin/env
Summary: diffuse shebang shouldn't use /usr/bin/env
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: diffuse
Version: 18
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
Assignee: Christopher Meng
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 963062
TreeView+ depends on / blocked
 
Reported: 2012-12-29 06:35 UTC by Josh Chia
Modified: 2013-07-09 01:32 UTC (History)
2 users (show)

Fixed In Version: diffuse-0.4.7-2.fc18
Clone Of:
Environment:
Last Closed: 2013-06-29 19:29:29 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 979713 0 unspecified CLOSED diffuse shebang shouldn't use /usr/bin/env 2021-02-22 00:41:40 UTC

Internal Links: 979713

Description Josh Chia 2012-12-29 06:35:21 UTC
The first line is:
#!/usr/bin/env python

As part of a distro with its own dependency on python and pygtk packages, it should depend on the installation of Python it allegedly depends on with its definite path, instead of whatever's found in the PATH environment variable. Using env in the shebang will run Python from whatever is found in PATH.

How reproducible:
1. Install own Python, e.g. using virtualenv. Do not install pygtk in that Python installation
2. Activate the installed Python.
2. Run diffuse and see it fail.
  
Actual results:
Traceback (most recent call last):
  File "/usr/bin/diffuse", line 124, in <module>
    import pygtk
ImportError: No module named pygtk


Expected results:
diffuse should show a GUI window

Comment 1 Michael Schwendt 2013-06-29 09:52:29 UTC
Christopher, are you going to take over the package and fix this issue, too?

Comment 2 Christopher Meng 2013-06-29 11:52:20 UTC
Thanks for the notification, I've fixed in git repo.

Updates will be pushed.

Comment 3 Fedora Update System 2013-06-29 12:01:24 UTC
diffuse-0.4.7-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/diffuse-0.4.7-2.fc19

Comment 4 Fedora Update System 2013-06-29 12:09:53 UTC
diffuse-0.4.7-2.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/diffuse-0.4.7-2.fc18

Comment 5 Fedora Update System 2013-06-29 18:20:44 UTC
diffuse-0.4.7-2.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 6 Josh Chia 2013-06-29 18:24:50 UTC
Could you please backport to F17?

Comment 7 Christopher Meng 2013-06-29 18:28:05 UTC
(In reply to Josh Chia from comment #6)
> Could you please backport to F17?

Sorry, I don't have the access to push an update for f17 branch. I only maintain f18/f19 and rawhide.

I'll request one if you really need?

Comment 8 Josh Chia 2013-06-29 19:28:41 UTC
Thanks. I need it as it prevents me from using virtualenv and still use "git difftool" with diffuse. I've filed a new bug for F17. If you know whom to assign it to, please do so.

Comment 9 Fedora Update System 2013-07-09 01:32:32 UTC
diffuse-0.4.7-2.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.