Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 891070

Summary:	Storage domains shared statuses are calculated incorrectly.
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	Yaniv Lavi <ylavi>
Component:	ovirt-engine-webadmin-portal	Assignee:	Liron Aravot <laravot>
Status:	CLOSED NOTABUG	QA Contact:	Leonid Natapov <lnatapov>
Severity:	high	Docs Contact:
Priority:	high
Version:	3.2.0	CC:	abaron, acathrow, amureini, bazulay, dyasny, ecohen, iheim, mgoldboi, Rhev-m-bugs, ykaul
Target Milestone:	---	Keywords:	Regression
Target Release:	3.2.0
Hardware:	x86_64
OS:	Linux
Whiteboard:	storage
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-01-14 07:05:49 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	846272

Description Yaniv Lavi 2013-01-01 14:38:53 UTC

Description of problem:
The function fn_get_storage_domain_shared_status_by_domain_id was changed to improve performance, but its use may cause incorrect shared status results.
See commit:
http://gerrit.ovirt.org/#/c/9511/
For Bug:
https://bugzilla.redhat.com/879930

In views like storage_domains_with_hosts_view, duplicate rows will be created as a result of iso domains being attached to more then one dc. 
Also in view storage_domains_for_search status that is sent to function is calculated by max value for multiple dc connections basing on that the higher ENUM values are more problematic. A assumption that may change.

Version-Release number of selected component (if applicable):
SF2-3.2.0

Comment 4 Liron Aravot 2013-01-13 08:40:51 UTC

Yaniv, can you please elaborate? 
storage_domains_with_hosts_view seems to need to return duplicate rows and it was also the behaviour before this patch - I don't see how the given commit should affect it, as the same status will be returned for the same storage domain.

I've also tested it and the behaviour seems to be the same,
can you please give an usecase in which you've seen incorrect behaviour?

Comment 5 Yaniv Lavi 2013-01-13 10:32:39 UTC

(In reply to comment #4)
> Yaniv, can you please elaborate? 
> storage_domains_with_hosts_view seems to need to return duplicate rows and
> it was also the behaviour before this patch 

If this is the case, then close the case.

> - I don't see how the given
> commit should affect it, as the same status will be returned for the same
> storage domain.
> 
> I've also tested it and the behaviour seems to be the same,
> can you please give an usecase in which you've seen incorrect behaviour?

I understood when talking to others is that no duplicate rows should be returned. If this is not the case, close the bug.

Comment 6 Liron Aravot 2013-01-13 10:49:37 UTC

thanks Yaniv,

Allon, as you are the one who commented in the patch, any obligation for closing it? I don't see any issue.

Comment 7 Allon Mureinik 2013-01-14 07:05:49 UTC

As far as I saw and tested, this is the expected behavior, closing the bug.

Yaniv/Dan/QA - if you have a concrete usecase that shows this as a regression, please reopen the bug.