Spec URL: http://sundaram.fedorapeople.org/packages/e_dbus.spec SRPM URL: http://sundaram.fedorapeople.org/packages/e_dbus-1.7.4-1.fc18.src.rpm Description: Basic convenience wrappers around D-Bus to ease integrating D-Bus with EFL based applications. Fedora Account System Username:sundaram
Hi, I believe the pkgconfig requirement should be removed from the -devel subpackage as per guidelines. also this requirement need s changing from Requires: %{name} = %{version}-%{release} to Requires: %{name}%{?_isa} = %{version}-%{release} In the %install section please change %make_install to make install DESTDIR=%{buildroot}
(In reply to comment #1) > Hi, > > I believe the pkgconfig requirement should be removed from the -devel > subpackage as per guidelines. > +1 > also this requirement need s changing from > > Requires: %{name} = %{version}-%{release} > > to > > > Requires: %{name}%{?_isa} = %{version}-%{release} > +1 > > In the %install section please change > > %make_install > > > to > > make install DESTDIR=%{buildroot} Not required but desirable. Also please update to 1.7.6. I created a bug asking spot to update ecore to 1.7.6 on rawhide.
Done the changes suggested along with a few more. The suggestion to change %make_install is bogus since it expands to the latter and is NOT the same as %makeinstall macro http://sundaram.fedorapeople.org/packages/e_dbus.spec http://sundaram.fedorapeople.org/packages/e_dbus-1.7.6-1.fc18.src.rpm
Naming: OK Licensing: OK rpmlint: OK Builds on rawhide: OK http://koji.fedoraproject.org/koji/taskinfo?taskID=5481768 $ rpmlint e_dbus-* e_dbus.x86_64: W: no-manual-page-for-binary e-notify-send e_dbus-devel.x86_64: W: spelling-error Summary(en_US) dbus -> dubs, bus, buds e_dbus-devel.x86_64: W: spelling-error %description -l en_US dbus -> dubs, bus, buds e_dbus-devel.x86_64: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 4 warnings. Looks good. APPROVED.
New Package SCM Request ======================= Package Name: e_dbus Short Description: Wrappers around D-Bus for EFL based applications Owners: sundaram vicodan Branches: f19 InitialCC:
Unretired, please take ownership in pkgdb and submit a Package Change request for additional branches.
Package Change Request ====================== Package Name: e_dbus New Branches: f19 Owners: sundaram vicodan InitialCC:
Git done (by process-git-requests).
Koji claims f20 is blocked. can you unblock it?
Rel-eng needs to do that.
thanks. filed at https://fedorahosted.org/rel-eng/ticket/5642
e_dbus-1.7.8-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/e_dbus-1.7.8-1.fc20
e_dbus-1.7.8-1.fc20 has been pushed to the Fedora 20 testing repository.
e_dbus-1.7.8-1.fc20 has been pushed to the Fedora 20 stable repository.