Bug 891182 - nodejs-chownr - Like `chown -R`
Summary: nodejs-chownr - Like `chown -R`
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Miro Hrončok
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: 891171 891215
TreeView+ depends on / blocked
Reported: 2013-01-02 08:08 UTC by T.C. Hollingsworth
Modified: 2013-04-05 23:13 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2013-01-17 07:43:08 UTC
Type: ---
mhroncok: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description T.C. Hollingsworth 2013-01-02 08:08:34 UTC
Spec: http://patches.fedorapeople.org/npm/nodejs-chownr.spec
SRPM: http://patches.fedorapeople.org/npm/nodejs-chownr-0.0.1-3.fc17.src.rpm
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4830951
FAS username: patches

Like `chown -R`.

This package is part of the npm stack and a future F19 Feature for Node.js.

This package may depend on other packages in the npm stack that aren't explicitly
listed as dependencies of this bug.  For more information, see bug 891171.

Please use nodejs-0.6.5-3 or later when building or using this package.

Comment 1 T.C. Hollingsworth 2013-01-10 07:27:46 UTC
Updated with empty %build sections and other issues found in various reviews.

Spec: http://patches.fedorapeople.org/npm/nodejs-chownr.spec
SRPM: http://patches.fedorapeople.org/npm/nodejs-chownr-0.0.1-4.fc17.src.rpm
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4854298

Comment 2 Miro Hrončok 2013-01-14 17:39:09 UTC
Please, drop the note about the license on GitHub and correct the License field.

Comment 4 Miro Hrončok 2013-01-15 00:19:33 UTC
Seems like Isaac added the LICENSE file to the tarball without rising the version number. Please redownload the source.

Comment 5 T.C. Hollingsworth 2013-01-15 08:56:09 UTC
THis version uses a fresh tarball from upstream and installs the newly included LICENCE file:

Spec: http://patches.fedorapeople.org/npm/nodejs-chownr.spec
SRPM: http://patches.fedorapeople.org/npm/nodejs-chownr-0.0.1-6.fc17.src.rpm
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4869684

Comment 6 Miro Hrončok 2013-01-15 19:46:18 UTC
TODO: Drop markdown syntax from Description.

MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review.

$ rpmlint ../SRPMS/nodejs-chownr-0.0.1-6.fc18.src.rpm ../RPMS/noarch/nodejs-chownr-0.0.1-6.fc18.noarch.rpm
nodejs-chownr.src: W: spelling-error %description -l en_US chown -> sown, chow, chows
nodejs-chownr.noarch: W: spelling-error %description -l en_US chown -> sown, chow, chows
nodejs-chownr.noarch: W: only-non-binary-in-usr-lib
2 packages and 0 specfiles checked; 0 errors, 3 warnings.

All are false positive. OK

MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. OK
MUST: The package must meet the Packaging Guidelines. OK
MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license. OK

Checked in LICENSE: BSD, OK.

MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. OK
MUST: The spec file must be written in American English. OK
MUST: The spec file for the package MUST be legible. OK
MUST: The sources used to build the package must match the upstream source, as provided in the spec URL.

$ sha256sum ../SOURCES/chownr-0.0.1.tgz 
da1fbb894b4103a1a3c912fc780f6dcf7339865298f2fdc4e20afdf00a94b821  ../SOURCES/chownr-0.0.1.tgz
$ spectool -g nodejs-chownr.spec 
Getting http://registry.npmjs.org/chownr/-/chownr-0.0.1.tgz to ./chownr-0.0.1.tgz
$ sha256sum chownr-0.0.1.tgz 
da1fbb894b4103a1a3c912fc780f6dcf7339865298f2fdc4e20afdf00a94b821  chownr-0.0.1.tgz


MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. OK
MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. OK, builds in mock
MUST: Packages must NOT bundle copies of system libraries. OK
MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. OK
MUST: A Fedora package must not list a file more than once in the spec file's %files listings. OK
MUST: Permissions on files must be set properly.

$ rpm -q -lv -p ../RPMS/noarch/nodejs-chownr-0.0.1-6.fc18.noarch.rpm 
drwxr-xr-x    2 root    root                        0 led 15 20:42 /usr/lib/node_modules/chownr
-rw-r--r--    1 root    root                     1087 bře 29  2012 /usr/lib/node_modules/chownr/chownr.js
drwxr-xr-x    2 root    root                        0 led 15 20:42 /usr/lib/node_modules/chownr/node_modules
-rw-r--r--    1 root    root                      413 čen  4  2012 /usr/lib/node_modules/chownr/package.json
drwxr-xr-x    2 root    root                        0 led 15 20:42 /usr/share/doc/nodejs-chownr-0.0.1
-rw-r--r--    1 root    root                     1318 čen  4  2012 /usr/share/doc/nodejs-chownr-0.0.1/LICENCE
-rw-r--r--    1 root    root                       59 bře 28  2012 /usr/share/doc/nodejs-chownr-0.0.1/README.md


MUST: Each package must consistently use macros. OK
MUST: The package must contain code, or permissable content. OK
MUST: If a package includes something as %doc, it must not affect the runtime of the application. OK
MUST: Packages must not own files or directories already owned by other packages. OK
MUST: All filenames in rpm packages must be valid UTF-8. OK

SHOULD: The reviewer should test that the package builds in mock. OK
SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. OK

TODO: Run tests, when deps reach Fedora

Please consider fixing TODOs. Package APPROVED.

Comment 7 T.C. Hollingsworth 2013-01-15 23:25:52 UTC
Thanks for the review!

(In reply to comment #6)
> TODO: Drop markdown syntax from Description.

That wasn't intended to be markdown syntax; it was meant to clearly indicate a command line, using the backtick operator many users are familiar with from shells like bash.

Comment 8 T.C. Hollingsworth 2013-01-15 23:32:44 UTC
New Package SCM Request
Package Name: nodejs-chownr
Short Description: Changes file permissions recursively
Owners: patches
Branches: f18 el6

Comment 9 Gwyn Ciesla 2013-01-16 11:59:54 UTC
Git done (by process-git-requests).

Comment 10 T.C. Hollingsworth 2013-01-17 07:43:08 UTC
Built for rawhide:

Comment 11 Fedora Update System 2013-01-17 08:41:10 UTC
nodejs-abbrev-1.0.4-2.fc18, nodejs-ansi-0.1.2-4.fc18, nodejs-async-0.1.22-3.fc18, nodejs-glob-3.1.14-2.fc18, nodejs-inherits-1.0.0-6.fc18, nodejs-graceful-fs-1.1.14-2.fc18, nodejs-minimatch-0.2.9-2.fc18, nodejs-mkdirp-0.3.4-2.fc18, nodejs-mute-stream-0.0.3-3.fc18, nodejs-read-1.0.4-4.fc18, nodejs-read-installed-0.0.4-2.fc18, nodejs-read-package-json-0.1.12-2.fc18, nodejs-retry-0.6.0-2.fc18, nodejs-rimraf-2.1.1-2.fc18, nodejs-slide-1.1.3-4.fc18, nodejs-uid-number-0.0.3-4.fc18, nodejs-sigmund-1.0.0-2.fc18, nodejs-osenv-0.0.3-2.fc18, nodejs-nopt-2.0.0-3.fc18, nodejs-lru-cache-2.2.1-2.fc18, nodejs-mime-1.2.7-2.fc18, nodejs-init-package-json-0.0.7-3.fc18, nodejs-fstream-0.1.21-3.fc18, nodejs-delayed-stream-0.0.5-2.fc18, nodejs-proto-list-1.2.2-2.fc18, nodejs-npm-registry-client-0.2.11-2.fc18, nodejs-form-data-0.0.6-2.fc18, nodejs-which-1.0.5-4.fc18, nodejs-chownr-0.0.1-6.fc18, nodejs-opts-1.2.2-2.fc18, nodejs-yamlish-0.0.5-1.fc18, nodejs-once-1.1.1-2.fc18, nodejs-lockfile-0.2.1-2.fc18, nodejs-ini-1.0.5-2.fc18, nodejs-couch-login-0.1.15-2.fc18 has been submitted as an update for Fedora 18.

Comment 12 Fedora Update System 2013-04-05 23:13:19 UTC
node-gyp-0.9.1-2.fc18, nodejs-async-0.2.6-1.fc18, nodejs-chmodr-0.1.0-2.fc18, nodejs-fstream-npm-0.1.4-1.fc18, nodejs-glob-3.1.21-1.fc18, nodejs-minimatch-0.2.11-1.fc18, nodejs-mkdirp-0.3.5-1.fc18, nodejs-npm-registry-client-0.2.18-2.fc18, nodejs-read-package-json-0.2.2-1.fc18, nodejs-request-2.14.0-1.fc18, nodejs-semver-1.1.4-1.fc18, npm-1.2.14-2.fc18, nodejs-abbrev-1.0.4-2.fc18, nodejs-ansi-0.1.2-4.fc18, nodejs-inherits-1.0.0-6.fc18, nodejs-mute-stream-0.0.3-3.fc18, nodejs-read-1.0.4-4.fc18, nodejs-retry-0.6.0-2.fc18, nodejs-slide-1.1.3-4.fc18, nodejs-uid-number-0.0.3-4.fc18, nodejs-sigmund-1.0.0-2.fc18, nodejs-osenv-0.0.3-2.fc18, nodejs-init-package-json-0.0.7-3.fc18, nodejs-delayed-stream-0.0.5-2.fc18, nodejs-proto-list-1.2.2-2.fc18, nodejs-which-1.0.5-4.fc18, nodejs-chownr-0.0.1-6.fc18, nodejs-opts-1.2.2-2.fc18, nodejs-once-1.1.1-2.fc18, nodejs-couch-login-0.1.15-2.fc18, nodejs-archy-0.0.2-5.fc18, nodejs-block-stream-0.0.6-4.fc18, nodejs-npmlog-0.0.2-2.fc18, nodejs-opener-1.3.0-4.fc18, nodejs-tobi-cookie-0.3.2-2.fc18, nodejs-promzard-0.2.0-3.fc18, nodejs-combined-stream-0.0.4-1.fc18, nodejs-config-chain-1.1.5-1.fc18, nodejs-fstream-0.1.22-1.fc18, nodejs-fstream-ignore-0.0.6-1.fc18, nodejs-graceful-fs-1.2.0-1.fc18, nodejs-ini-1.1.0-1.fc18, nodejs-lockfile-0.3.0-1.fc18, nodejs-lru-cache-2.2.2-1.fc18, nodejs-mime-1.2.9-1.fc18, nodejs-nopt-2.1.1-1.fc18, nodejs-npmconf-0.0.23-1.fc18, nodejs-read-installed-0.1.1-1.fc18, nodejs-rimraf-2.1.4-1.fc18, nodejs-tar-0.1.16-1.fc18, nodejs-form-data-0.0.7-1.fc18 has been pushed to the Fedora 18 stable repository.

Note You need to log in before you can comment on or make changes to this bug.