Hide Forgot
Spec: http://patches.fedorapeople.org/npm/nodejs-mime.spec SRPM: http://patches.fedorapeople.org/npm/nodejs-mime-1.2.7-1.fc17.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4831015 FAS username: patches Comprehensive MIME type mapping API. Includes all 600+ types and 800+ extensions defined by the Apache project, plus additional types submitted by the node.js community. This package is part of the npm stack and a future F19 Feature for Node.js. This package may depend on other packages in the npm stack that aren't explicitly listed as dependencies of this bug. For more information, see bug 891171. Please use nodejs-0.6.5-3 or later when building or using this package.
Hi T.C. -The url should be https://github.com/broofa/node-mime not http://github.com/broofa - Add the %build section I think there is a problem between tar and npm, as comment, and I'm not sure these warnings how affect the build I found something here: https://github.com/isaacs/npm/issues/1197 You know something more specific about this?
(In reply to comment #1) > Hi T.C. > -The url should be > https://github.com/broofa/node-mime > not http://github.com/broofa > - Add the %build section Thanks, I'm going to push updates to all my active reviews adding the %build section soon. I'll get the URL fixed at the same time. > > I think there is a problem between tar and npm, as comment, and I'm not > sure these warnings how affect the build > I found something here: > https://github.com/isaacs/npm/issues/1197 > You know something more specific about this? Yeah, tar spews out useless warnings during %setup because of this, as you might notice from the koji logs or when building packages locally. It doesn't hurt anything; the extra headers are simply ignored.
All issues should now be fixed. Spec: http://patches.fedorapeople.org/npm/nodejs-mime.spec SRPM: http://patches.fedorapeople.org/npm/nodejs-mime-1.2.7-2.fc17.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4854334
Description and Summary OK. MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. $ rpmlint ../SRPMS/nodejs-mime-1.2.7-2.fc18.src.rpm ../RPMS/noarch/nodejs-mime-1.2.7-2.fc18.noarch.rpm nodejs-mime.src: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-mime.noarch: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-mime.noarch: W: only-non-binary-in-usr-lib 2 packages and 0 specfiles checked; 0 errors, 3 warnings. All false positives. OK MUST: The package must be named according to the Package Naming Guidelines. OK MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. OK MUST: The package must meet the Packaging Guidelines. OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK MUST: The License field in the package spec file must match the actual license. Checked in LICENSE file, MIT. OK MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. OK MUST: The spec file must be written in American English. OK MUST: The spec file for the package MUST be legible. OK MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. $ sha256sum ../SOURCES/mime-1.2.7.tgz a80244918c9c75fa4d0b37f311920c7d5270aab9a05aca9a74783764ad152df6 ../SOURCES/mime-1.2.7.tgz $ spectool -g nodejs-mime.spec Getting http://registry.npmjs.org/mime/-/mime-1.2.7.tgz to ./mime-1.2.7.tgz $ sha256sum mime-1.2.7.tgz a80244918c9c75fa4d0b37f311920c7d5270aab9a05aca9a74783764ad152df6 mime-1.2.7.tgz OK MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. OK MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. OK, build in mock MUST: Packages must NOT bundle copies of system libraries. OK MUST: A package must own all directories that it creates. OK MUST: A Fedora package must not list a file more than once in the spec file's %files listings. OK MUST: Permissions on files must be set properly. $ rpm -q -lv -p ../RPMS/noarch/nodejs-mime-1.2.7-2.fc18.noarch.rpm drwxr-xr-x 2 root root 0 led 13 22:02 /usr/lib/node_modules/mime -rw-r--r-- 1 root root 2522 dub 29 2012 /usr/lib/node_modules/mime/mime.js -rw-r--r-- 1 root root 567 čec 19 19:54 /usr/lib/node_modules/mime/package.json drwxr-xr-x 2 root root 0 led 13 22:02 /usr/lib/node_modules/mime/types -rw-r--r-- 1 root root 53011 kvě 7 2012 /usr/lib/node_modules/mime/types/mime.types -rw-r--r-- 1 root root 1884 čec 19 19:52 /usr/lib/node_modules/mime/types/node.types drwxr-xr-x 2 root root 0 led 13 22:02 /usr/share/doc/nodejs-mime-1.2.7 -rw-r--r-- 1 root root 1075 kvě 10 2011 /usr/share/doc/nodejs-mime-1.2.7/LICENSE -rw-r--r-- 1 root root 2017 čec 19 19:49 /usr/share/doc/nodejs-mime-1.2.7/README.md OK MUST: Each package must consistently use macros. OK MUST: The package must contain code, or permissable content. OK MUST: If a package includes something as %doc, it must not affect the runtime of the application. OK MUST: Packages must not own files or directories already owned by other packages. OK MUST: All filenames in rpm packages must be valid UTF-8. OK SHOULD: The reviewer should test that the package builds in mock. OK SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. OK Package APPROVED.
New Package SCM Request ======================= Package Name: nodejs-mime Short Description: A comprehensive library for mime-type mapping Owners: patches Branches: f18 el6 InitialCC:
Git done (by process-git-requests).
node-gyp-0.9.1-2.fc18, nodejs-async-0.2.6-1.fc18, nodejs-chmodr-0.1.0-2.fc18, nodejs-fstream-npm-0.1.4-1.fc18, nodejs-glob-3.1.21-1.fc18, nodejs-minimatch-0.2.11-1.fc18, nodejs-mkdirp-0.3.5-1.fc18, nodejs-npm-registry-client-0.2.18-2.fc18, nodejs-read-package-json-0.2.2-1.fc18, nodejs-request-2.14.0-1.fc18, nodejs-semver-1.1.4-1.fc18, npm-1.2.14-2.fc18, nodejs-abbrev-1.0.4-2.fc18, nodejs-ansi-0.1.2-4.fc18, nodejs-inherits-1.0.0-6.fc18, nodejs-mute-stream-0.0.3-3.fc18, nodejs-read-1.0.4-4.fc18, nodejs-retry-0.6.0-2.fc18, nodejs-slide-1.1.3-4.fc18, nodejs-uid-number-0.0.3-4.fc18, nodejs-sigmund-1.0.0-2.fc18, nodejs-osenv-0.0.3-2.fc18, nodejs-init-package-json-0.0.7-3.fc18, nodejs-delayed-stream-0.0.5-2.fc18, nodejs-proto-list-1.2.2-2.fc18, nodejs-which-1.0.5-4.fc18, nodejs-chownr-0.0.1-6.fc18, nodejs-opts-1.2.2-2.fc18, nodejs-once-1.1.1-2.fc18, nodejs-couch-login-0.1.15-2.fc18, nodejs-archy-0.0.2-5.fc18, nodejs-block-stream-0.0.6-4.fc18, nodejs-npmlog-0.0.2-2.fc18, nodejs-opener-1.3.0-4.fc18, nodejs-tobi-cookie-0.3.2-2.fc18, nodejs-promzard-0.2.0-3.fc18, nodejs-combined-stream-0.0.4-1.fc18, nodejs-config-chain-1.1.5-1.fc18, nodejs-fstream-0.1.22-1.fc18, nodejs-fstream-ignore-0.0.6-1.fc18, nodejs-graceful-fs-1.2.0-1.fc18, nodejs-ini-1.1.0-1.fc18, nodejs-lockfile-0.3.0-1.fc18, nodejs-lru-cache-2.2.2-1.fc18, nodejs-mime-1.2.9-1.fc18, nodejs-nopt-2.1.1-1.fc18, nodejs-npmconf-0.0.23-1.fc18, nodejs-read-installed-0.1.1-1.fc18, nodejs-rimraf-2.1.4-1.fc18, nodejs-tar-0.1.16-1.fc18, nodejs-form-data-0.0.7-1.fc18 has been pushed to the Fedora 18 stable repository.