Created attachment 671781 [details] screenshot of manual partitionig Description of problem: In manual partitioning, i created a /boot, / and swap. Then i created other small filesystems whose mountpoint were: /dev/null, /dev/zero, /dev/console and /dev/sda. Anaconda accepted the storage configuration. I do not believe that is safe to put data filesystems under /dev ... I was able to at least start the installation. Version-Release number of selected component (if applicable): smoke12 (18.37.8) How reproducible: always Steps to Reproduce: 1. do manual partitioning, create /,/boot,swap 2. create /dev/null of 256mb 3. repeat that for /dev/zero, /dev/console and /dev/sda. Actual results: anaconda crashes Expected results: warn or prevent the user from mounting stuff under /dev Additional info: abrt pointed to 889332 which seems a bit different.
Created attachment 671782 [details] storage.log
Created attachment 671783 [details] program.log
Created attachment 671791 [details] anaconda.log
Created attachment 671796 [details] anaconda tb anaconda 18.37.8 exception report Traceback (most recent call first): File "/usr/lib64/python2.7/site-packages/pyanaconda/storage/formats/fs.py", line 630, in mount raise FSError("mount failed: %s" % e) File "/usr/lib64/python2.7/site-packages/pyanaconda/storage/formats/fs.py", line 860, in setup return self.mount(**kwargs) File "/usr/lib64/python2.7/site-packages/pyanaconda/storage/__init__.py", line 2878, in mountFilesystems chroot=rootPath) File "/usr/lib64/python2.7/site-packages/pyanaconda/storage/__init__.py", line 1655, in mountFilesystems readOnly=readOnly, skipRoot=skipRoot) File "/usr/lib64/python2.7/site-packages/pyanaconda/storage/__init__.py", line 193, in turnOnFilesystems skipRoot=False) File "/usr/lib64/python2.7/site-packages/pyanaconda/install.py", line 114, in doInstall turnOnFilesystems(storage) File "/usr/lib64/python2.7/threading.py", line 504, in run self.__target(*self.__args, **self.__kwargs) File "/usr/lib64/python2.7/site-packages/pyanaconda/threads.py", line 91, in run threading.Thread.run(self, *args, **kwargs) FSError: mount failed: (20, 'Not a directory')
Created attachment 674158 [details] anaconda-tb-GZB1qL Create a mount point /proc/mounts. NB: This was identified as a duplicate of Bug 889332. anaconda 18.37.10 exception report Traceback (most recent call first): File "/usr/lib64/python2.7/site-packages/pyanaconda/storage/formats/fs.py", line 630, in mount raise FSError("mount failed: %s" % e) File "/usr/lib64/python2.7/site-packages/pyanaconda/storage/formats/fs.py", line 860, in setup return self.mount(**kwargs) File "/usr/lib64/python2.7/site-packages/pyanaconda/storage/__init__.py", line 2878, in mountFilesystems chroot=rootPath) File "/usr/lib64/python2.7/site-packages/pyanaconda/storage/__init__.py", line 1655, in mountFilesystems readOnly=readOnly, skipRoot=skipRoot) File "/usr/lib64/python2.7/site-packages/pyanaconda/storage/__init__.py", line 193, in turnOnFilesystems skipRoot=False) File "/usr/lib64/python2.7/site-packages/pyanaconda/install.py", line 114, in doInstall turnOnFilesystems(storage) File "/usr/lib64/python2.7/threading.py", line 504, in run self.__target(*self.__args, **self.__kwargs) File "/usr/lib64/python2.7/site-packages/pyanaconda/threads.py", line 91, in run threading.Thread.run(self, *args, **kwargs) FSError: mount failed: (20, 'Not a directory') Local variables in innermost frame: chroot: /mnt/sysimage e: (20, 'Not a directory') self: existing ext4 filesystem mounted at /proc/mounts args: () ret: None kwargs: {'chroot': '/mnt/sysimage', 'options': 'defaults'} mountpoint: /proc/mounts options: defaults chrootedMountpoint: /mnt/sysimage/proc/mounts
Created attachment 674242 [details] anaconda-tb-6BDzNC Create mount point /sys/fs/cgroup/systemd. anaconda 18.37.10 exception report Traceback (most recent call first): File "/usr/lib64/python2.7/site-packages/pyanaconda/storage/formats/fs.py", line 630, in mount raise FSError("mount failed: %s" % e) File "/usr/lib64/python2.7/site-packages/pyanaconda/storage/formats/fs.py", line 860, in setup return self.mount(**kwargs) File "/usr/lib64/python2.7/site-packages/pyanaconda/storage/__init__.py", line 2878, in mountFilesystems chroot=rootPath) File "/usr/lib64/python2.7/site-packages/pyanaconda/storage/__init__.py", line 1655, in mountFilesystems readOnly=readOnly, skipRoot=skipRoot) File "/usr/lib64/python2.7/site-packages/pyanaconda/storage/__init__.py", line 193, in turnOnFilesystems skipRoot=False) File "/usr/lib64/python2.7/site-packages/pyanaconda/install.py", line 114, in doInstall turnOnFilesystems(storage) File "/usr/lib64/python2.7/threading.py", line 504, in run self.__target(*self.__args, **self.__kwargs) File "/usr/lib64/python2.7/site-packages/pyanaconda/threads.py", line 91, in run threading.Thread.run(self, *args, **kwargs) FSError: mount failed: (2, 'No such file or directory') Local variables in innermost frame: chroot: /mnt/sysimage e: (2, 'No such file or directory') self: existing ext4 filesystem mounted at /sys/fs/cgroup/systemd args: () ret: None kwargs: {'chroot': '/mnt/sysimage', 'options': 'defaults'} mountpoint: /sys/fs/cgroup/systemd options: defaults chrootedMountpoint: /mnt/sysimage/sys/fs/cgroup/systemd
Tested with F19 Beta TC3. It looks like anything under /dev , /proc , or /sys is now forbidden. However, other possibly problematic mount points that are not currently blocked are /selinux : selinuxfs on /sys/fs/selinux type selinuxfs (rw,relatime) on a normal installed system, and /run : tmpfs on /run type tmpfs (rw,nosuid,nodev,seclabel,mode=755) Kicking off an install with both of these created as partitions doesn't crash the installer, but I'm not sure it's going to give a working installed system.