Spec URL: http://puiterwijk.fedorapeople.org/packages/trac-CGit-plugin/trac-CGit-plugin.spec
SRPM URL: http://puiterwijk.fedorapeople.org/packages/trac-CGit-plugin/trac-CGit-plugin-1.0.5-1.fc17.src.rpm
Fedora Account System Username: puiterwijk
Replace the trac browser by cgit.
Configure the url in the cgit ini panel and TracCGit
will replace the trac source browser (provided you
have a working cgit installation setup).
Plain and simple.
I'll try and review this tomorrow.
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License GPLv2+
See below - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - Package obey's FHS standard (except for 2 exceptions)
See below - No rpmlint output.
OK - final provides and requires are sane.
OK - Should build in mock.
OK - Should build on all supported archs
OK - Should function as described.
OK - Should have dist tag
OK - Should package latest version
OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin
1. From the headers in the source files, the license here should be
2. Include the LICENSE file as a %doc?
3. rpmlint says:
trac-CGit-plugin.noarch: W: spelling-error %description -l en_US url -> URL, curl, purl
trac-CGit-plugin.noarch: W: spelling-error %description -l en_US ini -> uni, in, ii
trac-CGit-plugin.noarch: W: no-documentation
trac-CGit-plugin.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/cgit/web_ui.py 0644L /usr/bin/env
You could drop the /usr/bin/env line?
trac-CGit-plugin.src: W: spelling-error %description -l en_US url -> URL, curl, purl
trac-CGit-plugin.src: W: spelling-error %description -l en_US ini -> uni, in, ii
2 packages and 0 specfiles checked; 1 errors, 5 warnings.
The rest can be ignored.
If you can fix those minor things before import, this is APPROVED.
New Package SCM Request
Package Name: trac-CGit-plugin
Short Description: Replace the trac browser by CGit
Branches: f17 f18 el5 el6
Git done (by process-git-requests).
trac-CGit-plugin-1.0.5-1.fc17 has been submitted as an update for Fedora 17.
trac-CGit-plugin-1.0.5-1.el6 has been submitted as an update for Fedora EPEL 6.
trac-CGit-plugin-1.0.5-1.fc18 has been submitted as an update for Fedora 18.
trac-CGit-plugin-1.0.5-1.el6 has been pushed to the Fedora EPEL 6 testing repository.
trac-CGit-plugin-1.0.5-1.fc17 has been pushed to the Fedora 17 stable repository.
trac-CGit-plugin-1.0.5-1.fc18 has been pushed to the Fedora 18 stable repository.
trac-CGit-plugin-1.0.5-1.el6 has been pushed to the Fedora EPEL 6 stable repository.