Bug 892163 - Review Request: rubygem-gobject-introspection - Ruby binding of GObjectIntrospection
Summary: Review Request: rubygem-gobject-introspection - Ruby binding of GObjectIntro...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Brendan Jones
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-01-05 16:00 UTC by Mamoru TASAKA
Modified: 2013-02-20 04:49 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-02-20 04:49:31 UTC
Type: ---
Embargoed:
brendan.jones.it: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Mamoru TASAKA 2013-01-05 16:00:00 UTC
Spec URL: http://mtasaka.fedorapeople.org/Review_request/rubygem-gobject-introspection/rubygem-gobject-introspection.spec
SRPM URL: http://mtasaka.fedorapeople.org/Review_request/rubygem-gobject-introspection/rubygem-gobject-introspection-1.1.9-1.fc.src.rpm
Description: 
Ruby/GObjectIntrospection is a Ruby binding of 
GObjectIntrospection.
Fedora Account System Username: mtasaka

Koji scratch build
For F-19: http://koji.fedoraproject.org/koji/taskinfo?taskID=4842593
Note: build requires rubygem-glib2-devel >= 1.1.9. On F-18 and F-17, this is currently under testing repository

Comment 1 Brendan Jones 2013-02-07 13:31:05 UTC
I'll take this on

A quick build here results in failed tests but the build still completes successfully.

Loaded suite .
Started
.....................................F
===============================================================================
Failure:
test_get_signal_name(TestInterfaceInfo) [/home/bsjones/rpmbuild/BUILD/rubygem-gobject-introspection-1.1.9/usr/share/gems/gems/gobject-introspection-1.1.9/test/test-interface-info.rb:72]:
<#<GObjectIntrospection::SignalInfo:0x195d188 ptr=0x1f60b20 own=true>> expected to be kind_of?
<GObjectIntrospection::FunctionInfo> but was
<GObjectIntrospection::SignalInfo>.
===============================================================================
.........................................................................

Finished in 0.225749771 seconds.

111 tests, 111 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
99.0991% passed

491.69 tests/s, 491.69 assertions/s
+ echo 'Please investigate this'
Please investigate this

Comment 2 Brendan Jones 2013-02-09 07:01:27 UTC
I can't find a license for the this package.

Headers states LGPLv2+ but the website states GPLv2+. The website license also states that the license file should be included in the source page but maybe this has been overlooked by upstream. Can you confirm?

Again you could probably split the lib out here if you wanted to.

Comment 3 Brendan Jones 2013-02-09 07:07:34 UTC
Also, upstream have released 1.2.1

Comment 4 Mamoru TASAKA 2013-02-09 07:18:50 UTC
Thank you for review. I will update this package to 1.2.1 later.

(In reply to comment #2)

> I can't find a license for the this package.
> 
> Headers states LGPLv2+ but the website states GPLv2+. The website license
> also states that the license file should be included in the source page but
> maybe this has been overlooked by upstream. Can you confirm?

Well, development status for ruby-gnome2 (including this package) is actually active, however the website for ruby-gnome2 is somewhat outdated... Anyway the license tag should be okay with LGPLv2+.

Comment 5 Brendan Jones 2013-02-09 08:38:58 UTC
OK, I'm happy with the LGPLv2+. Here's the full review.

I'll approve if you can just provide feedback on:

 - rpmlint issues (see end of review)
 - confirmation that overriding the %check result is safe and intentional


Package Review
==============

Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[x] = Manual review needed


Issues:
=======
- gems should require rubygems package
  Note: Requires: rubygems missing in rubygem-gobject-introspection-doc
  See: http://fedoraproject.org/wiki/Packaging:Ruby#RubyGems
- Pure Ruby package must be built as noarch
  See: https://fedoraproject.org/wiki/Packaging:Guidelines#Architecture_Support
- License field in the package spec file matches the actual license.
  Note: Checking patched sources after %prep for licenses. No licenses found.
  Please check the source files for licenses manually.
  See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#ValidLicenseShortNames


===== MUST items =====

C/C++:
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[-]: Fully versioned dependency in subpackages, if present.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rubygem-
     gobject-introspection-doc
[x]: Package complies to the Packaging Guidelines
[!]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[!]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).

Ruby:
[x]: Platform dependent files must all go under %{gem_extdir}, platform
     independent under %{gem_dir}.
[x]: Gem package must not define a non-gem subpackage
[x]: Gem package is named rubygem-%{gem_name}
[x]: Package contains BuildRequires: rubygems-devel.
[x]: Gem package must define %{gem_name} macro.
[x]: Package contains Requires: ruby(abi).

===== SHOULD items =====

Generic:
[!]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define.

Ruby:
[!]: Specfile should use macros from rubygem-devel package.
     Note: The specfile doesn't use these macros: %doc %{gem_docdir},
     %{gem_libdir}, %exclude %{gem_cache}, %{gem_spec}
[!]: Test suite of the library should be run.
[x]: Gem package should exclude cached Gem.

===== EXTRA items =====

Generic:
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: rubygem-gobject-introspection-1.1.9-1.fc18.x86_64.rpm
          rubygem-gobject-introspection-doc-1.1.9-1.fc18.noarch.rpm
rubygem-gobject-introspection.x86_64: W: no-soname /usr/lib64/gems/exts/gobject-introspection-1.1.9/lib/gobject_introspection.so
rubygem-gobject-introspection.x86_64: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 2 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint rubygem-gobject-introspection-doc rubygem-gobject-introspection
rubygem-gobject-introspection.x86_64: W: no-soname /usr/lib64/gems/exts/gobject-introspection-1.1.9/lib/gobject_introspection.so
rubygem-gobject-introspection.x86_64: W: undefined-non-weak-symbol /usr/lib64/gems/exts/gobject-introspection-1.1.9/lib/gobject_introspection.so rbgobj_make_flags
rubygem-gobject-introspection.x86_64: W: undefined-non-weak-symbol /usr/lib64/gems/exts/gobject-introspection-1.1.9/lib/gobject_introspection.so rbgobj_instance_from_ruby_object
rubygem-gobject-introspection.x86_64: W: undefined-non-weak-symbol /usr/lib64/gems/exts/gobject-introspection-1.1.9/lib/gobject_introspection.so rbgobj_get_enum
rubygem-gobject-introspection.x86_64: W: undefined-non-weak-symbol /usr/lib64/gems/exts/gobject-introspection-1.1.9/lib/gobject_introspection.so rbg_rval2cstr
rubygem-gobject-introspection.x86_64: W: undefined-non-weak-symbol /usr/lib64/gems/exts/gobject-introspection-1.1.9/lib/gobject_introspection.so rbgobj_ruby_object_from_instance
rubygem-gobject-introspection.x86_64: W: undefined-non-weak-symbol /usr/lib64/gems/exts/gobject-introspection-1.1.9/lib/gobject_introspection.so g_signal_flags_get_type
rubygem-gobject-introspection.x86_64: W: undefined-non-weak-symbol /usr/lib64/gems/exts/gobject-introspection-1.1.9/lib/gobject_introspection.so rbgobj_get_flags
rubygem-gobject-introspection.x86_64: W: undefined-non-weak-symbol /usr/lib64/gems/exts/gobject-introspection-1.1.9/lib/gobject_introspection.so rbgobj_initialize_object
rubygem-gobject-introspection.x86_64: W: undefined-non-weak-symbol /usr/lib64/gems/exts/gobject-introspection-1.1.9/lib/gobject_introspection.so rbgobj_define_class
rubygem-gobject-introspection.x86_64: W: undefined-non-weak-symbol /usr/lib64/gems/exts/gobject-introspection-1.1.9/lib/gobject_introspection.so rbg_define_singleton_method
rubygem-gobject-introspection.x86_64: W: undefined-non-weak-symbol /usr/lib64/gems/exts/gobject-introspection-1.1.9/lib/gobject_introspection.so rbgobj_boxed_get
rubygem-gobject-introspection.x86_64: W: undefined-non-weak-symbol /usr/lib64/gems/exts/gobject-introspection-1.1.9/lib/gobject_introspection.so rbg_cstr2rval
rubygem-gobject-introspection.x86_64: W: undefined-non-weak-symbol /usr/lib64/gems/exts/gobject-introspection-1.1.9/lib/gobject_introspection.so rbgobj_make_boxed
rubygem-gobject-introspection.x86_64: W: undefined-non-weak-symbol /usr/lib64/gems/exts/gobject-introspection-1.1.9/lib/gobject_introspection.so rbg_scan_options
rubygem-gobject-introspection.x86_64: W: undefined-non-weak-symbol /usr/lib64/gems/exts/gobject-introspection-1.1.9/lib/gobject_introspection.so rbg_rval2cstr_accept_nil
rubygem-gobject-introspection.x86_64: W: undefined-non-weak-symbol /usr/lib64/gems/exts/gobject-introspection-1.1.9/lib/gobject_introspection.so rbg_define_method
rubygem-gobject-introspection.x86_64: W: undefined-non-weak-symbol /usr/lib64/gems/exts/gobject-introspection-1.1.9/lib/gobject_introspection.so rbgobj_make_enum
rubygem-gobject-introspection.x86_64: W: undefined-non-weak-symbol /usr/lib64/gems/exts/gobject-introspection-1.1.9/lib/gobject_introspection.so rbgobj_gtype_new
rubygem-gobject-introspection.x86_64: W: undefined-non-weak-symbol /usr/lib64/gems/exts/gobject-introspection-1.1.9/lib/gobject_introspection.so rbgerr_gerror2exception
rubygem-gobject-introspection.x86_64: W: unused-direct-shlib-dependency /usr/lib64/gems/exts/gobject-introspection-1.1.9/lib/gobject_introspection.so /lib64/libpthread.so.0
rubygem-gobject-introspection.x86_64: W: unused-direct-shlib-dependency /usr/lib64/gems/exts/gobject-introspection-1.1.9/lib/gobject_introspection.so /lib64/librt.so.1
rubygem-gobject-introspection.x86_64: W: unused-direct-shlib-dependency /usr/lib64/gems/exts/gobject-introspection-1.1.9/lib/gobject_introspection.so /lib64/libdl.so.2
rubygem-gobject-introspection.x86_64: W: unused-direct-shlib-dependency /usr/lib64/gems/exts/gobject-introspection-1.1.9/lib/gobject_introspection.so /lib64/libcrypt.so.1
rubygem-gobject-introspection.x86_64: W: unused-direct-shlib-dependency /usr/lib64/gems/exts/gobject-introspection-1.1.9/lib/gobject_introspection.so /lib64/libm.so.6
rubygem-gobject-introspection.x86_64: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 26 warnings.
# echo 'rpmlint-done:'



Requires
--------
rubygem-gobject-introspection-doc (rpmlib, GLIBC filtered):
    rubygem-gobject-introspection

rubygem-gobject-introspection (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libcrypt.so.1()(64bit)
    libdl.so.2()(64bit)
    libgirepository-1.0.so.1()(64bit)
    libglib-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    libm.so.6()(64bit)
    libpthread.so.0()(64bit)
    librt.so.1()(64bit)
    libruby.so.1.9()(64bit)
    rtld(GNU_HASH)
    ruby
    ruby(abi)
    ruby(rubygems)
    rubygem(glib2)



Provides
--------
rubygem-gobject-introspection-doc:
    rubygem-gobject-introspection-doc

rubygem-gobject-introspection:
    gobject_introspection.so()(64bit)
    rubygem(gobject-introspection)
    rubygem-gobject-introspection
    rubygem-gobject-introspection(x86-64)



Unversioned so-files
--------------------
rubygem-gobject-introspection: /usr/lib64/gems/exts/gobject-introspection-1.1.9/lib/gobject_introspection.so

MD5-sum check
-------------
http://rubygems.org/gems/gobject-introspection-1.1.9.gem :
  CHECKSUM(SHA256) this package     : 9bff72651042d2715075483ddf5ad0b396cb8ad7f48fd6765421d1ce2a806f64
  CHECKSUM(SHA256) upstream package : 9bff72651042d2715075483ddf5ad0b396cb8ad7f48fd6765421d1ce2a806f64


Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29
Buildroot used: fedora-18-x86_64
Command line :/usr/bin/fedora-review -m fedora-18-x86_64 -n rubygem-gobject-introspection

Comment 6 Mamoru TASAKA 2013-02-10 15:50:20 UTC
no-soname is usual for just dlopen'ed objects (objects not under %_libdir but under the subdirectory of %_libdir).
Also undefined-non-weak-symbol is no problem because glib2.so (in rubygem-glib2) is always loaded before (there are many cases that dlopened objects have undefined non-weak symbols - e.g. python related C modules)
unused-direct-shlib-dependency means that gobject_introspection.so has unneeded extra dependency, however they are harmless.

http://mtasaka.fedorapeople.org/Review_request/rubygem-gobject-introspection/rubygem-gobject-introspection.spec
http://mtasaka.fedorapeople.org/Review_request/rubygem-gobject-introspection/rubygem-gobject-introspection-1.2.1-1.fc.src.rpm

* Mon Feb 11 2013 Mamoru TASAKA <mtasaka> - 1.2.1-1
- 1.2.1

Comment 8 Brendan Jones 2013-02-10 16:21:28 UTC
Thanks for the explanation. This package is APPROVED

Comment 9 Mamoru TASAKA 2013-02-17 18:08:00 UTC
Oh, I did not notice that this package was approved, thank you!

New Package SCM Request
=======================
Package Name: rubygem-gobject-introspection
Short Description: Ruby binding of GObjectIntrospection
Owners: mtasaka
Branches: f17 f18

Comment 10 Gwyn Ciesla 2013-02-18 14:44:20 UTC
Git done (by process-git-requests).

Comment 11 Mamoru TASAKA 2013-02-20 04:49:31 UTC
Built successfully on F-19/18/17, push requested for F-18/17, now closing.
Thank you for review and git procedure.


Note You need to log in before you can comment on or make changes to this bug.