Spec URL: http://ablu.fedorapeople.org/valyriatear.spec SRPM URL: http://ablu.fedorapeople.org/valyriatear-0.5.0-0.1rc2.fc17.src.rpm Fedora Account System Username: ablu Description: Valyria Tear is a free (as meant in the Gnu Public License) 2D J-RPG game based on the Hero of Allacrost engine. You can play it very much like a typical console role-playing game. You can explore maps and talk to non-playable characters (NPCs), fight active-time battles against multiple enemies, and manage your characters and equipment through a series of menus. Valyria Tear runs in a series of "game modes" which represent different states of operation in the game. Rpmlint: valyriatear.i686: W: spelling-error Summary(en_US) Valyria -> Valeria, Variably valyriatear.i686: W: spelling-error %description -l en_US Valyria -> Valeria, Variably valyriatear.i686: E: incorrect-fsf-address /usr/share/doc/valyriatear-0.5.0/COPYING valyriatear.src: W: spelling-error Summary(en_US) Valyria -> Valeria, Variably valyriatear.src: W: spelling-error %description -l en_US Valyria -> Valeria, Variably valyriatear-data.noarch: W: spelling-error %description -l en_US Valyria -> Valeria, Variably valyriatear-data.noarch: W: no-documentation 4 packages and 0 specfiles checked; 1 errors, 6 warnings. I reported the incorrect-fsf-address to upstream and they fixed it. Sadly no koji build since it takes very long to upload (somehow uploading to koji is even slower than regular upload). But i tested with mock. Regards Erik
The package fails to build on the newer LUA that comes with Fedora 18 (5.1.4). I've talked to Ablu and he said that a patch is coming soon to help fix this.
The issue with luabind is fixed now. New SRPM/Specfile with fixed new lua: SRPM http://ablu.fedorapeople.org/valyriatear-0.5.0-0.2rc2.fc17.src.rpm Specfile: http://ablu.fedorapeople.org/valyriatear.spec Use this update for review: https://admin.fedoraproject.org/updates/luabind-0.9.1-5.fc18 Regards Erik
Spec: http://ablu.fedorapeople.org/manaplus.spec SRPM: http://ablu.fedorapeople.org/valyriatear-0.5.0-1.fc18.src.rpm * Fri Feb 1 2013 Erik Schilling <ablu.erikschilling> 0.5.0-1 - New upstream release 0.5.0
Eh. Wrong link: Spec: http://ablu.fedorapeople.org/valyriatear.spec SRPM: http://ablu.fedorapeople.org/valyriatear-0.5.0-1.fc18.src.rpm * Fri Feb 1 2013 Erik Schilling <ablu.erikschilling> 0.5.0-1 - New upstream release 0.5.0
Key: - = N/A x = Pass ! = Fail ? = Not evaluated ==== Generic ==== [x]: EXTRA Rpmlint is run on all installed packages. [x]: EXTRA Spec file according to URL is the same as in SRPM. [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: MUST %build honors applicable compiler flags or justifies otherwise. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: MUST Buildroot is not present Note: Unless packager wants to package for EPEL5 this is fine [x]: MUST Package contains no bundled libraries. [x]: MUST Changelog in prescribed format. [x]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean would be needed if support for EPEL is required [x]: MUST Sources contain only permissible code or content. [x]: MUST Each %files section contains %defattr if rpm < 4.4 Note: Note: defattr macros not found. They would be needed for EPEL5 [x]: MUST Macros in Summary, %description expandable at SRPM build time. [x]: MUST Package contains desktop file if it is a GUI application. [-]: MUST Development files must be in a -devel package [x]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Package complies to the Packaging Guidelines [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf would be needed if support for EPEL5 is required [-]: MUST Large documentation files are in a -doc subpackage, if required. [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: MUST License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v3 or later)" For detailed output of licensecheck see file: /home/misc/checkout/git/FedoraReview/843646-sugar-india/licensecheck.txt [x]: MUST Package consistently uses macro is (instead of hard-coded directory names). [x]: MUST Package is named using only allowed ascii characters. [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generate any conflict. Note: Package contains no Conflicts: tag(s) [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [-]: MUST If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [x]: MUST Package is not relocatable. [x]: MUST Requires correct, justified where necessary. [x]: MUST Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [?]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. Note: Source0 (http://ablu.fedorapeople.org/%{name}-%{version}.tar.gz) [x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: MUST Package contains systemd file(s) if in need. [x]: MUST File names are valid UTF-8. [x]: SHOULD Reviewer should test that the package builds in mock. [x]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [-]: SHOULD Package functions as described. [x]: SHOULD Latest version is packaged. [x]: SHOULD Package does not include license text files separate from upstream. [!]: SHOULD SourceX tarball generation or download is documented. [-]: SHOULD SourceX / PatchY prefixed with %{name}. [x]: SHOULD SourceX is a working URL. [x]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: SHOULD Package should compile and build into binary rpms on all supported architectures. [-]: SHOULD %check is present and all tests pass. [x]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define. Issues: [?]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream lists github as the Source URL http://valyriatear.blogspot.de/p/downloads.html [!]: SHOULD SourceX tarball generation or download is documented. Note: Upstream Repository is https://github.com/Bertram25/ValyriaTear Rpmlint ------- Checking: valyriatear.spec valyriatear-0.5.0-1.fc18.src.rpm valyriatear.src: W: spelling-error Summary(en_US) Valyria -> Valeria, Variably valyriatear.src: W: spelling-error %description -l en_US Valyria -> Valeria, Variably 1 packages and 1 specfiles checked; 0 errors, 2 warnings. Other than the Upstream source, the Spec is fine.
The upstream only provides the tarball as github tag -> the filename is 0.5.3.tar.gz only. I only downloaded it, renamed and uploaded it again. I will add note to it.
Spec: http://ablu.fedorapeople.org/valyriatear.spec SRPM: http://ablu.fedorapeople.org/valyriatear-0.5.0-2.fc18.src.rpm * Fri Feb 1 2013 Erik Schilling <ablu.erikschilling> 0.5.0-2 - Fixed Gnu -> GNU - Added comment to Source0
As discussed in IRC: Spec: http://ablu.fedorapeople.org/valyriatear.spec SRPM: http://ablu.fedorapeople.org/valyriatear-0.5.0-3.fc18.src.rpm * Fri Feb 1 2013 Erik Schilling <ablu.erikschilling> 0.5.0-3 - Fixed download link to github directly
Perfect. Review done.
Thanks a lot! New Package SCM Request ======================= Package Name: manaplus Short Description: Valyria Tear is a free 2D J-RPG based on the Hero of Allacrost engine Owners: ablu Branches: f17 f18 InitialCC: Accidently setted fedora-cvs to ? before.
Requested package name manaplus doesn't match bug summary valyriatear, please correct.
Ah sorry! Second time i mix up the two packages today :( Not my day I guess. New Package SCM Request ======================= Package Name: valyriatear Short Description: Valyria Tear is a free 2D J-RPG based on the Hero of Allacrost engine Owners: ablu Branches: f17 f18 InitialCC:
Git done (by process-git-requests).
valyriatear-0.5.0-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/valyriatear-0.5.0-3.fc18
valyriatear-0.5.0-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/valyriatear-0.5.0-3.fc17
Package valyriatear-0.5.0-3.fc18: * should fix your issue, * was pushed to the Fedora 18 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing valyriatear-0.5.0-3.fc18' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-1924/valyriatear-0.5.0-3.fc18 then log in and leave karma (feedback).
valyriatear-0.5.0-3.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report.
valyriatear-0.5.0-3.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report.